| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
While sandboxed, we add the first file in the queue to recents.
This has two problems:
* The file is added to recents even if we fail to launch.
* If opening multiple files, we forget to add the others to recents
Instead, add each file to recents for each successful launch.
|
| |
|
|
|
| |
Now that the async files opening path is only used while sandboxed,
the conditions for these if blocks (not being sanboxed) is never met.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While sandboxed, we open files using the OpenURI portal, and we don't
know which app is the default handler app for each file. As such, we
have given up group-launching files with the same default handler when
adapting nautilus to being sandboxed.[0]
But this resulted in a feature regression in the non-sandboxed case,
which is still the common case in production.
Reinstate the code for the old behaviour[1], but keep the current
behaviour when running in inside a flatpak sandbox.
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/117
[0] f5206a6daf0991d91e885a28bb66795a8ae12a41
[1] based on revert patch with revert conflicts resolved by hadess
|
| |
|
|
|
|
| |
This pointer may be NULL. Usually this may happen only during window
initialization and destruction. However, for robustness, make sure
every use either handles a NULL pointer or asserts it's non-NULL.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to explicitly set the active slot when closing a tab. However,
we now let GtkNotebook pick the next tab, and wait for ::switch-tab to
set the active_slot field to the one GtkNotebook picked, thanks to
commit 475684ac9e556b144da594bf25581560d4fa5a7f.
However, if the closed tab was the only tab in this window, then
::switch-tab is never called, so active_slot becomes a dangling
pointer, crashing the application when trying to close the window.
Use a weak reference to ensure the pointer is set to NULL in that case.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1759
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After removing the non-default "icons on desktop" functionality from
nautilus, a gnome-shell extension was created as a substitute. This
extension needed to interoperate with nautilus for file operations,
but its access to clipboard was limited to plain text, so, in order to
ensure interoperation, nautilus had to use plain text clipboard only.
However, this temporary regression resulted in implementation details
leaking into the text clipboard, instead of a plain file path.
But now St.Clipboard can handle any type of clipboard content[1], the
extension will be able to handle any clipboard type, so we can finally
fix this regression on our side.
This reverts commit 1f77023b5769c773dd9261e5294c0738bf6a3115
and its fixup commit be53569b339b4494647758a9afa0fdd30184455b
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/634
[1] GNOME/gnome-shell@ec367623
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was set to flathub because we used to depend on a stable runtime. [1]
We have since changed to depend on the unstable runtime[2], but the
Nightly flatpakref still configures the wrong repo on
installation. If the user didn't have the gnome-nightly repository
configured in advance, then the runtime cannot be found, failing the
installation.[3]
Update the repo URL, which I should have done in [2].
[1] c4afd14696c670db8fbb64dcc4ea2f0807d25a94
[2] d95a616116bb8c02b01261afa3ed5b581f9f2e74
[3] https://blogs.gnome.org/antoniof/2021/03/05/files-40-beta-more-productivity-and-some-eye-candy/#comment-541
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
The CI currently fails because the latest libhandly release is not yet
in rawhide. Let's add libhandy master to our image to fix the pipeline.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
We can't use HdyStatusPage right now because it would break DnD, as
reported in https://gitlab.gnome.org/GNOME/gtk/-/issues/808
So, update the styling instead.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Currently, gtk_builder_add_from_resource silently fails with old libhandy
version which leads to weird crashes. Let's print the returned error to
be obvious what is going on.
|
| |
|
|
|
| |
Nautilus currenlty crashes with libhandy version older than 1.1.90.
Let's bump the dependency to prevent that.
|
| |
|
|
|
|
|
|
|
|
| |
We have been matching the Star column by it's title, ever since it was
first introduced by commit a9c446afe262b7989bc17ef1f9ab19931db8dede
Worse: we have been using an untranslated string. This means that if
the string is localized clicking the star icons does nothing.
Match the column by its key in the hash table instead.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While "Star" is 4 chars long in English, it's longer in other languages.
This means the column may become much wider than needed for displaying
a small star icon, which both looks bad and takes away space from other
columns.
Since this is a column of star symbols, we don't really need a title.
But setting an empty title makes the columns too narrow (16px), which
gets covered by the overlay scrollbar.
So, in addition to removing the title label, set a 48 fixed width for
the column, which provides enough gutter for the overlay scrollbar.
|
| | |
|
| | |
|
| |
|
|
| |
Or, rather, dim the dirnames so the basenames stand out.
|
| |
|
|
|
|
|
|
| |
If the user enters a relative path, we get absolute paths as in the
completion popover, which is quite jarring and makes it less useful.
Instead, truncate the prefix, such that the completions dropdown text
aligns with the entry text.
|
| |
|
|
| |
Replace g_strchomp and g_strchug with g_strstrip, for simplicity.
|
