| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
| |
Instead of the XDG directory name; this makes name edits from the
Bookmarks window apply correctly to the sidebar.
Likewise, allow renaming of XDG bookmarks from the context menu.
|
|
|
|
|
|
|
|
| |
If an XDG bookmark has been removed from ~/.config/user-dirs.dirs, or if
its entry there points to an invalid directory, don't add it to the
places sidebar.
https://bugzilla.gnome.org/show_bug.cgi?id=645054
|
|
|
|
|
|
|
| |
If the directory is in the bookmark list already (or if it's the home
directory), don't offer to bookmark it again.
https://bugzilla.gnome.org/show_bug.cgi?id=327707
|
|
|
|
| |
Using the previously added API.
|
|
|
|
|
| |
Avoid GFile<->URI roundtrips if possible. Also, this will allow us to
use the same API for another purpose.
|
|
|
|
|
| |
We will create a GFile internally and most of the times we have a GFile
already, so change NautilusLocationEntry to just use a GFile too.
|
|
|
|
|
|
|
|
|
|
| |
We already do this for all other kind of references, and I think it
makes sense to do it for symbolic links too.
This also ensures applications don't have to deal with e.g. ensuring
backup files are saved relative to the original file and not the
symlink, as reported in
https://bugzilla.gnome.org/show_bug.cgi?id=686465
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nowadays, we rely on G_FILE_MONITOR_EVENT_UNMOUNTED to be emitted when a
mount disappears, since we already monitor the directory, in order to
switch the view to a different location.
Since non-native mounts very likely won't have file monitoring though,
we're not going to receive such events in that case, and fail to
redirect the view as a consequence.
This patch fixes it by listening to the mount-removed signal on
GVolumeMonitor when a monitor is requested for a non-native mount, and
emulating a file removal in that case.
https://bugzilla.gnome.org/show_bug.cgi?id=684226
|
| |
|
|
|
|
|
|
| |
We might be refreshing while the mount disappears; in that case, the
pathbar will try to get a symbolic icon from a NULL mount, hitting an
assertion.
|
| |
|
| |
|
|
|
|
|
| |
No need for nautilus_bookmark_copy(), when we can just g_object_ref()
the object.
|
|
|
|
| |
Didn't mean to remove this line.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Don't assume there's only one engine running at the time, and avoid
requiring state from the global app singleton in search callbacks.
This fixes a crash where we would dereference NULL in the hits-added
callback, since we would access it through the global app object, and
self->active_search was previously cleared on cancellation.
https://bugzilla.gnome.org/show_bug.cgi?id=686168
|
|
|
|
|
| |
Add some code in the search engine test to verify cancellation and
NautilusSearchEngine model work properly.
|
|
|
|
|
|
|
|
|
|
|
| |
Keep a ref to the engine while the async search is in progress. This is
what all the other engines do, and not doing it causes problems when
cancelling the operation.
While we're at it, also refactor the completion notification code in a
single function.
https://bugzilla.gnome.org/show_bug.cgi?id=686168
|
|
|
|
|
| |
If we get stopped while the directory ready callback is pending, make
sure to still emit the finished signal on the provider.
|
|
|
|
|
| |
This way, we can ensure the engine will be alive when the providers
finish.
|
|
|
|
|
| |
It makes sense for a query object to always be relative to a specific
location, so just initialize the query URI to g_get_home_dir().
|
|
|
|
|
|
|
|
|
|
| |
Add another input-only child to the parent GdkWindow's for events and
imcontext. Since we will be painted in a GtkLayout, using only one
input-only window won't work well with scrolling, but this way we can
ensure that whatever GdkWindow the XIM engine will try to ensure native,
it won't be our (floating) drawing window.
https://bugzilla.gnome.org/show_bug.cgi?id=686053
|
|
|
|
|
|
|
| |
This reverts commit b67360316cf975c85569527f55803cad1ea5e28e.
It breaks scrolling, as explained in
https://bugzilla.gnome.org/show_bug.cgi?id=686322
|
|
|
|
|
|
|
|
| |
Use the same behavior of GtkEntry i.e. create an input only GdkWindow
for the text area. This avoids the text area becoming black when it's
used together with the XIM module.
https://bugzilla.gnome.org/show_bug.cgi?id=686053
|
|
|
|
|
|
|
| |
We used to do this implicitly, but
6b5ffd4e8841202d31e444358b542ffbeac516bf made it necessary to call it
manually, since we avoid g_application_register() when we perform self
checks.
|
|
|
|
|
| |
Since this is never emitted, keeping the code around just makes it more
complicated.
|
| |
|
|
|
|
|
|
| |
So that they get the same kind of bonus they would if they matched with
the other engines. The FTS rank that tracker gives us is added as
another bonus.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
When we're getting reloaded, we should wait for the completion of all
engines before triggering a new search. When this happens, set an
internal restart flag and apply it when the last provider returns.
This avoids finished signals from providers that complete the previous
search after a while to being interpreted for the current search.
|
|
|
|
|
| |
There's no need to send a last batch of results if we are returning
because of a cancellation.
|
|
|
|
| |
See previous commit.
|
|
|
|
| |
So that start() will work if called directly from the finished callback.
|
|
|
|
| |
We don't want this to become bigger than the proximity bonus.
|
|
|
|
|
| |
This also allows us to use a heuristic to evaluate how good the filename
match is.
|
|
|
|
|
| |
Using an auxiliary hash table gives us better performance for large
directories, as we avoid constantly walking the list.
|
|
|
|
|
| |
Make sure that we emit either finished or error when all the providers
have finished.
|
|
|
|
|
| |
Otherwise the search hits hash table won't be cleared when search is
stopped, leading to missing results.
|
|
|
|
|
| |
This ensures the simple engine won't crawl in hidden directories, unless
necessary.
|
|
|
|
|
|
|
|
|
| |
And among those with the same distance from the search root, add more
bonus for recency and FTS rank. This ensures results don't move too much
when searching recursively.
Also, while we're at it, change the code to use GFile instead of simple
string comparisons.
|
|
|
|
|
| |
This checks the URI, so it will always return FALSE, since files in
NautilusSearchDirectory have the real URI of the location.
|
|
|
|
|
| |
Keep code to start and stop the search engine in a single place, create
it together with the directory and simplify start/stop invariants.
|
|
|
|
| |
This is completely unused now.
|
| |
|
| |
|
|
|
|
|
|
|
| |
Add a query property we can set to false from the shell provider, and
use it in the simple search engine to exclude hidden files. Note that by
default the query sets it to TRUE, so the behavior in Nautilus is
unchanged.
|
| |
|