| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to the toolbar menu reorganisation work, the code to create and
manage the undo/redo items on the menu ended up in files-view.c. This
isn't the correct place as they don't have much to do with the files
view. Some refactoring was needed before the code for these items could
be moved back into the toolbar, which has now been done in a previous
commit.
This commit moves the undo/redo creation and management code into the
toolbar.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we have this menu structure:
------------------------------
1. New Folder/New Tab/Bookmark
------------------------------
2. Zoom controls
------------------------------
3. Undo/Redo
------------------------------
4. Sort options
------------------------------
5. Other view related controls
------------------------------
The view creates 2-5, contained in a single GtkWidget - which is then
passed to the toolbar via the enclosing window slot. The problem is that
3 shouldn't be created or managed by the view as the controls in that
section of the menu are not related to the view. We'd like to move this
responsibility back to the toolbar, but that would mean the view must
pass multiple menu sections back to the toolbar (as 3 is in the middle
of the other view controls).
This change allows the view to pass multiple sections back to the
toolbar, using the new NautilusToolbarMenuSections structure. The files
view now passes 2 as a separate section to 3-5 (3 will be moved out of
the view in a future commit).
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
| |
The menu previously remained open when the New Folder prompt appeared,
if New Folder was selected from the menu. This change closes the menu
when New Folder is selected.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
| |
The popover ui definition was in the toolbars definition file which was
getting pretty big. Have moved the popover definition into its own file,
to separate things out a bit.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
|
|
|
| |
The files view creates and owns these buttons currently, meaning they
aren't shown on the menu when the Other Locations view is active.
This change moves the menu items from the view's toolbar menu ui file
and into the ui file for the shared popover, so that the buttons are
also shown for Other Locations.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior changes to merge the view and action menus essentially moved the
action menu items into the view menu. This was the path of least
resistance; the view has a lot of hooks on items in the view menu,
whereas the there are very few hooks on items in the action menu,
meaning the latter could be moved more easily.
However, previously the view menu was disabled for Other Locations and
the action menu wasn't. So the side effect of the changes is the
remaining menu is now disabled completely on Other Locations. There are
a couple of items that could be shown for Other Locations (e.g. New
Tab), so we still want to show a menu, but this involves some
refactoring so has been deferred until now.
This commit is the first part of the refactoring; the files view owns
the menu popover, meaning that the Other Locations view doesn't have
access to it. This commit moves the ownership of the menu popover to the
toolbar. Future commits will move the common items into the popover so
all views will show them.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sort options shown on the toolbar menu aren't very intuitive. For
example, 'last modified, reverse order' can be interpreted a number of
ways. They also require the user to set both the sort order and whether
the sort should be reversed. These issues have been addressed by
replacing the sort order items that are often sorted in either ascending
and descending order (e.g. name) with options that are better to use
(e.g. A-Z and Z-A). Options that are generally only sorted one way
(e.g. type) have been changed to sort in ascending/descending as
appropriate for the option.
This is part of the toolbar menu redesign to improve the usability of
the menus.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
|
| |
This sort option is never shown in the menu and therefore doesn't need
to be in the menu xml. The view is sorted on search relevance when the
user is searching, however all of the sort options are hidden in this
case.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
|
| |
The "Sort" heading in the toolbar menu doesn't look right; it has less
vertical padding than the surrounding menu items, and is indented one
pixel more. It also doesn't need to be bold - this commit addresses
these issues.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
|
|
| |
Convert the zoom slider into a horizontal button list, with a button in
the middle to show the current zoom level percentage.
This is part of the toolbar menu redesign to improve the usability of
the menus.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
| |
Converted these from three separate menu items into a horizontal button
list, and moved them to the top of the menu, as part of the menu
redesign.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
| |
Moved them to above the sort options, as part of the toolbar menu
redesign.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Usability tests conducted by Gina Dobrescu have highlighted a number of
issues with the toolbar menus. Users can't switch between list and grid
mode with a single click, and they have struggled to find the switch
between list and grid mode.
Allan Day has come up with a design to address these problems. The view
and action menus have been combined into a single menu, and we have
added a new button to the toolbar which toggles the view mode between
list and grid mode.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for merging the view menu into the action menu.
The action menu is currently a GMenu, which doesn't support the controls
we have on the view menu, e.g. the zoom slider and the button rows.
Converting to a GtkPopoverMenu will allow us to merge the menus.
This is part of the toolbar menu redesign to improve the usability of
the menus.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
| |
|
|
|
|
|
|
|
|
|
| |
Don't write the zoom level to gsettings if the user has not made a
change from the system default. This allows an update to be installed
and then rolled back without a system default from the update having
been written to the user's configuration.
https://bugzilla.gnome.org/show_bug.cgi?id=767878
|
| |
|
|
|
|
|
|
| |
The shortcut for ‘cut’ was missing from the shortcut list. This commit adds it.
https://bugzilla.gnome.org/show_bug.cgi?id=765532
|
| |
|
| |
|
|
|
|
|
|
| |
With new GCC6.
https://bugzilla.gnome.org/show_bug.cgi?id=767616
|
| |
|
| |
|
|
|
|
|
|
|
| |
So that the menu doesn't show at random places under Wayland which
expects all subsurfaces to have a parent surface.
https://bugzilla.gnome.org/show_bug.cgi?id=767446
|
|
|
|
|
|
|
| |
GTK's parser now started to complain about gradients with a single
color stop ...
https://bugzilla.gnome.org/show_bug.cgi?id=767430
|
| |
|
|
|
|
| |
(cherry picked from commit f719eb8707cd41532514dd643823253bbd007e68)
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This fixes a problem where a double click on an item in Nautilus icon view did
not activate the moment when moving the pointer even slightly in between the two
clicks.
https://bugzilla.gnome.org/show_bug.cgi?id=748501
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When renaming a file from the popover, the code checks if there is an
existing file with the name entered and the name entered does not match
the name of the file being renamed. That has a side effect of allowing
the original filename to be entered without reporting an error.
Some problems arise when the model includes files from different
directories (e.g. when searching or expanding directories in the list
view).
When searching, the code will not allow a rename if there are files
with the entered name, despite being in separate directories.
When renaming a file in an expanded directory, the code will ignore
files inside it and only check the currently opened one. This also
applies when creating new folders.
This commit fixes that by checking for duplicate names inside the parent
directory when renaming and checking the directory at
nautilus_file_view_get_backing_uri() when creating new folders.
https://bugzilla.gnome.org/show_bug.cgi?id=757385
|
| |
|
| |
|
| |
|
|
|
|
| |
(cherry picked from commit b07589fe7eeaf94540b19d56a27c583f889f4096)
|
|
|
|
| |
(cherry picked from commit 6048dc4eb3f91352bfc896d4f678c089fba76632)
|
|
|
|
|
|
|
|
|
|
|
|
| |
The custom icon selection GtkFileChooserDialog is unresponsive when
opened. This is caused by the properties dialog window being modal,
since it is up to the window manager how to process input in such
situations.
One of the ways to ensure that the child dialog receives and processes
user input is by making it modal. This commit makes it such.
https://bugzilla.gnome.org/show_bug.cgi?id=753394
|
| |
|
|
|
|
| |
(cherry picked from commit f27588d73c4f4d579864bd29038b1097fcf37e44)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The to_delete GList* gets initialized in trash_files() and is supposed
to be filled by trash_file() so that we know which files we want to
delete directly when the call to g_file_trash() fails for some reason.
However, this GList* gets modified in place by calls to g_list_prepend()
and so those changes will only be seen by the to_delete argument inside
trash_file(), but not by the local variable defined in trash_files(), which
will continue to point to NULL regardless of those changes.
So, we simply need to pass a reference to the GList* so that any change done
to the structure of the GList* inside trash_file() is seen in trash_files().
https://bugzilla.gnome.org/show_bug.cgi?id=766030
|
|
|
|
|
|
|
|
|
|
| |
The call to gtk_message_dialog_format_secondary_text() in
show_unhandled_type_error() is missing a format argument, which causes
build failures with -Werror=format-security.
This commit adds the missing argument.
https://bugzilla.gnome.org/show_bug.cgi?id=765918
|
|
|
|
| |
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=765792
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Currently, atk_focus_tracker_notify() is used, which is deprecated as
of ATK 2.9.4. Using atk_object_notify_state_change() with
ATK_STATE_FOCUSED is recommended. The deprecated call was replaced.
- For every selection, the previous one should get unfocused.
Currently, only the keyboard focus is tracked. That was extended to
mouse focus with a flag for keyboard focus for indicator rendering.
https://bugzilla.gnome.org/show_bug.cgi?id=762236
|
|
|
|
|
|
|
|
|
| |
atk_focus_tracker_notify() has been deprecated since ATK 2.9.4 and using
atk_object_notify_state_change() is recommended.
This commit replaces the call to the deprecated function.
https://bugzilla.gnome.org/show_bug.cgi?id=762236
|
|
|
|
|
|
|
|
|
|
| |
AtkComponentIface's {add,remove}_focus_handler should not be overridden,
since ATK 2.9.4, as atk_component_{add,remove}_focus_handler() are
deprecated.
This commit removes deprecated virtual function overrides.
https://bugzilla.gnome.org/show_bug.cgi?id=762236
|
|
|
|
|
|
|
|
|
| |
atk_component_get_position() has been deprecated since ATK 2.12 and
using atk_component_get_extents() is recommended.
This commit replaces calls to the deprecated function.
https://bugzilla.gnome.org/show_bug.cgi?id=762236
|