| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
| |
Currently, gtk_builder_add_from_resource silently fails with old libhandy
version which leads to weird crashes. Let's print the returned error to
be obvious what is going on.
|
|
|
|
|
| |
Nautilus currenlty crashes with libhandy version older than 1.1.90.
Let's bump the dependency to prevent that.
|
|
|
|
|
|
|
|
|
|
| |
We have been matching the Star column by it's title, ever since it was
first introduced by commit a9c446afe262b7989bc17ef1f9ab19931db8dede
Worse: we have been using an untranslated string. This means that if
the string is localized clicking the star icons does nothing.
Match the column by its key in the hash table instead.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While "Star" is 4 chars long in English, it's longer in other languages.
This means the column may become much wider than needed for displaying
a small star icon, which both looks bad and takes away space from other
columns.
Since this is a column of star symbols, we don't really need a title.
But setting an empty title makes the columns too narrow (16px), which
gets covered by the overlay scrollbar.
So, in addition to removing the title label, set a 48 fixed width for
the column, which provides enough gutter for the overlay scrollbar.
|
| |
|
| |
|
|
|
|
| |
Or, rather, dim the dirnames so the basenames stand out.
|
|
|
|
|
|
|
|
| |
If the user enters a relative path, we get absolute paths as in the
completion popover, which is quite jarring and makes it less useful.
Instead, truncate the prefix, such that the completions dropdown text
aligns with the entry text.
|
|
|
|
| |
Replace g_strchomp and g_strchug with g_strstrip, for simplicity.
|
|
|
|
|
|
|
|
|
| |
Improves tab completion in the location entry. GtkEntryCompletion
shows a popup when there are multiple matches, so you can choose one
or continue typing. The completion's tree model is populated
dynamically as you type using a GFilenameCompleter.
https://gitlab.gnome.org/GNOME/nautilus/-/issues/1171
|
|
|
|
|
|
|
| |
When you press Tab in the location entry and there's no autocomplete
suggestion, play an error bell instead of closing the location entry.
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1171
|
|
|
|
|
| |
It hasn't been useful for quite a while, and messes with the visual alignment
of the GtkEntryCompletion.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
The suggested name is in the form "original (1).txt", if the the
conflicting name was "original.txt".
The user may want to replace the "(1)" bits with something more
meaningful, so select this region for convenience.
|
|
|
|
|
|
|
|
|
|
|
|
| |
When "Select new name for the destination" expander is selected, the
users must type a new name in order to proceed.
This makes them go and look at the destination to see what would even
make a unique name.
Let's be more helpful and suggest a unique name based on the original.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/1344
|
|
|
|
|
|
|
| |
.nautilus_directory holds a reference to a NautilusFile.
Rename it to .nautilus_directory_file, so that the existing name can
be reused to store a NautilusDirectory reference in the next commit.
|
|
|
|
|
|
|
|
|
|
|
| |
The default action "Replace" is changed to "Rename" if a different name
is set in the entry inside the "Select a new name..." expander.
This means we have inconsistent UI states:
* "Select a new name..." is expanded but the action is "Replace",
* or it's collapsed but the default action is "Rename".
Instead, let's tie the default action to the expander's state.
|
|
|
|
|
| |
This is needed to prevent the "signal 'request-passphrase' is invalid
for instance '0x1e41340' of type 'AutoarExtractor'" warnings.
|
|
|
|
|
| |
The CI currently fails because the gnome-autoar 0.3.0 is not yet in rawhide.
Let's add gnome-autoar master to our image to fix the pipeline.
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implementation launches a GtkDialog for users to enter a password
when gnome-autoar reports that a given archive is password protected.
We use an additional GMainContext to block the execution until a password
string can be passed to AutoarExtractor's "passphrase-request" signal. This
solution is an alternative to gtk_dialog_run(), which is not available
in GTK4. See https://ondrej.holych.net/how-to-call-asynchronous-function-synchronously/
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/327
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Providing guidance for what the trade offs are.
|
|
|
|
|
|
| |
Add a group descritpion to avoid long labels in the rows, use the
exact label of the menu items instead. Also hint that keyboard
shorcuts can be used instead of making the menu longer.
|
|
|
|
|
|
|
|
|
|
| |
The Preferences have been recently cleaned up, which now enables us to
reorganize them in a single page using modern design patterns.
Use HdyPreferencesWindow for convenience of implementation, as well
as for the rounded bottom corners and adaptivity to small sizes.
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1258
|
|
|
|
|
|
| |
We have a few includes, defines and tree models which we no longer use.
They used to be need for widgets and options which are long gone.
|
|
|
|
|
|
| |
The fedora rawhide CI job fails currently as the image doesn't contain
libhandy package, which is new Nautilus dependency. Let's add the package
to fix the CI job.
|
| |
|
|
|
|
|
|
| |
As we have already done for the app's main window.
In this case, we must use HdyWindow.
|
|
|
|
|
|
| |
The bottom corners of the window have an 8px radius now. The floating
status bar shares a corner with the window, but the opposite corner
has a smaller radius, which doesn't look good. So, make it 8px too.
|
|
|
|
|
| |
CSS alone is not enough to achieve the desired result. The required
pieces are provided by HdyApplicationWindow.
|
|
|
|
| |
It provides widgets we need for the enhancements in the next commits.
|
|
|
|
|
|
| |
This will allow us to easily set up HdyWindow,
as otherwise we'd need to use GtkContainer APIs
that will be removed in GTK4
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While dragging items over the list view, the row which accepts drops in
the current pointer position has its top border highlighted, but not the
bottom border, as indended by the default stylesheet.
This had already been fixed.[1] The regression happened because GTK has
stopped using .dnd style class, instead using :drop(active).[2]
The previous fix ([1]) consisted in not highlighting any border at all,
with the rationale that "we already modify the icon to hint about dnd".
This is based on the assumptions that:
1. folder icons change to the folder-open icon;
2. folders are the only drop targets.
But these assumptions do not hold:
1. the folder-open icon is not used if a folder has a custom image
instead of the default icon, or if a thumbnailer is installed;
2. some non-folder items, such as archive files, accept drops too.
So let's fix this the other way around: highlighting both borders,
above and below, as intended by the default stylesheet.
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1525
[1] https://gitlab.gnome.org/GNOME/nautilus/-/commit/4963cd7d564b633299f8e31bb8ac10f67eae6477
[2] https://gitlab.gnome.org/GNOME/gtk/-/commit/12c5ca5c013e035374ad1590b0e64cb7a452aa30
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unlike most preferences, changing this may have no effect on open
windows, which is unexpected.
This affects only new folders without any per-folder override, which
has diminute value.
Remove this from the Preferences window. The gsettings key is preserved.
Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1312
First part of https://gitlab.gnome.org/GNOME/nautilus/-/issues/1703
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When preparing to drop the Application Menu, this was added to the
Preferences window.[1]
Later when actually dropping the Application Menu, the action was
added to the primary window menu.[2]
So, it ended up in 2 places, which it not necessary.
The sidebar is essential for navigation, so hiding is only tempoary,
not a long-lasting preference. So, it doesn't make sense to have here.
[1] commit f2061e94093a33072e792181433b0618bf68d1b2
[2] commit 99324771868ca7fad75889418ecd08765d8b4629
|
|
|
|
|
|
|
|
|
|
|
|
| |
It applies only to image files, which is unexpected. The drawbacks of
setting a higher value are not explained either. How much is too much?
The last commit has raised the default value to a hopefully high
enough value making this UI control even less useful.
The gsettings key is preserved for now.
https://gitlab.gnome.org/GNOME/nautilus/-/issues/1309
|
|
|
|
|
|
|
|
| |
This was last updated 12 years ago.
Assuming 10MB is too low given today's hardware, make that 50MB.
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1309
|
| |
|
| |
|