| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
With the extract operation being handled internally, compressed files can be
automatically extracted instead of being opened in file-roller. In order to
implement this, make extraction the default action for activating selected
archives.
https://bugzilla.gnome.org/show_bug.cgi?id=768646
|
|
|
|
|
|
|
| |
The context menu actions are similar to the ones offered by file-roller, but
make use of the internal extract operation.
https://bugzilla.gnome.org/show_bug.cgi?id=768646
|
|
|
|
|
|
| |
Add a new operation for extracting archives using gnome-autoar.
https://bugzilla.gnome.org/show_bug.cgi?id=768646
|
|
|
|
|
|
|
|
|
|
|
| |
Both the delete and copy operations in Nautilus deal with deleting files
recursively. Each operation has its own implementation of the same
functionality, mixed with specific logic, like error reporting through dialogs.
In order to remove duplicated code, extract delete logic to a separate function
which can be used by both operations.
Implement a function for deleting files recursively which reports errors and
success through an user provided callback.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Nautilus, file conflicts are handled by a specific dialog. Previously, the
dialog class managed both the UI and the related nautilus files. This lead to it
being inflexible due to operation specific logic being mixed with the rest of
the functionality. In order to change this, move file logic to a separate module
and add methods for controlling the UI elements in the dialog.
Create an operation-manager module to handle dialog controlling. Move anything
related to Nautilus files from the dialog class to the new module.
https://bugzilla.gnome.org/show_bug.cgi?id=768646
|
|
|
|
|
|
|
|
|
| |
The current implementation leaks the NautilusFileUndoManager instance,
because the code does not unref it anywhere. This commit adds a _new()
function to the undo manager and makes NautilusApplication manage its
lifetime.
https://bugzilla.gnome.org/show_bug.cgi?id=769082
|
|
|
|
|
|
|
|
| |
Currently, the icon info caches are cleared in quit_mainloop(), which
does not get invoked as of GLib 2.32, thus resulting in NautilusIconInfo
leaks. This commit moves the cache clearing call to shutdown().
https://bugzilla.gnome.org/show_bug.cgi?id=769134
|
|
|
|
| |
Future versions of gettext will fail if this header is missing.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window-slot binds with query-editor via a property, which results in
nautilus_query_editor_set_location() being called on construction and
location changes. That function in turn calls
update_information_label(), which takes a ref on the file, but does not
release it. This can result in a crash with remote bookmarks when
connecting/disconnecting or switching back and forth.
This commit fixes that by adding an unref to update_information_label().
https://bugzilla.gnome.org/show_bug.cgi?id=768987
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting with GTK+ 3.21, Nautilus is constantly reporting
underallocations happening in the path bar. That is chiefly caused by
some assumptions made in the code (i.e. both slider buttons are of the
same width, which is untrue, due to the “linked” style class).
This commit corrects those assumptions by using widths of both slider
buttons in allocation calculations.
https://bugzilla.gnome.org/show_bug.cgi?id=768916
|
|
|
|
|
|
|
|
|
| |
g_file_is_native() should be enough to decide whether the file is local.
Checking if g_file_get_path() returns a native path lets us know if the
directory is possibly made available by use of FUSE and there is
nautilus_directory_is_local_or_fuse() for that.
https://bugzilla.gnome.org/show_bug.cgi?id=768733
|
|
|
|
|
|
|
|
|
| |
The condition when cancelling the dialog was always true, and therefore
always setting the apply_to_all.
It was harmless due to the dialog being canceled anyway.
Thanks to Michael McConville to create the original patch.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
The build fails on systems with GLib versions older than 2.49.1. That is
due to changes in GtkPlacesView, which require new symbols. This commit
bumps the version requirement in configure.ac to inform the user during
the configure phase.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to the floating bar being in an overlay, it can obscure the content
under it.
We were planning to remove it and use an action bar. But it's taking
long, so in the meantime we can improve this situations hiding the
floating bar when hovered.
On the way I improved the handling of the spinner, which was failing
to be shown on certain situations.
Patch based on Nelson Benitez, thanks!
https://bugzilla.gnome.org/show_bug.cgi?id=651293
|
|
|
|
|
|
|
|
| |
The currently used revision doesn't generate .gitignores that ignore
object files from all subdirectories. This is fixed in the newer
revisions.
https://bugzilla.gnome.org/show_bug.cgi?id=768724
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=768657
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Build failure in Continuous:
../../test/test-file-utilities-get-common-filename-prefix.c: In function
'test_many_strings':
../../test/test-file-utilities-get-common-filename-prefix.c:366:9:
error: 'for' loop initial declarations are only allowed in C99 or C11
mode
for (int i = 0; i < 500; ++i) {
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New Folder with Selection currently doesn't offer a folder name. It
would be better if it suggested a folder name based on the files that
are selected.
With this change, it now looks for a common filename prefix of the
selected files, and pre-populates the folder name entry with that. If no
common prefix is found that is greater than 3 characters long, the
folder name entry will be left blank.
https://bugzilla.gnome.org/show_bug.cgi?id=747907
|
|
|
|
|
|
|
|
| |
GSimpleAsyncResult utilities have been deprecated since GLib version
2.46 and using GTask is recommended. This commit replaces the
deprecated code.
https://bugzilla.gnome.org/show_bug.cgi?id=768175
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Some button icons don't convey the intended meaning very well (e.g. the
new tab button). This commit adds tooltips to all the buttons in the
view menu.
https://bugzilla.gnome.org/show_bug.cgi?id=768135
|
|
|
|
|
|
|
|
|
|
|
| |
nautilus_file_compare_display_name() is only used by
nautilus_directory_get_file_by_name() nowadays and it was written with
sorting in mind. As g_utf8_collate() and its locale dependence does not
work well with finding matching files by name, it makes sense to replace
the call to g_strcmp0(). That, however, makes the function less suitable
for sorting. This commit changes its purpose as described.
https://bugzilla.gnome.org/show_bug.cgi?id=768074
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
nautilus_file_get_date_as_string() uses today's date and the GDateTime
constructed from the return value of nautilus_file_get_date(), which
also includes the time of day, thus making the calculation of the
day difference incorrect. To illustrate, files, modified two days ago
can appear to have been modified yesterday.
This commit fixes that by calculating the day difference of the dates
with the time value of 00:00:00.
https://bugzilla.gnome.org/show_bug.cgi?id=756402
|
|
|
|
|
|
|
|
|
| |
As the manual page has been last updated in 2004, some sections are
outdated. This commit updates the option list, the link to the Nautilus
online page, adds a bugs section and tweaks the formatting to make the
source more readable.
https://bugzilla.gnome.org/show_bug.cgi?id=733909
|
| |
|
|
|
|
|
|
|
| |
An action for setting the standard zoom level has been added, but it has
no accelerators. This commit adds one.
https://bugzilla.gnome.org/show_bug.cgi?id=763948
|
|
|
|
|
|
|
|
| |
nautilus_application_add_accelerator() is ambiguous in that it conveys
that the function appends an accelerator to the list. This commit
removes the ambiguity by renaming the function accordingly.
https://bugzilla.gnome.org/show_bug.cgi?id=763948
|
|
|
|
|
|
|
|
|
| |
nautilus_application_add_accelerator() only allows setting a single
accelerator, which in some cases is not enough. This commit adds a
wrapper for gtk_application_set_accels_for_action(), which takes an
array of accels.
https://bugzilla.gnome.org/show_bug.cgi?id=763948
|
|
|
|
|
|
|
|
|
| |
Both ctrl-= and ctrl-+ are commonly used for zooming in for
consistency, as some keyboard layouts require pressing another modifier
to access the plus symbol. This commit adds ctrl-= as another
accelerator for zooming in.
https://bugzilla.gnome.org/show_bug.cgi?id=763948
|
|
|
|
|
|
|
|
| |
Restoring to the default zoom level does not work anymore, as Nautilus
sets the default level to the current one. This commit removes the
restore functionality.
https://bugzilla.gnome.org/show_bug.cgi?id=763948
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to the toolbar menu reorganisation work, the code to create and
manage the undo/redo items on the menu ended up in files-view.c. This
isn't the correct place as they don't have much to do with the files
view. Some refactoring was needed before the code for these items could
be moved back into the toolbar, which has now been done in a previous
commit.
This commit moves the undo/redo creation and management code into the
toolbar.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we have this menu structure:
------------------------------
1. New Folder/New Tab/Bookmark
------------------------------
2. Zoom controls
------------------------------
3. Undo/Redo
------------------------------
4. Sort options
------------------------------
5. Other view related controls
------------------------------
The view creates 2-5, contained in a single GtkWidget - which is then
passed to the toolbar via the enclosing window slot. The problem is that
3 shouldn't be created or managed by the view as the controls in that
section of the menu are not related to the view. We'd like to move this
responsibility back to the toolbar, but that would mean the view must
pass multiple menu sections back to the toolbar (as 3 is in the middle
of the other view controls).
This change allows the view to pass multiple sections back to the
toolbar, using the new NautilusToolbarMenuSections structure. The files
view now passes 2 as a separate section to 3-5 (3 will be moved out of
the view in a future commit).
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
| |
The menu previously remained open when the New Folder prompt appeared,
if New Folder was selected from the menu. This change closes the menu
when New Folder is selected.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
| |
The popover ui definition was in the toolbars definition file which was
getting pretty big. Have moved the popover definition into its own file,
to separate things out a bit.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
|
|
|
| |
The files view creates and owns these buttons currently, meaning they
aren't shown on the menu when the Other Locations view is active.
This change moves the menu items from the view's toolbar menu ui file
and into the ui file for the shared popover, so that the buttons are
also shown for Other Locations.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior changes to merge the view and action menus essentially moved the
action menu items into the view menu. This was the path of least
resistance; the view has a lot of hooks on items in the view menu,
whereas the there are very few hooks on items in the action menu,
meaning the latter could be moved more easily.
However, previously the view menu was disabled for Other Locations and
the action menu wasn't. So the side effect of the changes is the
remaining menu is now disabled completely on Other Locations. There are
a couple of items that could be shown for Other Locations (e.g. New
Tab), so we still want to show a menu, but this involves some
refactoring so has been deferred until now.
This commit is the first part of the refactoring; the files view owns
the menu popover, meaning that the Other Locations view doesn't have
access to it. This commit moves the ownership of the menu popover to the
toolbar. Future commits will move the common items into the popover so
all views will show them.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sort options shown on the toolbar menu aren't very intuitive. For
example, 'last modified, reverse order' can be interpreted a number of
ways. They also require the user to set both the sort order and whether
the sort should be reversed. These issues have been addressed by
replacing the sort order items that are often sorted in either ascending
and descending order (e.g. name) with options that are better to use
(e.g. A-Z and Z-A). Options that are generally only sorted one way
(e.g. type) have been changed to sort in ascending/descending as
appropriate for the option.
This is part of the toolbar menu redesign to improve the usability of
the menus.
https://bugzilla.gnome.org/show_bug.cgi?id=764632
|