summaryrefslogtreecommitdiff
path: root/check-FIXME.pl
Commit message (Collapse)AuthorAgeFilesLines
* Maciej helped me refine the find command so it doesn't go into po or CVSDarin Adler2000-05-171-1/+1
| | | | | | | | | | | | | | | | | | | * check-FIXME.pl: Maciej helped me refine the find command so it doesn't go into po or CVS directories and only looks at files. * components/music/nautilus-music-view.c: (nautilus_music_view_background_changed): Turned the metadata saving code back on. I think I fixed the problem that made Andy turn it off. * libnautilus-extensions/nautilus-directory-metafile.c: (set_metadata_eat_value): Fixed a double-delete problem. Oops. (nautilus_directory_set_metadata): Fixed code that wasn't emitting the metadata_changed signal enough. * libnautilus-extensions/nautilus-gdk-extensions.c: (nautilus_fill_rectangle_with_color): Fixed a crash in Gdk. It turns out gdk_rgb needs to be initialized, even though I don't think that was the intent.
* Quick cleanup pass on FIXMEs.Darin Adler2000-05-161-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | * check-FIXME.pl: Added the count of FIXMEs with bug numbers as well as the count of FIXMEs without. * components/services/trilobite/lib/helixcode-utils.c: (xml_get_value), (prune_xml), (check_for_root_user), (check_for_redhat), (determine_redhat_version), (determine_mandrake_version), (determine_turbolinux_version), (determine_suse_version), (determine_debian_version), (determine_distribution_type), (get_distribution_name): A tiny bit of cleanup on these functions. There was some really bad code in here, including code that compared strings with ==. Also a lot of code that does open and then no close, for no good reason, so I added the close. * libnautilus-extensions/nautilus-file.c: (rename_callback), (nautilus_file_get_mapped_uri): * libnautilus-extensions/nautilus-icon-container.c: (nautilus_icon_container_update_icon): * libnautilus-extensions/nautilus-icon-dnd.c: (confirm_switch_to_manual_layout), (nautilus_icon_dnd_begin_drag): * src/file-manager/fm-icon-view.c: (update_layout_menus), (sort_callback), (manual_layout_callback): * src/ntl-view.c: (nautilus_view_destroy_client): Added bug numbers to some FIXMEs.
* Added "." parameter to "find" so it works with non-GNU versions of find.Darin Adler2000-05-091-1/+1
| | | | | | | | | | | | | | | | | * check-FIXME.pl: * check-config-h.pl: Added "." parameter to "find" so it works with non-GNU versions of find. This was for Morten, who wanted to run check-config-h.pl on Gnumeric. * libnautilus-extensions/nautilus-directory-async.c: (start_getting_top_lefts): Turn embedded text back on. * libnautilus-extensions/nautilus-directory.c: (nautilus_directory_get_metadata): Fixed a bug that was showing up in "make check". (nautilus_self_check_directory): Got rid of GNOME VFS tests, since I moved the same tests into test-async-cancel in the gnome-vfs module.
* Added -print as suggested by Morten Welinder <terra@diku.dk>. Added -printDarin Adler2000-05-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * check-FIXME.pl: Added -print as suggested by Morten Welinder <terra@diku.dk>. * check-config-h.pl: Added -print and fixed broken message as suggested by Morten Welinder <terra@diku.dk>. * libnautilus-extensions/nautilus-icon-factory.h: * libnautilus-extensions/nautilus-icon-factory.c (suffix_is_scalable): Simpler implementation. (get_themed_icon_file_path): Look for size-specific version of even .svg files. Although not so useful, it's not ridiculous to do so. (nautilus_icon_factory_get_icon_for_file): Fixed the twisted logic to be less twisted. Also changed the ".svg" extension check to use the common function suffix_is_scalable. (load_specific_image): Untwist logic here too, and note in the FIXME that both the .svg library and gdk-pixbuf are limiting us to file: URIs, although the gdk-pixbuf case is fixable without redoing the library by just using our utility functions. (load_image_for_scaling): Update for new size request structure which contains maximum sizes as well as nominal ones. (scale_image_and_rectangle), (revise_scale_factors_if_too_big), (scale_image_down_if_too_big): New helper functions for scaling. (load_image_scale_if_necessary): Take the maximum size into account. (get_image_from_cache): Use new size request structure and take the maximum size into account. (nautilus_icon_factory_get_pixbuf_for_icon): Changed to take maximum size parameters and pass them in to the underlying function. (icon_cache_key_hash): Include the maximum size in the hash. (icon_cache_key_equal): Check the maximum size too. (nautilus_icon_factory_get_pixbuf_for_file): Pass new max. size parameters to the nautilus_icon_factory_get_pixbuf_for_icon function. * libnautilus-extensions/nautilus-icon-container.c (nautilus_icon_container_update_icon): Pass new max. size parameters to the nautilus_icon_factory_get_pixbuf_for_icon function. * src/file-manager/fm-list-view.c (fm_list_view_get_emblem_pixbufs_for_file): Pass new max. size parameters to the nautilus_icon_factory_get_pixbuf_for_icon function.
* Wrote a script to check for files that forget to include <config.h> andDarin Adler2000-05-021-14/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * check-config-h.pl: Wrote a script to check for files that forget to include <config.h> and optionally edit to add it. * src/nautilus-zoom-control.c (set_zoom_level): Fixed the bug number in a FIXME. * docs/style-guide.html: Added one more tip. * check-FIXME.pl: Use my newfound Perl knowledge to spruce it up. * components/help/converters/gnome-db2html2/gdb3html.c: * components/help/converters/gnome-db2html2/sect-elements.c: * components/help/converters/gnome-db2html2/sect-preparse.c: * components/help/converters/gnome-db2html2/toc-elements.c: * components/help/converters/gnome-info2html2/html.c: * components/help/converters/gnome-info2html2/main.c: * components/help/converters/gnome-info2html2/parse.c: * components/help/converters/gnome-info2html2/utils.c: * components/help/converters/gnome-man2html2/gnome-man2html.c: * components/help/hyperbola-filefmt.c: * components/help/hyperbola-nav-index.c: * components/help/hyperbola-nav-search.c: * components/help/hyperbola-nav-tree.c: * components/html/glibwww-callbacks.c: * components/html/glibwww-init.c: * components/html/glibwww-trans.c: * components/html/gnome-dialogs.c: * components/html/ntl-web-browser.c: * components/services/install/eazel-install-metadata.c: * components/services/install/eazel-install-protocols.c: * components/services/install/eazel-install-rpm-glue.c: * components/services/install/eazel-install-tests.c: * components/services/install/eazel-install-utils.c: * components/services/install/eazel-install-xml-package-list.c: * components/services/install/eazel-install.c: * components/services/install/helixcode-install-utils.c: * components/services/startup/eazel-register.c: * components/websearch/ntl-web-search.c: * helper-utilities/authenticate/nautilus-authenticate-fork.c: * helper-utilities/authenticate/nautilus-authenticate-pam.c: * helper-utilities/authenticate/nautilus-authenticate.c: * libnautilus-extensions/nautilus-bonobo-extensions.c: * libnautilus-extensions/nautilus-file-utilities.c: * libnautilus-extensions/nautilus-glib-extensions.c: * libnautilus-extensions/nautilus-link.c: * libnautilus-extensions/nautilus-mime-type.c: * libnautilus-extensions/nautilus-undo-transaction.c: * librsvg/art_rgba.c: * librsvg/art_rgba_svp.c: * librsvg/rsvg-bpath-util.c: * librsvg/rsvg-path.c: * librsvg/rsvg.c: * librsvg/test-rsvg.c: * nautilus-widgets/nautilus-caption-table.c: * nautilus-widgets/nautilus-password-dialog.c: * nautilus-widgets/nautilus-preferences-box.c: * nautilus-widgets/nautilus-preferences-dialog.c: * nautilus-widgets/nautilus-preferences-group.c: * nautilus-widgets/nautilus-preferences-item.c: * nautilus-widgets/nautilus-preferences-pane.c: * nautilus-widgets/nautilus-radio-button-group.c: * nautilus-widgets/test-nautilus-widgets.c: * nautilus-widgets/test-preferences.c: * src/file-manager/desktop-item.c: * src/file-manager/desktop-layout.c: * src/file-manager/desktop-menu.c: * src/nautilus-bookmarks-window.c: * src/nautilus-gconf.c: * src/nautilus-window-menus.c: * src/nautilus-window-toolbars.c: * src/nautilus-zoom-control.c * src/nautilus-zoomable-frame-svr.c: * src/ntl-app.c: * src/ntl-content-view.c: * src/ntl-main.c: * src/ntl-meta-view.c: * src/ntl-miniicon.c: * src/ntl-uri-map.c: * src/ntl-view-frame-svr.c: * src/ntl-view.c: * src/ntl-window-state.c: Added includes of <config.h>.
* Fixed bug that happens when there are no outstanding FIXMEs (hooray!).Darin Adler2000-04-271-2/+2
| | | | | | | * check-FIXME.pl: Fixed bug that happens when there are no outstanding FIXMEs (hooray!). Added bug numbers to FIXMEs, writing bug reports as needed.
* More FIXME-to-bug work.John Sullivan2000-04-261-0/+3
| | | | | | | | | | | | | | | * check-FIXME.pl: Added the three desktop-drawing files that aren't included in the build to the list of files in which to ignore FIXMEs. * nautilus-widgets/nautilus-caption-table.c, * nautilus-widgets/nautilus-preferences-group.c, * nautilus-widgets/nautilus-preferences.c, * src/file-manager/dfos-xfer-progress-dialog.c, * src/file-manager/dfos-xfer.c: Wrote bug reports for all FIXMEs in these files. Down to 54 in Nautilus with no bug report.
* Darin and I started out thinking we were going to start enteringJohn Sullivan2000-04-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | bugs for the FIXME items but we were distracted into fixing bugs and tweaking code that we found while doing so. * check-FIXME.pl: Won't search old ChangeLogs for FIXMEs either; changed FIXME format from "FIXME bug xxx" to "FIXME bugzilla.eazel.com xxx" * components/history/ntl-history-view.c: (hyperbola_navigation_history_notify_location_change): Moved bookmark naming hack here and added FIXME explaining it. * libnautilus-extensions/nautilus-bookmark.h, * libnautilus-extensions/nautilus-bookmark.c: (nautilus_bookmark_new), (nautilus_bookmark_new_with_name): Combined these two into one routine that takes both the uri and title; removed hack for trying to come up with good name for bookmark here. (nautilus_bookmark_get_pixmap_and_mask): Changed to call _get_pixbuf instead of duplicating code. (nautilus_bookmark_get_pixbuf): Changed interface to return pixbuf or NULL instead of boolean result & "out" parameter. * src/nautilus-bookmark-list.c, * src/nautilus-bookmarks-window.c, * src/nautilus-window-menus.c, * src/ntl-window-msgs.c: Updated callers of nautilus_bookmark_new and _new_with_name.
* This is a new Perl script for searching for FIXME in the code. It reportsDarin Adler2000-04-121-0/+102
* check-FIXME.pl: This is a new Perl script for searching for FIXME in the code. It reports any FIXME that does not have a bug number next to it, or any with a bug number that's not an open bug. * libnautilus/nautilus-bookmark.c: Attached a bug number to a FIXME for script-testing purposes. * docs/architecture.txt: Removed a FIXME. So sue me! * src/file-manager/fm-icon-text-window.c (create_attributes_option_menu): Added a call to gettext since the attribute_labels are now N_ strings. * po/.cvsignore: Ignore the generated files. * libnautilus/nautilus-icon-factory.c: Formatting tweak.