| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Make use of GLib's new g_clear_signal_handler() function to simplify nautilus'
signal handler disconnection and reduce unneccessary code.
Fixes: #1522
|
|
|
|
|
| |
As of commit 70393e321 (general: Allow to compile on Wayland-only
system) libX11 is no longer a dependency
|
|
|
|
|
| |
There are some style issue since the last run. Let's run it again
before enabling style-check CI job.
|
|
|
|
|
|
| |
Uncrustify changes "(*pixsrc++ * *pixdest)" to "(*pixsrc++ **pixdest)"
which is unwanted. Let's add redundant parentheses around "*pixdest" to
prevent these unwanted changes.
|
|
|
|
|
|
| |
Comparison is always false because positions >= 1
Makes comparison redundant
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Empty trash widget is displaying for empty folder inside trash
instead of Empty folder widget.
`eel_uri_is_trash` only checks whether the URI starts with "trash:",
that's why it also returns true for empty folders inside trash.
Create `eel_uri_is_trash_root` to distinguish trash root (trash:///)
from empty folder inside trash (trash:///emptyfolder)
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/1367
|
|
|
|
| |
Remove unneeded includes and add some guards to X11-only code.
|
|
|
|
|
|
| |
This commit adds comments describing the functionality,
the parameters and the return values of the functions that were not
documented.
|
|
|
|
|
|
| |
With the new icons most of the area was white.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/issues/827
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
glib now offers a reference counted api.
This allows us to replace a lot of legacy code and get rid of
eel_ref_str. GRefString [1] is almost a drop-in replacement.
nautilus-file-operations.c was indirectly depending upon
eel/eel-string.h from nautilus-file-private.h and thus
a new include was added.
This bumps the minimum version of glib to 2.58
Close #781
https://gitlab.gnome.org/GNOME/nautilus/issues/781
[1] https://developer.gnome.org/glib/stable/glib-Reference-counted-strings.html
|
|
|
|
|
|
|
|
|
| |
The eel_str_double_underscores and eel_str_capitalize
functions didn't have documentation.
Added importance of eel_str_double_underscores as well.
It's good practice to have documentation for functions
in the long term.
|
|
|
|
|
|
|
| |
Even though more convoluted than the previous solution, this one
should last longer. Canvas item icons are now colorized by first drawing
the background to a Cairo surface and then multiplying the color values
of the original icon pixbuf and the ones from the newly created one.
|
|
|
|
|
| |
gdk/gdkprivate.h is no longer a thing in GTK+ 4 and doesn’t seem to be
at all required.
|
|
|
|
|
|
| |
In theory, it would be possible to just drop the GAIL code and keep the
header, but, given that NautilusCanvasItem is the only remaining
consumer, the needed bits can be moved over.
|
|
|
|
|
| |
atk_gobject_accessible_get_object() does the same thing and doesn’t
require redefining quarks or using magic strings.
|
|
|
|
| |
They’re only used once, so why not.
|
|
|
|
|
|
|
|
|
|
| |
f42979f0b073d96a9157c05c0bff963820a630b4 changed the ellipsis to a
unicode one, which is one character in length, in turn changing the
expected output.
For cases where the truncation length is zero, the expected output is
changed to NULL, as 536505728e3963cfc6d2fa93ca2b188bfb5a144b added an
assertion.
|
|
|
|
|
| |
A couple of arguments were misaligned, so we placed
them properly.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The traditional include guards are not as easy to handle
and require extra thought into the names.
Pragma once is an easier, more contributor friendly approach.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/294
general: Remove include guards in favor of pragma once
The traditional include guards are not as easy to handle
and require extra thought into the names.
Pragma once is an easier, more contributor friendly approach.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/294
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When hacking on Nautilus, it is very inconvenient to have to close any
running instance before running the built version. This commit enables
running three different instances by changing the application ID.
Beside the default “profile” is one crafted for stable flatpak
releases and one for development. The stable flatpak profile adds an
identifying mark to the about dialog to aid collecting information in
bug reports. The development profile is that plus additional styling to
help visually identify the development instance. It also will be used
when generating Flatpak bundles with the help of CI.
Generally, the implementation is slightly hacky to allow all the
different workflows, spanning from regular installations to GNOME
Builder flatpak builds, as each comes with its own quirks.
|
|
|
|
| |
This can help cut down on link times a bit when working on things.
|
|
|
|
|
| |
These aren’t used anywhere and cause Clang to spit out errors about
format strings not being literals.
|
| |
|
|
|
|
|
|
|
| |
Shadowing variables is error-prone, since one might mean to refer to a
variable that was declared earlier, but has the same name. Additionally,
being more strict about variable scoping can help make the code more
readable.
|
|
|
|
|
|
|
| |
This commit tries to make the function more readable and fixes the allocation of
the new string: the truncated string is of the same size as the source string.
This can be fixed by adding a couple of different allocations. :)
Some comments were trimmed down or removed.
|
| |
|
|
|
|
|
|
|
|
| |
It was a mix of both terms, given that tracker uses 'favorite' but we
use 'starred' in the UI. Since the part that interact with tracker is
minimal, is better to be consistent with the UI.
This renames 'favorite' to 'starred' except the tracker queries.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the star menu item is shown for every file in the system,
however when a file is not indexed by tracker this operation fails.
We cannot set Tracker to index the file and wait for Tracker to index
it, since that happens in an idle and Tracker doesn't queue the
operation of starring.
There is no easy solution for this, so for now we will show the star
menu item for indexed (by default) locations, which are the XDG folders,
otherwise we will hide the item.
A better solution needs to be researched for 3.30, but this will do for
now.
Related https://gitlab.gnome.org/GNOME/nautilus/issues/243
|
|
|
|
|
|
|
| |
eel_string_ellispize_*() functions and eel-gdk-extension.h
are no more. This comment was totally outdated.
Replace it with actual API docs.
|
|
|
|
| |
Instead of 3 periods ("...")
|
|
|
|
|
| |
f0df1fc510bcc1007256612380a85d2373b66552 removed the prototype of a
function that is still being used.
|
|
|
|
|
|
|
| |
Currently, Nautilus is able to save the last window position when it’s
closed. That is broken in certain cases (#197 and multi-monitor setups
in general) and therefore window placement is best left to the window
manager.
|
|
|
|
|
| |
Although eel can be split into displayless and display like we did for
other tests, let's make sure we have a working prototype for now.
|
|
|
|
|
| |
Leftovers from the gnome-vfs to gio port 10 years ago
https://git.gnome.org/browse/archive/eel/commit/?id=59511dfee330102ee42e09bef37cbc9cd12973c6
|
|
|
|
| |
Additionally, this commit makes some unused public functions static.
|
|
|
|
|
| |
Terminal applications are launched via eel, and, since this file is the
only consumer of that API, the code from eel can be moved over.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit does the following:
* Canonicalize the style:
* Use two-space indentations.
* Un-Autotools-ify option names.
* Don’t align arguments, simply increase indentation.
* Don’t add a space before opening parenthesis in calls.
* Remove unused variables.
* Remove unused dependencies.
* Remove config.h.meson.
* Optimize dependencies.
* Use disabler functionality for libselinux dependency, to save lines.
|
| |
|
|\
| |
| |
| |
| | |
Remove error details expander
See merge request GNOME/nautilus!41
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As the eel_gtk_message_dialog_set_details_label function is only used once,
we can safely remove it and do everything inside of nautilus-file-operations.c.
Thus, we deleted the eel function and we do everything inside the
do_run_simple_dialog function and remove the function header from the header
file. We add the label straight into the content_area of the dialog box.
https://bugzilla.gnome.org/show_bug.cgi?id=598671
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Creating directories within read-only ones is not allowed and appropriate
error messages pop up.
Trying to create a directory within a read-only directory opens a window
showing the error. Within the window, an expander shows the error details.
Whenever the expander is clicked, the window moves unexpectedly.
We need to fix this as the behaviour is not normal and doesn't look good.
In order to fix the issue, we removed the expander and included the error
details as a label inside the dialog box itself.
https://bugzilla.gnome.org/show_bug.cgi?id=786212
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the process for getting the common prefix of a list of file
names is a tad too greedy:
1. Find the common prefix of all the strings.
2. Strip the extension from the prefix.
3. Strip trailing punctuation.
Step 2 may strip dots if there’s trailing whitespace and step 3 may
strip useful punctuation (e.g. parentheses). This commit reworks the
process as such:
1. Strip the extension from all the file names.
2. Find the common prefix of all the strings.
3. Trim trailing whitespace.
Fixes #174.
|
|
|
|
|
|
|
| |
Add option to make files Favorite, by either toggling a star in the
list view, or from the context menu.
https://bugzilla.gnome.org/show_bug.cgi?id=786039
|
|
|
|
|
|
|
|
|
|
|
| |
This patch avoids the use of gdk_screen_get_width,
gdk_screen_get_height,gdk_screen_width,gdk_screen_height, functions
which are deprecated since 3.22 version of GDK library.
Also deletes the eel_pop_up_context_menu function since is not used
in the source code.
https://bugzilla.gnome.org/show_bug.cgi?id=780283
|
|
|
|
|
|
| |
We’re moving to Meson this cycle, so this is losing some deadweight.
https://bugzilla.gnome.org/show_bug.cgi?id=780366
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since it’s 2017 already, Nautilus should use a build system that doesn’t
take longer to set up the build than it takes to actually build. An
observed build time using Ninja of roughly one-fifth of what it took
Autotools is more than reason enough to add support for Meson. Along
with that, this commit adds a convenience script to generate a tarball
for releases, since we use libgd as a submodule and Meson does not
handle source distributions.
https://bugzilla.gnome.org/show_bug.cgi?id=778167
|
|
|
|
|
|
|
|
| |
This commit removes git.mk and adds hand-written gitignore files. That
is needed to ignore build/, which is the directory of choice for Meson
builds.
https://bugzilla.gnome.org/show_bug.cgi?id=778167
|
|
|
|
|
|
|
|
|
|
| |
'Other locations' is already listed in the sidebar. So there is no
need for allowing the user to bookmark 'Other Locations'.
This commit makes the bookmark button in toolbar insensitive for
'Other Locations'.
https://bugzilla.gnome.org/show_bug.cgi?id=771163
|
|
|
|
|
|
|
|
|
|
| |
If a file had the extensions .tar.bz or .tar.xz, the function
eel_filename_get_extension_offset would identify only .bz or .xz as
an extension.
To fix this, .xz and .bz were added among the other special cases.
https://bugzilla.gnome.org/show_bug.cgi?id=771018
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=770564
|