| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Add a private property that is meant to help that column chooser
know if the nautilus-column should be visible or not.
|
|
|
|
|
|
|
| |
Currently, the `Nautilus: "@name" parameter unexpected at this location`
warning is shown during build. This is caused by the extra newline character
in the documentation comment for the `nautilus_column_new` function. Let's
remove this extra newline character to get rid of that warning.
|
| |
|
|
|
|
|
|
| |
Don't allow empty or null names. While the previous commit probably
prevents the symptoms, adding empty or null names is useless and
potentially problematic.
|
| |
|
|
|
|
|
|
|
|
| |
../libnautilus-extension/nautilus-properties-model-provider.h:61: Warning: Nautilus: nautilus_properties_model_provider_get_models: Unknown type: 'NautilusPropertyModel'
../libnautilus-extension/nautilus-properties-item.h:37: Warning: Nautilus: nautilus_properties_item_new: unknown parameter 'model' in documentation comment, should be 'value'
../libnautilus-extension/nautilus-properties-item.h:46: Warning: Nautilus: nautilus_properties_item_get_name: unknown parameter 'item' in documentation comment, should be 'self'
../libnautilus-extension/nautilus-properties-item.h:54: Warning: Nautilus: nautilus_properties_item_get_value: unknown parameter 'item' in documentation comment, should be 'self'
../libnautilus-extension/nautilus-properties-model-provider.h:45: Warning: Nautilus: NautilusPropertyModel: Unknown type: 'NautilusPropertyModel'
|
| |
|
|
|
|
| |
Closes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2417
|
|
|
|
|
|
| |
Was spamming warnings on list view.
Left over from c60d3099edca0558601c50c32f7307a26dda2532
|
|
|
|
|
|
| |
Also drop GTK dependency, now that GTK is no longer used in our API.
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2135
|
|
|
|
| |
We use GtkSortOrder internally only, it's not meant for extensions.
|
|
|
|
|
|
|
|
| |
We don't want extensions to inject random inconsistent widgets
into our window.
If there are good reasons for this, in the future we can introduce a
new model-like API instead of a widget-based one.
|
|
|
|
|
|
| |
We don't want menu items to create their own windows in our process.
This helps with the effort to de-GTK-ize libnautilus-extensions API.
|
|
|
|
|
|
|
| |
We want to control the layout of the window, not having extensions
injecting their own widgets.
This also avoids future breakage when porting to newer versions of GTK.
|
|
|
|
|
|
| |
This is meant to replace the existing GtkWidget-based solution.
Part of https://gitlab.gnome.org/GNOME/nautilus/-/issues/2365
|
|
|
|
| |
Most of these are pretty sparse but could be expanded on as needed.
|
|
|
|
|
|
|
|
|
|
|
| |
Replace the tabbed GtkNotebook view with inlined navigation rows that
link to subpages and a back button that allows navigating back.
Add additional needed getters to NautilusPropertyPage.
Also, replace the now-inadequate .view style class with .background.
Part of #1326
|
|
|
|
|
|
| |
Meson builds out-of-tree, these ignored files will never get created in
these directories. If they do, it indicates a build configuration error
and should not be hidden.
|
|
|
|
|
|
| |
They were introduced to ensure compatibility in 0e5815e95ae2f071be73b75b57925aceb23f503a
Now that we have broken the API, it's time to drop them.
|
|
|
|
|
|
|
| |
Now that we have broken the API, remove compatibility typedefs
introduced in 7e2605c681d065e6b0a3d779c30b892932597991
Also update audio-video-properies to use the new symbols.
|
|
|
|
| |
Deprecated since commit 7e2605c681d065e6b0a3d779c30b892932597991
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The GTK3 to GTK4 switch requires extensions to port their widgets too,
because 2 versions of GTK cannot be loaded in the same program.
Therefore, this is effectively an API break. We must update the
library version.
Also, we are going to introduce breaking more changes before the API
freeze.
Closes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2135
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new major version of the toolkit is a requirement to fix old issues and enable future enhancements.
Update symbols and adapt logic to API changes.
Update and simplify UI definitions.
Update local copy of places sidebar and places view.
Replace dependencies with their GTK4-compatible successors.
Make a minimum changes required to build and run, with known
regressions to be fixed in future commits.
For a detailed breakup of the changes, see the 36 commits-deep
log leading to d5763facb1e5045251171ed1273dca0859f3542f.
This is the main part of https://gitlab.gnome.org/GNOME/nautilus/-/issues/276
|
|
|
|
|
| |
Tooltips are currently unused, so it makes sense to allow NULL here, as
with the @icon parameter.
|
|
|
|
|
| |
I've generally verified that these are nullable by looking elsewhere in
the source.
|
|
|
|
|
|
|
|
|
| |
I believe these are only included to prevent breakage of existing C
extensions, but as they're not intended for actual use we should mark
them with `(skip)`.
This has the added benefit of making the VAPI file generated from the
resulting GIR file much less noisy.
|
|
|
|
|
|
|
| |
As pointed out by Emmanuele Bassi, these are not part of the ABI and
should be marked with (skip).
See: https://discourse.gnome.org/t/vala-bindings-for-an-unusual-c-ownership-function-signature/8184
|
|
|
|
|
|
|
| |
As pointed out by Emmanuele Bassi, this should be transfer=none instead
of the present transfer=full.
See: https://discourse.gnome.org/t/vala-bindings-for-an-unusual-c-ownership-function-signature/8184
|
|
|
|
|
| |
There are some style issue since the last run. Let's run it again
before enabling style-check CI job.
|
|
|
|
|
|
|
| |
ITEMS_UPDATED is not the signal id. It's the index for the array of
signal ids.
Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/984
|
|
|
| |
A bit more readable with a semicolon.
|
|
|
|
|
|
| |
This effectively adds `<package name="libnautilus-extension"/>` to gir
xml file, which makes it easy to obtain necessary compiler and linker
flags for use in compile time bindings.
|
|
|
|
| |
The same function was accidentally documented twice.
|
|
|
|
|
|
|
|
|
| |
This commit completes the sections file with subsections, moves most
documentation to headers (no real reason to, especially given that
changes there may cause unwanted rebuilds, but it feels better to have
it in the headers) and fixes some annotations.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/565
|
| |
|
|
|
|
|
| |
A couple of arguments were misaligned, so we placed
them properly.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The traditional include guards are not as easy to handle
and require extra thought into the names.
Pragma once is an easier, more contributor friendly approach.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/294
general: Remove include guards in favor of pragma once
The traditional include guards are not as easy to handle
and require extra thought into the names.
Pragma once is an easier, more contributor friendly approach.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/294
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When hacking on Nautilus, it is very inconvenient to have to close any
running instance before running the built version. This commit enables
running three different instances by changing the application ID.
Beside the default “profile” is one crafted for stable flatpak
releases and one for development. The stable flatpak profile adds an
identifying mark to the about dialog to aid collecting information in
bug reports. The development profile is that plus additional styling to
help visually identify the development instance. It also will be used
when generating Flatpak bundles with the help of CI.
Generally, the implementation is slightly hacky to allow all the
different workflows, spanning from regular installations to GNOME
Builder flatpak builds, as each comes with its own quirks.
|
| |
|
|
|
|
|
|
| |
Some extensions break because of weird inclusion patterns.
Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/252
|
|
|
|
|
|
|
| |
The libnautilus-extensions internal dependency must include the
generated enumeration header file, otherwise we may end up building
targets that depend on the library prior to have the header properly
generated.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The changes include:
* adding a single-include header and deprecating
nautilus-extension-types.h and direct inclusions of individual
headers;
* type definition simplifications - this causes some breakages in
nautilus-file, because NautilusFile used to be typedefed to
NautilusFileInfo, and that is no longer possible, so the interface
implementation was moved to static functions and the public
NautilusFile API provides thin wrappers for them to maintain
compatibility;
* documentation cleanups and reorganization;
* general build rule and code cleanups: mostly g_auto* sprinkled
around and style changes (sorry)
|
|
|
|
|
|
|
| |
Currently, the pkgconfig file for nautilus-extension is generated by
substituting variables in a template file. That is prone to mistakes and
requires manual tracking of dependencies. Using the pkgconfig module
from Meson helps automate much of the process.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit does the following:
* Canonicalize the style:
* Use two-space indentations.
* Un-Autotools-ify option names.
* Don’t align arguments, simply increase indentation.
* Don’t add a space before opening parenthesis in calls.
* Remove unused variables.
* Remove unused dependencies.
* Remove config.h.meson.
* Optimize dependencies.
* Use disabler functionality for libselinux dependency, to save lines.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=785062
|
|
|
|
|
|
| |
We’re moving to Meson this cycle, so this is losing some deadweight.
https://bugzilla.gnome.org/show_bug.cgi?id=780366
|
|
|
|
|
|
|
|
|
|
| |
Currently, when building with Meson, the version of the pkg-config file
for libnautilus-extension is set to the version of the library itself.
This is incompatible with how it was before - the version was set to the
version of Nautilus. That breaks some modules that build extensions
(e.g. file-roller).
https://bugzilla.gnome.org/show_bug.cgi?id=779472
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since it’s 2017 already, Nautilus should use a build system that doesn’t
take longer to set up the build than it takes to actually build. An
observed build time using Ninja of roughly one-fifth of what it took
Autotools is more than reason enough to add support for Meson. Along
with that, this commit adds a convenience script to generate a tarball
for releases, since we use libgd as a submodule and Meson does not
handle source distributions.
https://bugzilla.gnome.org/show_bug.cgi?id=778167
|
|
|
|
|
|
|
|
| |
This commit removes git.mk and adds hand-written gitignore files. That
is needed to ignore build/, which is the directory of choice for Meson
builds.
https://bugzilla.gnome.org/show_bug.cgi?id=778167
|
|
|
|
|
| |
Some issues were fixed, and now we can rerun Uncrustify to format
correctly more part of the code.
|