| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
There are some style issue since the last run. Let's run it again
before enabling style-check CI job.
|
|
|
|
|
|
|
|
| |
Using DO_NOT_AUTO_START_ON_CONSTRUCTION gets the desired behavior
of not auto-starting the previewer at proxy construction, but allow
auto-starting at the first ShowFile call.
Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/1229
|
|
|
|
| |
From the NautilusPreviewer2 interface.
|
|
|
|
|
| |
Instead of using the connection directly. This allows us to easily
inspect a property in a future commit.
|
|
|
|
|
|
|
| |
And handle it by moving the selection in the current view.
Once in a following commit we have the previewer follow the view
selection, we'll achieve the desired effect of moving the preview
with the selection.
|
|
|
|
|
|
|
|
| |
Use the NautilusPreviewer2 interface, so the preview window can
get correctly parented under Wayland.
Fixes https://gitlab.gnome.org/GNOME/sushi/issues/1
Closes https://gitlab.gnome.org/GNOME/nautilus/merge_requests/469
|
|
|
|
|
|
|
|
| |
And make the style of Nautilus the same for all files.
Hopefully we can fix all the style issues we can find in the next days,
so expect a little of movement on this.
https://bugzilla.gnome.org/show_bug.cgi?id=770564
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And fix make distcheck.
Although libnautilus-private seem self contained, it was actually
depending on the files on src/ for dnd.
Not only that, but files in libnautilus-private also were depending on
dnd files, which you can guess it's wrong.
Before the desktop split, this was working because the files were
distributed, but now was a problem since we reestructured the code, and
now nautilus being a library make distcheck stop working.
First solution was try to fix this inter dependency of files, but at
some point I realized that there was no real point on splitting some of
those files, because for example, is perfectly fine for dnd to need to
access the window functions, and it's perfectly fine for the widgets
in the private library to need to access to all dnd functions.
So seems to me the private library of nautilus is somehow an artificial
split, which provides more problems than solutions.
We needed libnautilus-private to have a private library that we could
isolate from extensions, but I don't think it worth given the problems
it provides, and also, this not so good logical split.
Right now, since with the desktop split we created a libnautilus to be
used by the desktop part of nautilus, extensions have access to all
the API of nautilus. We will think in future how this can be handled if
we want.
So for now, merge the libnautilus-private into src, and let's rethink
a better logic to split the code and the private parts of nautilus than
what we had.
Thanks a lot to Rafael Fonseca for helping in get this done.
https://bugzilla.gnome.org/show_bug.cgi?id=765543
|
|
|
|
|
| |
Just use the GDBusConnection that the application gives us, instead of
requiring a separate one.
|
|
|
|
|
|
| |
Use the website instead.
https://bugzilla.gnome.org/show_bug.cgi?id=721518
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Initialize the DBus connection in the constructor and call methods
directly on it, instead of keeping the proxy around.
|
| |
|
| |
|
|
|
|
|
| |
It's easier to use this way, and we don't have to create a new DBus
proxy every time.
|
|
|
|
| |
As per the changes in sushi
|
| |
|
| |
|
|
|