summaryrefslogtreecommitdiff
path: root/src/nautilus-properties-window.c
Commit message (Collapse)AuthorAgeFilesLines
* properties-window: use gdk_pixbuf_scale_simple ()Ernestas Kulik2017-02-231-4/+4
| | | | | | | | gnome_desktop_thumbnail_scale_down_pixbuf () has been deprecated in favor of gdk_pixbuf_scale_simple (). This commit replaces the call to the deprecated function. https://bugzilla.gnome.org/show_bug.cgi?id=779084
* Fix translator commentsPiotr Drąg2017-01-281-3/+3
| | | | They need to be exactly one line above a string to show up in .po files.
* general: format code with newer UncrustifyCarlos Soriano2016-11-301-26/+26
| | | | | Some issues were fixed, and now we can rerun Uncrustify to format correctly more part of the code.
* properties-window: fix checking inconsistent stateAlexandru Pandelea2016-11-271-1/+1
| | | | | | | | | | In the function initial_permission_state_consistent, when the check was made to see if the files have the same permissions, the check was not correct. To fix this, also do & between the first_permissions and the mask. https://bugzilla.gnome.org/show_bug.cgi?id=698955
* properties-window: use NautilusFile utility functions where availableErnestas Kulik2016-10-241-40/+14
| | | | | | Some functions used are implemented in NautilusFile and can be removed. https://bugzilla.gnome.org/show_bug.cgi?id=773211
* properties-window: use g_file_get_relative_path()Ernestas Kulik2016-10-241-43/+11
| | | | | | | Currently, a custom function is used to achieve the same effect as one can with g_file_get_relative_path(). https://bugzilla.gnome.org/show_bug.cgi?id=773211
* properties-window: do not expand prompt separatorErnestas Kulik2016-10-241-1/+1
| | | | | | | | Currently, when packing the separator for the prompt, it is expanded. That means that it can grow vertically as the window grows, creating a visually unappealing effect. https://bugzilla.gnome.org/show_bug.cgi?id=773211
* properties-window: merge create_page_with_{h,v}box()Ernestas Kulik2016-10-241-40/+24
| | | | | | | The two functions are now nearly identical with the deprecation of Gtk{H,V}Box. https://bugzilla.gnome.org/show_bug.cgi?id=773211
* general: adjust uncrustify styleCarlos Soriano2016-09-061-3/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=770564
* Remove NautilusEntryErnestas Kulik2016-08-301-26/+54
| | | | | | | | NautilusEntry was written to work around some issues with GtkEntry, which are largely irrelevant, since its use has lessened over the years. This commit removes the class. https://bugzilla.gnome.org/show_bug.cgi?id=770578
* general: initialize smart pointers to NULLRazvan Chitu2016-08-301-2/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=770609
* general: run uncrustifyCarlos Soriano2016-08-291-4110/+4661
| | | | | | | | And make the style of Nautilus the same for all files. Hopefully we can fix all the style issues we can find in the next days, so expect a little of movement on this. https://bugzilla.gnome.org/show_bug.cgi?id=770564
* properties-window: make icon chooser dialog modalErnestas Kulik2016-05-111-0/+1
| | | | | | | | | | | | The custom icon selection GtkFileChooserDialog is unresponsive when opened. This is caused by the properties dialog window being modal, since it is up to the window manager how to process input in such situations. One of the ways to ensure that the child dialog receives and processes user input is by making it modal. This commit makes it such. https://bugzilla.gnome.org/show_bug.cgi?id=753394
* general: merge libnautilus-private to srcwip/csoriano/private-to-srcCarlos Soriano2016-04-251-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | And fix make distcheck. Although libnautilus-private seem self contained, it was actually depending on the files on src/ for dnd. Not only that, but files in libnautilus-private also were depending on dnd files, which you can guess it's wrong. Before the desktop split, this was working because the files were distributed, but now was a problem since we reestructured the code, and now nautilus being a library make distcheck stop working. First solution was try to fix this inter dependency of files, but at some point I realized that there was no real point on splitting some of those files, because for example, is perfectly fine for dnd to need to access the window functions, and it's perfectly fine for the widgets in the private library to need to access to all dnd functions. So seems to me the private library of nautilus is somehow an artificial split, which provides more problems than solutions. We needed libnautilus-private to have a private library that we could isolate from extensions, but I don't think it worth given the problems it provides, and also, this not so good logical split. Right now, since with the desktop split we created a libnautilus to be used by the desktop part of nautilus, extensions have access to all the API of nautilus. We will think in future how this can be handled if we want. So for now, merge the libnautilus-private into src, and let's rethink a better logic to split the code and the private parts of nautilus than what we had. Thanks a lot to Rafael Fonseca for helping in get this done. https://bugzilla.gnome.org/show_bug.cgi?id=765543
* properties-window: use widget properties instead of GtkAlignmentErnestas Kulik2016-04-141-15/+4
| | | | | | | | | | GtkAlignment has been deprecated since GTK+ 3.14 and the use of halign, valign and margin properties is encouraged. This commit aligns widgets by use of said properties instead of the GtkAlignment widget. https://bugzilla.gnome.org/show_bug.cgi?id=762238
* properties-window: use app info for "Open With" visibilityCarlos Soriano2016-04-141-3/+5
| | | | | | | | | | | | | We were special casing desktop icon files to not show the Open With tab in the properties window. However, this is just equal to what we need to do to display Open With in the context menus, where we check if the app has a possible application handling it or not. Do the same here so we can remove another desktop dependency. https://bugzilla.gnome.org/show_bug.cgi?id=712620
* properties-window: use get_target_uri instead of custom codeCarlos Soriano2016-04-141-33/+7
| | | | | | | | Now that we have the code to request the target uri in nautilus file, we can use that instead of our own code special casing subclasses of nautilus file. https://bugzilla.gnome.org/show_bug.cgi?id=712620
* general: remove vim modelinesCarlos Soriano2016-04-041-1/+0
| | | | | | | | | | | | | Vim and emacs modelines are used to specify some of the code style in the code. However, this is misleading and poorly supported since nautilus had a mix of code style for some time. Also, the mode lines doesn't specify the whole code style, so we will need to use a different tool as well to specify the whole code style. For that, we can just use a different tool for everything. So remove the mode lines, and in a short future we will reestyle the nautilus code to have a single code style, and use a tool like editorconfig to specify the whole code style.
* properties-window: make it modalCarlos Soriano2016-03-011-2/+2
| | | | | We prefer the dialogs to be modal so they are centered and attached to the parent.
* Make file properties dialog transient for its parent windowMichael Catanzaro2016-03-011-4/+15
| | | | | | | So they don't appear as separate application windows in the GNOME Shell overview, and to avoid warnings from GTK+. https://bugzilla.gnome.org/show_bug.cgi?id=753996
* properties-window: fix textCarlos Soriano2015-09-011-1/+1
| | | | | | We wanted to say drop instead of drag. https://bugzilla.gnome.org/show_bug.cgi?id=622384
* properties-window: specify string contextCarlos Soriano2015-09-011-1/+8
| | | | | | For better translations. https://bugzilla.gnome.org/show_bug.cgi?id=746565
* project: replace deprecated GtkMisc callsGeorges Basile Stavracas Neto2015-07-211-6/+4
| | | | | | | | | | | GtkMisc is deprecated since 3.14 release, being replaced by GtkWidget's halign & valign, and GtkLabel's xalign & yalign. Nautilus, however, did not updated its codebase to match the new deprecations. Remove any reminescent gtk_misc* calls from the codebase.
* project: replace deprecated gdk_cursor_newGeorges Basile Stavracas Neto2015-07-211-2/+4
| | | | | | | | | | | | In 3.16 release gdk_cursor_new was deprecated in favor of gdk_cursor_new_for_display. Nautilus, however, did not updated to use the proposed function, and is still using the deprecated method. Fix that by using the proposed gdk_cursor_new_for_display method.
* Revert "nautilus-properties-window: make owner value insensitive"Carlos Soriano2015-02-041-1/+0
| | | | | | | | | This reverts commit 91bb18fe23dd12f31bb63d702c6b5cb31670649f. It needs to be sensitive so it's focusable and selectable for users and for A11y. gtk+ selects automatically the label on focusing the tab, so for fixing it we will need to do some tricks that would probably better be fixed/discussed inside gtk+.
* nautilus-properties-window: make owner value insensitiveCarlos Soriano2015-02-041-0/+1
| | | | Currently it gets selected, but it should be insensitive.
* nautilus-icon-info: rework zoom levelsCarlos Soriano2015-01-241-4/+4
| | | | | | | | | | Following a design request and preparing to the port to popovers of nautilus, we want to use only 3 zoom levels for each kind of view, so the slider makes sense. Also, following design guidelines, the new zoom levels sizes for icon view are 64, 96, 128, with default to 96 and 16, 32, 48 for list view, 32 being the default
* Rename Location to Parent Folder - bug #47678Robert Roth2015-01-201-1/+1
|
* nautilus-properties-window: Expand tabsCarlos Soriano2014-12-191-0/+16
| | | | It's more visually balanced
* properties-window: rewrite pie chart drawing to use GtkStyleContextCosimo Cecchi2014-11-291-330/+60
| | | | Instead of hardcoded values. This makes it more theme friendly too.
* properties-window: set max-width for value labelsLars Uebernickel2014-10-061-0/+1
| | | | | | | Not setting it can lead to very wide windows, because gtk doesn't enforce a maximum window size anymore. https://bugzilla.gnome.org/show_bug.cgi?id=732117
* NautilusPropertyDialog: Fix user list for owner changeAlexander Larsson2014-08-211-25/+17
| | | | | | | | | | | | | This code was constantly failing to find the current files user as the form of the "owner" attribute didn't match the internal list. Also, as a consequence of this the user list didn't match the old one so we keep re-creating it all the time. We fix this by being much more explicit in what we store in the model columns: 0 - the display name 1 - the return value from nautilus_get_user_names() 2 - the actual username (not real name)
* NautilusPropertyDialog: Fix problems with fast group/owner changesAlexander Larsson2014-08-211-167/+145
| | | | | | | | | | | | | | If the owner or group of a file was changed twice very quicky then the second change would cancel the first. However, the code assumed that after the nautilus_file_cancel() call the result of the first change would not be called. That is not true anymore, and when it did get called it tried to stop the timed wait, which gave a warning, and in general touched stuff that the new operation should only touch. We fix this by making A group/owner change its own struct which we delay freeing until the operation has actually finished, although we track if it has been cancelled so we can avoid multiple calls to eel_timed_wait_stop().
* properties-window: don't start deep counts for non-directoriesCosimo Cecchi2014-02-171-3/+5
| | | | | | Fixes a critical warning when updating the window. https://bugzilla.gnome.org/show_bug.cgi?id=698895
* properties: fix crash when entering an unsupported URINelson Benítez León2014-02-171-1/+5
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=711480
* Use header bars for dialogsWilliam Jon McCann2014-02-071-32/+6
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=723793
* Updated FSF's addressDaniel Mustieles2014-01-311-2/+1
|
* properties-window: Only perform deep count for directoriesRoss Lagerwall2013-12-081-1/+3
| | | | | | | Prevent the spinner running endlessly when files are selected by only starting the deep count for directories. https://bugzilla.gnome.org/show_bug.cgi?id=703349
* src: don't use deprecated GtkImageMenuItem and GtkStockCosimo Cecchi2013-08-131-8/+8
| | | | | There's another occurrence of GtkImageMenuItem right now, for the "Open With..." menu which is harder to fix.
* properties-window: support HiDpi for the properties window iconCosimo Cecchi2013-08-041-17/+10
| | | | This was missing from the last commit.
* Support HiDpi iconsCosimo Cecchi2013-08-031-3/+12
| | | | | Port the rendering of icons to cairo surfaces, so that we can apply the GDK scale factor when rendering icons.
* Normalize signal namesWilliam Jon McCann2013-01-221-3/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=692234
* properties-window: make sure to clear group/owner changes on destroyCosimo Cecchi2013-01-171-0/+3
| | | | | | In case a pending change group/owner operation is happening while the window is destroyed, we were failing to properly clean up the operation, possibly leading to a leak or an invalid state.
* properties-window: fix use-after-free on destroyPavel Vasin2013-01-171-4/+2
| | | | | | stop_deep_count_for_file() removes from deep_count_files list https://bugzilla.gnome.org/show_bug.cgi?id=691004
* general: Use proper Unicode ellipsis instead of three periodsJeremy Bicha2012-12-031-2/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=689586
* Use helper function to determine if file is rootWilliam Jon McCann2012-09-251-4/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=684354
* Don't show volume info for things without a volumeWilliam Jon McCann2012-09-251-7/+45
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=684354
* Show capacity chart for local diskWilliam Jon McCann2012-09-251-3/+9
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=684354
* Paint the used space on top of the othersWilliam Jon McCann2012-09-171-11/+13
| | | | | | Looks better to have those strokes be on top. https://bugzilla.gnome.org/show_bug.cgi?id=559311
* Use jimmac approved colorsWilliam Jon McCann2012-09-171-9/+9
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=559311