| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
We are going to become a custom tagged search entry, so we should
subclass directly from GtkWidget and use a box layout instead.
|
|
|
|
|
|
|
|
|
| |
It's going away in GTK4. Also, as we use a key event controller now,
we can use gtk_event_controller_key_forward() instead.
This is how GTK4 implements gtk_search_entry_set_key_capture_widget(),
so reimplement it here. We were not going to inherit anyway, because we
need a custom widget for a tagged entry in GTK4.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 543f5ae369213f90238466e6366a0d2e09260e05.
When this feature was originally proposed, the use cases when <Ctrl><F>
is required because "just typing" doesn't do the trick were not
considered. Two such cases are searching for a ~ (tilde) and pasting
text to search with <Ctrl><V>. Both are now impractical because the
filter popover steals the focus.
Furthermore, we have a few inconsistent state bugs related to this.
Instead of shipping version 3.30 with these regressions and bugs, let's
withdraw this change.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/597
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/570
And closes https://gitlab.gnome.org/GNOME/nautilus/issues/571
|
|
|
|
| |
It’s not derived anywhere, and thus it shouldn’t be derivable.
|
|
|
|
|
| |
NautilusQueryEditor is only mentioned in passing, this will do just as
fine.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently using the [Ctrl]+[F] keyboard shortcut toggles the search bar
visibility.
Using the [Ctrl]+[F] keyboard shortcut shows the search filter popover
(and gives it keyboard focus).
To add this a new action "search-visible-popover" is added which in addition
to the "search-visible" action adds the feature to focus and show the search
dropdown menu.
https://gitlab.gnome.org/GNOME/nautilus/issues/333
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generally actions in Nautilus were accessed through context menus or
keyboard shorcuts. However, those are not very discoverable and are
not touch friendly.
Even more, in list view it was not possible to access background actions
since there is always a selection, making Nautilus UX quite poor in that
case.
Also some actions were placed in the app menu, which didn't was not as
clear for some people given that we have most of actions in the toolbar.
In all, we came with a new design that solves the main goals of
discoverability, touch friendly and accessibility for background actions
and app actions, and now are placed in the toolbar together with an
overhaul of the looks of Nautilus path bar and search.
There is still work to do, specifically finding a design that works for
the selection actions and also to replace the current information
floating bar. The later might be just a different goal. However this
goes in the right direction.
See https://gitlab.gnome.org/GNOME/nautilus/issues/322
|
|\
| |
| |
| |
| |
| |
| | |
Replace include guards with pragma once functionality
Closes #294
See merge request GNOME/nautilus!141
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The traditional include guards are not as easy to handle
and require extra thought into the names.
Pragma once is an easier, more contributor friendly approach.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/294
general: Remove include guards in favor of pragma once
The traditional include guards are not as easy to handle
and require extra thought into the names.
Pragma once is an easier, more contributor friendly approach.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/294
|
| |
| |
| |
| |
| | |
So it’s a bit clearer how the return values or parameters should be
managed.
|
| | |
|
|/
|
|
|
| |
The nautilus-window-slot.h include isn’t useful for anything and the
_get_type() declaration is redundant.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And fix make distcheck.
Although libnautilus-private seem self contained, it was actually
depending on the files on src/ for dnd.
Not only that, but files in libnautilus-private also were depending on
dnd files, which you can guess it's wrong.
Before the desktop split, this was working because the files were
distributed, but now was a problem since we reestructured the code, and
now nautilus being a library make distcheck stop working.
First solution was try to fix this inter dependency of files, but at
some point I realized that there was no real point on splitting some of
those files, because for example, is perfectly fine for dnd to need to
access the window functions, and it's perfectly fine for the widgets
in the private library to need to access to all dnd functions.
So seems to me the private library of nautilus is somehow an artificial
split, which provides more problems than solutions.
We needed libnautilus-private to have a private library that we could
isolate from extensions, but I don't think it worth given the problems
it provides, and also, this not so good logical split.
Right now, since with the desktop split we created a libnautilus to be
used by the desktop part of nautilus, extensions have access to all
the API of nautilus. We will think in future how this can be handled if
we want.
So for now, merge the libnautilus-private into src, and let's rethink
a better logic to split the code and the private parts of nautilus than
what we had.
Thanks a lot to Rafael Fonseca for helping in get this done.
https://bugzilla.gnome.org/show_bug.cgi?id=765543
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Vim and emacs modelines are used to specify some of the code style in the code.
However, this is misleading and poorly supported since nautilus had a mix of
code style for some time.
Also, the mode lines doesn't specify the whole code style, so we will need to
use a different tool as well to specify the whole code style.
For that, we can just use a different tool for everything.
So remove the mode lines, and in a short future we will reestyle the nautilus
code to have a single code style, and use a tool like editorconfig to specify
the whole code style.
|
|
|
|
|
|
|
|
| |
Expose the search function on the whole stack.
We will need it for searches from the gnome-shell provider.
https://bugzilla.gnome.org/show_bug.cgi?id=762076
|
|
|
|
|
|
|
|
|
|
| |
The newest mockups for Nautilus search shows a popover
that contains all the necessary options to edit search
filters.
This commit implements it. The following commits will
adapt NautilusQueryEditor to match the latest mockups
and display this popover.
|
| |
|
| |
|
|
|
|
|
|
|
| |
- streamline the code to use GtkWidget methods for visibility and focus
- remove an unused method
- merge nautilus_query_editor_clear_query() with
nautilus_query_editor_set_query()
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=679900
|
|
|
|
|
|
|
|
| |
Save vertical space by integrating the search bar
with the query editor. This makes it less visually
disruptive when a search becomes active.
https://bugzilla.gnome.org/show_bug.cgi?id=679900
|
|
|
|
|
| |
It doesn't really make sense to artificially change the query target if
we're indexed.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the past, nautilus was designed keeping in mind the concept that it
might not just be a file browser, but a sort of platform to embed
various kind of views in it.
- libnautilus-private: general lowlevel items, such as the icon
container, NautilusFile, I/O and so on
- src: general widgets and UI items
- src/file-manager: file manager views, agnostic of what's in src/,
for the sake of being pluggable enough
This is really not applicable anymore, as nautilus won't go in any
direction other than being a file manager; at the same time, this
complicates code and architecture quite a lot.
In this commit, as a first step towards a more clean codebase, we remove
the NautilusWindowInfo and NautilusWindowSlotInfo interfaces, using
NautilusWindow and NautilusWindowSlot directly.
Note that there should be no actual code changes, only moving of pieces
around.
|
|
|
|
|
|
| |
Remove all uses of deprecated GDK and GTK+ symbols, replacing them
with the currently supported equivalents.
Based on a patch from Tal Benavidor (#565038).
|
|
|
|
|
|
|
|
|
| |
2008-07-21 Christian Neumair <cneumair@gnome.org>
* src/nautilus-query-editor.h:
Fix NautilusWindowInfo header inclusion.
svn path=/trunk/; revision=14397
|
|
|
|
|
|
|
|
|
|
| |
2008-07-08 Christian Neumair <cneumair@gnome.org>
* libnautilus-private/*.c:
* src/*.c:
Merge "multiview" tab branch. Fixes #48034.
svn path=/trunk/; revision=14328
|
|
|
|
|
|
|
|
|
|
|
| |
2008-05-21 A. Walton <awalton@gnome.org>
* */*.[ch]:
Move all of Nautilus to single Gtk+ includes, because Mitch says so.
Closes Bug #530315.
svn path=/trunk/; revision=14182
|
|
|