| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And fix make distcheck.
Although libnautilus-private seem self contained, it was actually
depending on the files on src/ for dnd.
Not only that, but files in libnautilus-private also were depending on
dnd files, which you can guess it's wrong.
Before the desktop split, this was working because the files were
distributed, but now was a problem since we reestructured the code, and
now nautilus being a library make distcheck stop working.
First solution was try to fix this inter dependency of files, but at
some point I realized that there was no real point on splitting some of
those files, because for example, is perfectly fine for dnd to need to
access the window functions, and it's perfectly fine for the widgets
in the private library to need to access to all dnd functions.
So seems to me the private library of nautilus is somehow an artificial
split, which provides more problems than solutions.
We needed libnautilus-private to have a private library that we could
isolate from extensions, but I don't think it worth given the problems
it provides, and also, this not so good logical split.
Right now, since with the desktop split we created a libnautilus to be
used by the desktop part of nautilus, extensions have access to all
the API of nautilus. We will think in future how this can be handled if
we want.
So for now, merge the libnautilus-private into src, and let's rethink
a better logic to split the code and the private parts of nautilus than
what we had.
Thanks a lot to Rafael Fonseca for helping in get this done.
https://bugzilla.gnome.org/show_bug.cgi?id=765543
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We removed the search action with a rework on the whole handling
of views/slots/search-query handling to decouple the code better
and not expose API that is not needed outside.
The problem is that we actually needed a way to search from the
application, since gnome-shell search provider communicates in that way.
However we missed this since it was just an action in the application,
which made us don't catch this.
Now we allow a search in the whole stack but in a cleaner and direct
way to not be in the same situation in the future.
This patch use that to make the shell search provider work again.
https://bugzilla.gnome.org/show_bug.cgi?id=762076
|
|
|
|
|
|
|
|
|
| |
Some backends doesn't support g_file_get_path, like the trash backends,
and we were crashing trying to create a description with a NULL path.
For those, just use the uri as a description.
https://bugzilla.gnome.org/show_bug.cgi?id=762076
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NautilusQuery handle all the necessary data
to perform searches throughout directories.
Currently, there is no NautilusQuery subclass
in Nautilus code, and - since it's inside
libnautilus-private - there is no way to subclass
it.
This commit updates NautilusQuery code be a final
class.
|
|
|
|
|
| |
So we will be able to remove some of the public API, since we
can use GList functions.
|
|
|
|
|
|
|
| |
With latests commits we changed the finished signal to report
also the search engine status.
I forgot to change it for the shell-search-provider as well,
which was making nautilus crash when searching on shell.
|
|
|
|
|
| |
There is no need to initialize the volume monitor early, since it's
already a singleton.
|
|
|
|
|
|
|
|
|
| |
NautilusBookmarkList is already a singleton; since the shell provider
object is created before the application knows whether it's the primary
instance or not, loading the list in that code path makes us do ore work
than needed when we're only running as a launcher.
Just call the singleton getter every time.
|
|
|
|
|
|
|
|
|
|
| |
It's useful to differentiate files from different folders with
the same name. That's a common problem that we hit in the normal
nautilus search.
But it's easily fixable for the shell provider search, adding the path
as a description.
https://bugzilla.gnome.org/show_bug.cgi?id=743715
|
|
|
|
| |
This is not needed anymore, now what we're fully dbus activatable.
|
|
|
|
|
|
| |
Use the website instead.
https://bugzilla.gnome.org/show_bug.cgi?id=721518
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As Matthias Clasen noticed, the signal handlers for the gdbus-codegen
skeleton for the shell search provider have the wrong signature, and
should return TRUE to indicate that the signal has been handled.
Otherwise, it is down to chance if the method is handled or if a
method-not-implemented error is emitted. It seems that the GCC option
-fstack-protector-strong causes the default return value to be
interpreted as FALSE, so this might explain why the problem was only
noticed by a wide variety of users recently.
The bug manifests as Nautilus not returning any search results when
using the gnome-shell activities overview search.
https://bugzilla.gnome.org/show_bug.cgi?id=692041
|
|
|
|
|
| |
There's another occurrence of GtkImageMenuItem right now, for the "Open
With..." menu which is harder to fix.
|
|
|
|
|
| |
Port the rendering of icons to cairo surfaces, so that we can apply the
GDK scale factor when rendering icons.
|
|
|
|
|
|
| |
This improves deserialization performance in gnome-shell.
https://bugzilla.gnome.org/show_bug.cgi?id=704949
|
|
|
|
|
| |
It was unintentionally changed from opening the default application for
the result to selecting it in a view.
|
| |
|
|
|
|
|
|
|
|
| |
While the operation is in progress, since we're returning the result
asynchronously, we need to keep a reference to the invocation, or it
could be invalid when returning later.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=874534
|
| |
|
|
|
|
|
|
|
|
| |
Since NautilusApplication is a service, we can now handle searches and
windows coming and going indipendently just fine.
This also allows us to launch a search directly from the search provider
very easily.
|
| |
|
|
|
|
| |
Now that we depend on GLib master anyway.
|
|
|
|
|
|
| |
Instead of the XDG directory name; this makes name edits from the
Bookmarks window apply correctly to the sidebar.
Likewise, allow renaming of XDG bookmarks from the context menu.
|
|
|
|
|
| |
Avoid GFile<->URI roundtrips if possible. Also, this will allow us to
use the same API for another purpose.
|
|
|
|
| |
Didn't mean to remove this line.
|
|
|
|
|
|
|
|
|
|
|
| |
Don't assume there's only one engine running at the time, and avoid
requiring state from the global app singleton in search callbacks.
This fixes a crash where we would dereference NULL in the hits-added
callback, since we would access it through the global app object, and
self->active_search was previously cleared on cancellation.
https://bugzilla.gnome.org/show_bug.cgi?id=686168
|
|
|
|
|
| |
Since this is never emitted, keeping the code around just makes it more
complicated.
|
|
|
|
|
| |
This also allows us to use a heuristic to evaluate how good the filename
match is.
|
|
|
|
|
|
|
| |
Add a query property we can set to false from the shell provider, and
use it in the simple search engine to exclude hidden files. Note that by
default the query sets it to TRUE, so the behavior in Nautilus is
unchanged.
|
|
|
|
|
|
|
| |
Since the WM itself spawns us, I think the API should pass the timestamp
down; since it doesn't, get a timestamp ourselves.
https://bugzilla.gnome.org/show_bug.cgi?id=674816
|
| |
|
|
|
|
|
|
|
| |
Instead of immediately adding hits to the hash table for every type
we're interested in, and loop through the terms array every time,
first build a list of builtin match candidates, and then check in a
single loop if they're valid search results.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=684697
|
|
|
|
|
|
|
|
|
| |
Since g_mount_get_name() and nautilus_bookmark_get_name() can possibly
return NULL, warn against it before normalizing the string and trying to
compare it with the search terms. This fixes a crasher in the shell
search provider.
https://bugzilla.gnome.org/show_bug.cgi?id=684807
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=684378
|
|
|
|
| |
Since the hardcoded provider in the Shell is going away.
|
|
|
|
| |
Based on a patch by Florian Müllner <fmuellner@gnome.org>
|
|
|
|
|
| |
Wire the methods with an implementation that uses NautilusSearchEngine
to get results.
|
|
It's not wired in yet.
|