| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
Usage was generally removed in 2d1deaac2dd12b0ba16446bfbf3498b266e60338
|
| | |
|
| |
|
|
| |
See gnome-desktop!132
|
| |
|
|
|
| |
There are some style issue since the last run. Let's run it again
before enabling style-check CI job.
|
| |
|
|
|
| |
The code was copied to avoid having an external GTK+ 3 dependency, but
at this point it’s more trouble than it’s worth.
|
| |
|
|
|
|
|
| |
This is one of prerequisite steps to take before fully switching to GTK+
4, as gnome-desktop has code, depending on GTK+ 3. Since the
thumbnailing machinery is self-contained, it can easily be just copied
over.
|
| |
|
|
| |
So we can query them away.
|
| |
|
|
|
|
|
| |
Shadowing variables is error-prone, since one might mean to refer to a
variable that was declared earlier, but has the same name. Additionally,
being more strict about variable scoping can help make the code more
readable.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
When requesting the thumbnail icon of a file, if the requested size is
more than 25% larger than what the gnome-desktop thumbnail factory gives
us, the code tries to thumbnail the file using GdkPixbuf to avoid
possible quality degradation.
After 860f748ab2f47be2a604f89bd86e9499380f82a8, that code path should
never be executed (but is, because of a missing change to the logic) and
is safe to remove.
|
| |
|
|
|
|
|
| |
Chasing down macros to get some debugging output gets tedious and the
effect on performance should be negligible.
https://bugzilla.gnome.org/show_bug.cgi?id=784200
|
| |
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=770564
|
| |
|
|
|
|
|
|
| |
And make the style of Nautilus the same for all files.
Hopefully we can fix all the style issues we can find in the next days,
so expect a little of movement on this.
https://bugzilla.gnome.org/show_bug.cgi?id=770564
|
|
|
And fix make distcheck.
Although libnautilus-private seem self contained, it was actually
depending on the files on src/ for dnd.
Not only that, but files in libnautilus-private also were depending on
dnd files, which you can guess it's wrong.
Before the desktop split, this was working because the files were
distributed, but now was a problem since we reestructured the code, and
now nautilus being a library make distcheck stop working.
First solution was try to fix this inter dependency of files, but at
some point I realized that there was no real point on splitting some of
those files, because for example, is perfectly fine for dnd to need to
access the window functions, and it's perfectly fine for the widgets
in the private library to need to access to all dnd functions.
So seems to me the private library of nautilus is somehow an artificial
split, which provides more problems than solutions.
We needed libnautilus-private to have a private library that we could
isolate from extensions, but I don't think it worth given the problems
it provides, and also, this not so good logical split.
Right now, since with the desktop split we created a libnautilus to be
used by the desktop part of nautilus, extensions have access to all
the API of nautilus. We will think in future how this can be handled if
we want.
So for now, merge the libnautilus-private into src, and let's rethink
a better logic to split the code and the private parts of nautilus than
what we had.
Thanks a lot to Rafael Fonseca for helping in get this done.
https://bugzilla.gnome.org/show_bug.cgi?id=765543
|
