summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Fix typoAnders Jonsson2017-10-141-1/+1
| | | | | | (overriden -> overridden) https://bugzilla.gnome.org/show_bug.cgi?id=786965
* files-view: fix NautilusFloatingBar interfering with double clickNelson Benítez León2017-10-121-0/+17
| | | | | | | | | | | | | | | | | | | | When you have the mouse pointer at the bottom of the icon view in the area of the floating bar (which is hidden as you have the pointer there) if the file is not selected and you double-click it, it fails to launch because the floating bar appears for an instant and eats the second click of the double-click. What happens is the first click selects the file and queues a floating bar show info, the floating bar appears for an instant eating your second click, it hides again as you have the pointer in the floating bar area. Fixed by making the floating bar pass-through the click events to its underneath window just for the timeframe a double click could happen. We can't leave pass-through always on because the parent overlay "enter-notify-event" event would not fire in that case. Fixes: https://gitlab.gnome.org/GNOME/nautilus/issues/28
* Prefer local (file://) URIs than native ones (smb:// for example).Colin Leroy2017-10-123-1/+30
| | | | | | This allows drag and dropping files from network shares in Thunar to other applications that don't handle native URIs (Claws Mail, Chromium, Firefox...)
* nautilus-view-icon-item-ui: Fix black icon item backgroundJan-Michael Brummer2017-10-011-1/+1
|
* toolbar: Add explanatory tooltips to buttonsDaniel Boles2017-09-171-1/+7
| | | | | | | | These are nice to have for anyone and might also be useful for a11y. Now without introducing a syntax error! https://bugzilla.gnome.org/show_bug.cgi?id=787153
* Revert "toolbar: Add explanatory tooltips to buttons"Daniel Boles2017-09-141-7/+1
| | | | | | | | | This reverts commit d68ae9aafc2a50ac36221331ae6ff6cff3ff1f33. Gah. I was sure I had seen a branch for 3.26, and coupling that with Carlos saying push, I didn’t bother double-checking. Boom: freeze break. Thanks to Piotr for pointing this out. Also: a hilarious typo. :C
* toolbar: Add explanatory tooltips to buttonsDaniel Boles2017-09-141-1/+7
| | | | | | These are nice to have for anyone and might also be useful for a11y. https://bugzilla.gnome.org/show_bug.cgi?id=787153
* Revert "file-operations: forbid more characters in FAT"Ernestas Kulik2017-09-031-1/+1
| | | | This reverts commit f4292a57f321a1727ee6a2bdf765f14524c464eb.
* file-operations: forbid more characters in FATErnestas Kulik2017-09-031-1/+1
| | | | | | ‘\’ and ‘|’ aren’t allowed in both 8.3 and long file names. https://bugzilla.gnome.org/show_bug.cgi?id=771364
* list-model: use macro for type castingVyas Giridharan2017-09-021-11/+11
| | | | | | | This patch converts all type casting to use the generated GLib macro for consistency throughout the codebase. https://bugzilla.gnome.org/show_bug.cgi?id=786866
* list-model: port to G_DECLARE_* macrosVyas Giridharan2017-09-022-134/+218
| | | | | | | Porting type declarations to use GLib macros will reduce a good amount of boilerplate code. https://bugzilla.gnome.org/show_bug.cgi?id=786866
* floating-bar: port to GLib type declaration macros.Vyas Giridharan2017-08-302-72/+45
| | | | | | | | | Porting Nautilus object declarations to G_DECLARE_*_TYPE will reduce a huge number of boilerplate code. That will make nautilus code easier for newcomers and others alike. https://bugzilla.gnome.org/show_bug.cgi?id=786815
* file-operations: fail when overwriting directory with fileErnestas Kulik2017-08-281-113/+30
| | | | | | | | | | GIO documentation (and therefore code) mandates that copies and moves of files over directories should fail, but Nautilus has support for such (possibly dangerous) operations even to this day. This commit works with the assumption that whatever backend happens to be used, it will fail as expected and not overwrite the directory. https://bugzilla.gnome.org/show_bug.cgi?id=773671
* operations-ui-manager: Use consistent item count labelAntónio Fernandes2017-08-281-2/+2
| | | | | | | | | "Items: n items" is repeting the same word. Instead, use "Contents: n items", which is consistent with the label used by the properties dialog. Fixes https://bugzilla.gnome.org/show_bug.cgi?id=786699
* files-view: Allow numpad Delete to send items to trashAntónio Fernandes2017-08-281-6/+18
| | | | | | | | | | The Delete key is the keyboard accelerator to send items to Trash (or delete permanently when Trash is not available). The numpad Delete key is unused. So, let the numpad Delete key act as accelerator for the same actions. Also, for consistency, allow it to combo with <shift> for deleting permanently. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=750491
* search-directory: rename method instance parametersErnestas Kulik2017-08-242-196/+196
| | | | | | The new standard around here is “self”. https://bugzilla.gnome.org/show_bug.cgi?id=786760
* search-directory: use GLib type-definition macrosErnestas Kulik2017-08-242-130/+108
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=786760
* directory: define autoptr cleanup funcErnestas Kulik2017-08-241-0/+2
| | | | | | | If any derived classes have one of their own defined, the compiler will start spewing warnings. https://bugzilla.gnome.org/show_bug.cgi?id=786760
* file: reduce the amount of directory state pokingErnestas Kulik2017-08-241-23/+27
| | | | | | | This commit refactors some functions to use the public NautilusDirectory API. https://bugzilla.gnome.org/show_bug.cgi?id=786760
* directory: reorganize static functionsErnestas Kulik2017-08-241-157/+145
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=786760
* vfs-directory: stop poking internal directory stateErnestas Kulik2017-08-242-30/+26
| | | | | | | | This commit moves some NautilusVFSDirectory vfunc overrides to NautilusDirectory, as they directly access NautilusDirectoryDetails fields. https://bugzilla.gnome.org/show_bug.cgi?id=786760
* pathbar: rename method instance parametersErnestas Kulik2017-08-242-179/+179
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=786712
* pathbar: port declaration to G_DECLARE_*_TYPEVyas Giridharan2017-08-242-193/+283
| | | | | | | This patch ports declaration of NautilusPathBar to the G_DECLARE* format. https://bugzilla.gnome.org/show_bug.cgi?id=786712
* toolbar: hide location entry on lost focusErnestas Kulik2017-08-231-0/+125
| | | | | | | This solves the issue of the location entry remaining in the toolbar if the user inadvertently (or not) tab-focuses a different widget. https://bugzilla.gnome.org/show_bug.cgi?id=92509
* file: use unsigned int when shifting 31 bitsMohammed Sadiq2017-08-231-1/+1
| | | | | | | | | | | | | | | | In C, as numbers are signed integers by default, it is an Undefined Behaviour to left shift a signed integer by 31 bits (when the integer size is 32 bits which is the common size where nautilus runs). So explicitly use unsigned integer. This issue was found by UBsan: nautilus/src/nautilus-file.c:312:14: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' nautilus/src/nautilus-file.c:4273:11: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' nautilus/src/nautilus-file.c:366:18: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' https://bugzilla.gnome.org/show_bug.cgi?id=786685
* window-slot: hide search bar on ESC pressesErnestas Kulik2017-08-231-0/+12
| | | | | | This supposedly regressed after some version of Nautilus. https://bugzilla.gnome.org/show_bug.cgi?id=685120
* special-location-bar: ported declaration to G_DECLARE*Vyas Giridharan2017-08-232-42/+19
| | | | | | | This patch ports declaration of NautilusSpecialLocationBar to the G_DECLARE* format. https://bugzilla.gnome.org/show_bug.cgi?id=771777
* search-engine-tracker: ported declaration to G_DECLARE*Vyas Giridharan2017-08-232-63/+45
| | | | | | | This patch ports declaration of NautilusSearchEngineTracker to the G_DECLARE* format. https://bugzilla.gnome.org/show_bug.cgi?id=771777
* search-engine-model: ported declaration to G_DECLARE*Vyas Giridharan2017-08-232-57/+39
| | | | | | | This patch ports declaration of NautilusSearchEngineModel to the G_DECLARE* format. https://bugzilla.gnome.org/show_bug.cgi?id=771777
* icon-info: ported declaration to G_DECLARE*Vyas Giridharan2017-08-222-18/+2
| | | | | | | This patch ports declaration of NautilusIconInfo to the G_DECLARE* format. https://bugzilla.gnome.org/show_bug.cgi?id=771777
* list-view: ported declaration to G_DECLARE*Vyas Giridharan2017-08-221-18/+5
| | | | | | | This patch ports declaration of NautilusListView to the G_DECLARE* format. https://bugzilla.gnome.org/show_bug.cgi?id=771777
* files-view: Fix identationCarlos Soriano2017-08-211-6/+6
|
* files-view: Replace eel_show_error_dialogRobert Stanca2017-08-211-5/+5
| | | | | | | | | | Now that show_error_dialog is implemented we should not use eel_show_error_dialog anymore. This patch removes dependency of eel by using buildin function show_error_dialog. https://bugzilla.gnome.org/show_bug.cgi?id=775092
* batch-rename-dialog: Use better wordingCarlos Soriano2017-08-181-4/+4
| | | | | | | Nautilus was using "unallowed" which sounds odd and also "file name" when in reality can also be folders. https://bugzilla.gnome.org/show_bug.cgi?id=771114
* window: Make history-hierarchy interaction orthogonal.António Fernandes2017-08-181-43/+1
| | | | | | | | | | | | We are treating a click in the pathbar as a back/forward history action if the target location is already in history. This makes the Back and Forward buttons unconsistent in result. Instead, treat any click on the pathbar as new history entry. Addapted from original patch by Marcus Husar <marcus.husar@gmail.com>. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=563009
* file: Fix identationCarlos Soriano2017-08-171-7/+8
|
* dnd: make sidebar show "new bookmark" only for foldersNelson Benítez León2017-08-174-2/+30
| | | | | | | Make sure sidebar shows "new bookmark" only when folders are being dragged. https://bugzilla.gnome.org/show_bug.cgi?id=754513
* preferences-window: Use spin button for thumbnail limitvyasgiridhar2017-08-173-235/+180
| | | | | | | | | | | | | | File sizes (especially compressed images) are arbitrary values that are highly dependant on the camera resolution, and contents of the image. Therefore it does not make sense to have this be a drop-down with preset hard-coded values: A 21MP camera often produces 12MB images... but the only option is 10MB, or 100MB. This commit changes the combobox in the preferences to a spinbutton and changes the signal handler for thumbnail-limit. The value is in MB, with a maximum of 4096 and a minimum of 1. https://bugzilla.gnome.org/show_bug.cgi?id=779165
* file: Use Unicode ellipsis and em dash for default attribute stringsAntónio Fernandes2017-08-171-4/+4
| | | | | | | | | We are using three dots "..." and two hyphens "--" as the default string of some attributes. Replace them with "…" and "—" respectively. https://bugzilla.gnome.org/show_bug.cgi?id=99439
* file: Change string of unreadable directory item countAntónio Fernandes2017-08-171-1/+1
| | | | | | | | | | | | We are displaying "? items" in the size column for unreadable folders. This string is weird and doesn't contribute a clear meaning, but a long string such as "uknown number of items" is not desirable either. So, change this string to "--", matching what is used when item count is disabled. https://bugzilla.gnome.org/show_bug.cgi?id=99439
* Save sidebar visibility stateJason Crain2017-08-171-12/+38
| | | | | | Save sidebar visibility to GSettings so the sidebar state is persistent. https://bugzilla.gnome.org/show_bug.cgi?id=785323
* pathbar: Remove drag-source handlingAntónio Fernandes2017-08-171-72/+0
| | | | | | | | | | So users can drag the window from the buttons of the pathbar too, as it seems it's more important feature for them instead of dnd the path in the pathbar, which is also quite undiscoverable. As per commit d379767851ac3dc28b1108d87b60ac0cad6c4c4a https://bugzilla.gnome.org/show_bug.cgi?id=785619
* Revert "pathbar: Remove dnd handling"António Fernandes2017-08-171-0/+177
| | | | | | | | | | | | | This reverts commit d379767851ac3dc28b1108d87b60ac0cad6c4c4a, which removed drag-and-drop interaction involving the pathbar, because it interfered with dragging to move the window from the headerbar. This made it impossible to drop files into a parent directory. But acting as a drop target would not interfere with dragging to move. We are removing again the problematic drag-source parts in the next commit. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=785619
* general: print debug info unconditionallyErnestas Kulik2017-08-172-88/+42
| | | | | | | Chasing down macros to get some debugging output gets tedious and the effect on performance should be negligible. https://bugzilla.gnome.org/show_bug.cgi?id=784200
* list-view: Do not set multiple margins on the column chooser.Robert Mibus2017-08-171-1/+0
| | | | | | There is already a margin set, so setting a left-margin creates a noticeably asymmetric effect. https://bugzilla.gnome.org/show_bug.cgi?id=782079
* search-popover: make type list box keyboard-navigableErnestas Kulik2017-08-172-1/+12
| | | | | | | | Currently, the type list box in the search popover is not keyboard-navigable, which, as a consequence, results in the user’s inability to also easily close the popover. https://bugzilla.gnome.org/show_bug.cgi?id=786402
* query: prefer prefix matches over sufix matchesAlexandru Pandelea2017-08-171-1/+10
| | | | | | | | | | | Currently, the number of letters before and after the match decrease the rank of the search hit by the same amount. Though, the prefix matches should be prefered over the sufix ones, so make the number of letters after the match decrease the rank by a much smaller factor than the number of letters before the match. https://bugzilla.gnome.org/show_bug.cgi?id=785942
* file-conflict-dialog: Add a mnemonic to the Replace buttonMartin Bříza2017-08-171-1/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=785137
* Revert "search-engine: fix search providers handling"Alexandru Pandelea2017-08-179-219/+85
| | | | | | This reverts commit 37693c427941d60634bad80dd7c2d0b3a8523cea. The patch was pushed by accident.
* search-engine: fix search providers handlingAlexandru Pandelea2017-08-159-85/+219
| | | | | | | | | | | | When starting the search providers, some provider might finish before all providers are started, so a wrong value of providers_running will be used, making Nautilus crash. To fix this, keep a queue of the started providers and whenever the value of the finised/running providers is needed, check the status of each provider. https://bugzilla.gnome.org/show_bug.cgi?id=785723
View Lorry Controller Status