summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* fixed recently introduced problem where it was still treating buttonAndy Hertzfeld2001-01-241-6/+2
| | | | | | | | * src/nautilus-theme-selector.c: (remove_button_callback), (exit_remove_mode): fixed recently introduced problem where it was still treating button labels as nautilus_labels instead of gtk_labels.
* fixed bug 5972, remove theme button uses aa text, by using a gtk_labelAndy Hertzfeld2001-01-241-5/+4
| | | | | | | | | | | | | | * src/nautilus-theme-selector.c: (nautilus_theme_selector_initialize), (remove_button_callback), (exit_remove_mode): fixed bug 5972, remove theme button uses aa text, by using a gtk_label instead of a nautilus_label. Also, hide the add button during remove mode so it's less confusing. * libnautilus-extensions/nautilus-theme.c: (nautilus_theme_make_selector): fixed a crash when an installed theme lacked a preview icon, cleaned up code and fixed a memory leak.
* reviewed by: Darin Adler <darin@eazel.com>Maciej Stachowiak2001-01-241-8/+135
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Partial fix for bug 5902 (Rapidly changing between Icon and Image/Text crashes Nautilus). * src/nautilus-view-frame.c: (nautilus_view_frame_load_client_async), (nautilus_view_frame_load_client), (nautilus_view_frame_stop_activation), (nautilus_view_frame_load_location), (nautilus_view_frame_stop_loading), (nautilus_view_frame_selection_changed), (nautilus_view_frame_title_changed), (nautilus_view_frame_is_zoomable), (nautilus_view_frame_get_zoom_level), (nautilus_view_frame_set_zoom_level), (nautilus_view_frame_get_min_zoom_level), (nautilus_view_frame_get_max_zoom_level), (nautilus_view_frame_get_has_min_zoom_level), (nautilus_view_frame_get_has_max_zoom_level), (nautilus_view_frame_get_is_continuous), (nautilus_view_frame_get_preferred_zoom_levels), (nautilus_view_frame_zoom_in), (nautilus_view_frame_zoom_out), (nautilus_view_frame_zoom_to_fit), (nautilus_view_frame_open_location_in_this_window), (nautilus_view_frame_open_location_prefer_existing_window), (nautilus_view_frame_open_location_force_new_window), (nautilus_view_frame_report_selection_change), (nautilus_view_frame_report_status), (nautilus_view_frame_report_load_underway), (nautilus_view_frame_report_load_progress), (nautilus_view_frame_report_load_complete), (nautilus_view_frame_report_load_failed), (nautilus_view_frame_set_title), (nautilus_view_frame_get_title), (nautilus_view_frame_get_label), (nautilus_view_frame_set_label), (nautilus_view_frame_activate), (get_history_list), (send_history), (nautilus_view_frame_get_is_underway): Silently do nothing if the view frame has failed. Based on suggestions from Darin. Also includes return_if_fail fixes from Darin.
* Fixed bug 2153 (deep count calculation in properties windowJohn Sullivan2001-01-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | could be faster) Fixed bug 5687 (Sidebar flickers and CPU thrashes during deep count calculation in properties window) Changed the deep count calculation to send a specialized signal when the in-progress count updates, instead of using "file_changed", since many parts of the UI react to file_changed by doing (in this case unnecessary) work. My stopwatch measurement on a large directory showed that the time to calculate 20000 contained files went from 147 seconds to 8 seconds, and the CPU usage pegged around 15% (formerly 100%). * libnautilus-extensions/nautilus-directory-async.c: (deep_count_callback): Call nautilus_file_changed only when count is finished; call nautilus_file_updated_deep_count_in_progress after every new higher value is computed. * libnautilus-extensions/nautilus-file-private.h: Added prototype for nautilus_file_updated_deep_count_in_progress. * libnautilus-extensions/nautilus-file.h: * libnautilus-extensions/nautilus-file.c: (nautilus_file_initialize_class): define "updated_deep_count_in_progres" signal. (nautilus_file_updated_deep_count_in_progress): send this new signal for this file (which must be a directory) and any links pointing to it. * src/file-manager/fm-properties-window.c: (attach_directory_contents_value_field): Make text field in properties window react to new signal instead of "changed".
* fixed bug 5587, hard-coded button geometry in the property browser, fixedAndy Hertzfeld2001-01-231-10/+9
| | | | | | | | | * src/nautilus-property-browser.c: (nautilus_property_browser_initialize), (make_category_link): fixed bug 5587, hard-coded button geometry in the property browser, fixed by removing the set_usizes and allowing gtk to adaptively size them and replacing the table that was holding them with a box so they will be centered properly.
* reviewed by: Pavel Cisler <pavel@eazel.com>Maciej Stachowiak2001-01-231-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Fixed bug 5943 (Throbber crashes on nautilus startup (crashing Nautilus) with some themes and configurations) * components/help/hyperbola-main.c: (main): * components/image-viewer/nautilus-image-view.c: (init_server_factory): * components/mozilla/main.c: (main): * components/music/main.c: (main): * components/notes/nautilus-notes.c: (main): * components/services/install/nautilus-view/main.c: (main): * components/services/login/nautilus-view/main.c: (main): * components/services/summary/nautilus-view/main.c: (main): * components/shell/shell.c: * components/text/main.c: (main): * components/throbber/main.c: (main): * components/tree/main.c: (main): * libnautilus/nautilus-view-standard-main.c: (nautilus_view_standard_main_multi): * nautilus-installer/src/main.c: (main): * src/nautilus-main.c: (main): Added gdk_rgb_init calls. The throbber one was causing a real 100% reproducible crash for me on Nautilus startup, the rest are pre-emptive.
* reviewed by: Pavel Cisler <pavel@eazel.com>Ramiro Estrugo2001-01-231-1/+11
| | | | | | | | | | | | | * src/nautilus-theme-selector.c: (nautilus_theme_selector_initialize): Band aid fix for bug 5910 - Font size for Theme name is too large in "Nautilus Theme Selector" dialog. I made the column larger to fit up to and including the length of the currently largest known theme name "Crux-Eggplant" There are many reason why this is a lame band aid fix. The real fix is to not hard code any geometry in this code. I filed a bug for that (5951).
* reviewed by: Pavel Cisler <pavel@eazel.com>Ramiro Estrugo2001-01-231-9/+6
| | | | | | | | | | | | Fix bug 5914 - First run of Nautilus on clean system crashes. * src/nautilus-application.c: (nautilus_application_initialize), (nautilus_application_destroy), (nautilus_application_startup): Add the preference callback for show_desktop much later in the initialization of the Nautilus Application. Otherwise, the first time druid triggers prefernece changes that cause the desktop to turn on in the middle of the first time druid being presented to the user.
* fixed bug 5895, critical errors when you make the sidebar small. Fixed byAndy Hertzfeld2001-01-231-7/+22
| | | | | | | | | | * src/nautilus-sidebar-tabs.c: (draw_one_tab_themed), (draw_or_layout_all_tabs): fixed bug 5895, critical errors when you make the sidebar small. Fixed by clipping the amount we draw to fit within the destination buffer before calling gdk_pixbuf_composite. Also fixed another crash when trying to draw aa-text for the tab labels when the starting offset is bigger than the buffer; in that case, don't draw anything.
* reviewed by: John Sullivan <sullivan@eazel.com>NAUTILUS_PR3_ANCHORRamiro Estrugo2001-01-221-28/+0
| | | | | | | | | | | | | | | | | | Fix 5613 - Icon captions in sidebar get cropped when toggling "smooth graphics. * libnautilus-extensions/nautilus-label.c: (label_force_cached_requisition_flush), (nautilus_label_set_is_smooth): Flush the GtkLabel's requisition cache when the is_smooth attribute is changed. * src/nautilus-property-browser.c: (nautilus_property_browser_initialize), (nautilus_property_browser_destroy), (nautilus_property_browser_theme_changed): Remove attempt at fixing parts of 5613. The fix above should fix it everywhere.
* reviewed by: Pavel Cisler <pavel@eazel.com> (exceptJohn Sullivan2001-01-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix for bug 5884, which nobody reviewed) Fixed bug 5766 (assertion when switching views) Fixed bug 5884 (Rename file dialog for missing file quotes intended name rather than current) * libnautilus-extensions/nautilus-mime-actions.c: (nautilus_mime_get_default_action_type_for_file), (nautilus_mime_get_default_action_for_file), (nautilus_mime_get_default_application_for_file_internal), (nautilus_mime_get_default_component_for_file_internal), (nautilus_mime_get_short_list_applications_for_file), (nautilus_mime_get_short_list_components_for_file), (nautilus_mime_get_short_list_methods_for_file), (nautilus_mime_get_all_applications_for_file), (nautilus_mime_get_all_components_for_file): These functions were all using return_val_if_fail if nautilus_mime_actions_check_if_minimum_attributes_ready returned FALSE. In keeping with the style used in NautilusFile, changed these to check and return, but not complain, in these cases where the answer is "not enough info yet". I did not change the setters; they still complain. * src/file-manager/fm-error-reporting.c: (fm_report_error_renaming_file): Use "original_name" instead of "new_name" in error message.
* Fix bugzilla.eazel.com bug 2659, that behavior with backup search isRebecca Schulman2001-01-222-65/+120
| | | | | | | | | | | | | | | | | | | 2001-01-22 Rebecca Schulman <rebecka@eazel.com> Fix bugzilla.eazel.com bug 2659, that behavior with backup search is inconsistent, because content backup searches are unavailable. We now * src/file-manager/fm-search-list-view.c: (load_location_callback), (load_error_callback), (display_indexed_search_problems_dialog): Add checks to handle both the case where the indexed search is not available and the case where a backup search is not available. Explain why an index search cannot be performed, and also if applicable why a backup search can't be performed. * src/file-manager/nautilus-indexing-info.c: (nautilus_indexing_info_get_last_index_time): Return NULL if there are no indices, instead of the timestring for time = 0.
* reviewed by: <arik@gnome.org> (Wincing)Michael Fleming2001-01-221-16/+113
| | | | | | | | | | | | | Bug 5625: Fonts were incorrect size. Bug 5872: HTTP proxy setting and auto-detect broken due to preference changes. * src/nautilus-first-time-druid.c: (make_hbox_user_level_radio_button), (set_up_user_level_page), (set_up_service_signup_page), (set_up_update_page), (proxy_address_entry_key_press), (set_up_proxy_config_page), (set_up_update_feedback_page), (initiate_file_download), (set_http_proxy):
* removed the "vector" theme at Arlo's request, and many of the leastAndy Hertzfeld2001-01-223-6/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | removed the "vector" theme at Arlo's request, and many of the least popular patterns * configure.in: removed vector from the build * data/browser.xml: * data/patterns/Makefile.am: removed lots of specific patterns * icons/Makefile.am: removed vector theme * icons/ardmore/ardmore.xml: * icons/gnome/gnome.xml: fixed bug 5868, GNOME theme has white text on light background, by setting the text color in the theme * icons/vector/.cvsignore: * icons/vector/Makefile.am: * icons/vector/i-directory-accept.svg: * icons/vector/i-directory.svg: * icons/vector/i-regular.svg: * icons/vector/i-regular.xml: * icons/vector/vector.xml: the vector theme is no more * nautilus.spec.in: removed the vector theme from the rpm spec file * po/POTFILES.in: removed the vector theme from the localized files * src/nautilus-property-browser.c: (make_property_tile), (nautilus_property_browser_get_category_width): tweaked the layout * src/nautilus-sidebar-title.c: (nautilus_sidebar_title_theme_changed): changed default shadow to 1 pixel * src/nautilus-theme-selector.c: (done_button_callback), (nautilus_theme_selector_initialize): added a done button like the property browser
* fixed bug 3165, Customization Dialog needs layout tweaking, by workingAndy Hertzfeld2001-01-202-62/+41
| | | | | | | | | | | | | | * src/nautilus-property-browser.c: (nautilus_property_browser_initialize), (make_property_tile), (nautilus_property_browser_update_contents): fixed bug 3165, Customization Dialog needs layout tweaking, by working with Arlo to improve it. We also made it more GTK-theme compliant * src/nautilus-theme-selector.c: (nautilus_theme_selector_initialize): Arlo and I also improved the theme selector in a similar fashion, including making it GTK-theme complaint.
* reviewed by: Darin Adler <darin@eazel.com>John Sullivan2001-01-201-6/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed bug 5807 (view switches to manual layout only after hitting Refresh), and other metadata-related problems. This was a long-standing race condition exposed by recent timing changes. The directory view was waiting for its metadata-as-file, but not for its metadata-as-directory, and it needed both before trying to lay out the contained icons. * src/file-manager/fm-directory-view.c: added metadata_for_directory_as_file_pending and metadata_for_files_in_directory_pending to details struct. (load_directory): set both pending flags to TRUE before using call_when_ready to get metadata; use call_when_ready for getting contained-files metadata as well as directory-as-file metadata. (finish_loading_if_all_metadata_loaded): New function, finishes loading (which lays out the icons) only if neither metadata is still pending. (metadata_for_directory_as_file_ready_callback): clear metadata_for_directory_as_file_pending flag before calling finish_loading_if... (metadata_for_files_in_directory_ready_callback): clear metadata_for_files_in_directory_pending flag before calling finish_loading_if... (disconnect_model_handlers): cancel both metadata callbacks.
* removed the obsolete eazel theme, as well as the old, non-componentizedAndy Hertzfeld2001-01-202-560/+0
| | | | | | | | | | | | | | | | | | | | | | | | removed the obsolete eazel theme, as well as the old, non-componentized throbber. * configure.in: * icons/Makefile.am: * icons/eazel/.cvsignore: * icons/eazel/Makefile.am: * icons/eazel/eazel.xml: * icons/eazel/*.png: * icons/eazel/i-directory-accept.xml: * icons/eazel/i-directory.xml: * icons/eazel/i-regular.xml: * icons/eazel/sidebar_tab_pieces/.cvsignore: * icons/eazel/sidebar_tab_pieces/Makefile.am: * icons/eazel/sidebar_tab_pieces/*.png: * icons/eazel/throbber/.cvsignore: * icons/eazel/throbber/Makefile.am: * icons/eazel/throbber/*.png: * po/POTFILES.in: * src/nautilus-throbber.c: * src/nautilus-throbber.h:
* Remove extra commas that broke compilation.Rebecca Schulman2001-01-191-3/+3
| | | | | | | | 2001-01-19 Rebecca Schulman <rebecka@eazel.com> * src/file-manager/fm-search-list-view.c: (display_indexed_search_problems_dialog): Remove extra commas that broke compilation.
* reviewed by: John Sullivan <sullivan@eazel.com>Rebecca Schulman2001-01-192-17/+123
| | | | | | | | | | | | | | | | | | | | | | | | | 2001-01-19 Rebecca Schulman <rebecka@eazel.com> reviewed by: John Sullivan <sullivan@eazel.com> * src/file-manager/fm-search-list-view.c: (load_location_callback), (display_indexed_search_problems_dialog): Added dialogs to explain problems that may occur when running a search. There are separate dialogs to explain each of the following errors: 1. No index files available 2. Index still being created 3. Index files are available, but the search daemon isn't running 4. No index files, and no reindexing service avaialble We may be able to actually do something about some of these problems in the future (ie launch the search or indexing daemons if they're not already running) but for PR3 explaining what is going on in each of these cases should be a big step forward * src/file-manager/nautilus-indexing-info.c: (nautilus_indexing_info_show_dialog): Show the index files status dialog if there are index files, or indexing is going on, rather than if the search service is available, so that a user can follow indexing progress, even if an index isn't ready yet.
* reviewed by: Michael Engber <engber@eazel.com>Darin Adler2001-01-191-49/+78
| | | | | | | | | | | | | | | | | | | * src/nautilus-view-frame-corba.c: (view_widget_gone), (impl_Nautilus_ViewFrame__destroy), (impl_Nautilus_ViewFrame__create), (impl_Nautilus_ViewFrame_open_location_in_this_window), (impl_Nautilus_ViewFrame_open_location_prefer_existing_window), (impl_Nautilus_ViewFrame_open_location_force_new_window), (impl_Nautilus_ViewFrame_report_selection_change), (impl_Nautilus_ViewFrame_report_status), (impl_Nautilus_ViewFrame_report_load_underway), (impl_Nautilus_ViewFrame_report_load_progress), (impl_Nautilus_ViewFrame_report_load_complete), (impl_Nautilus_ViewFrame_report_load_failed), (impl_Nautilus_ViewFrame_set_title): Since the NautilusViewFrame object is a widget, we don't control its lifetime completely. So we disconnect from it when it is destroyed and stop trying to make calls on it.
* reviewed by: Darin Adler <darin@eazel.com>John Sullivan2001-01-192-3/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Finished bug 2146 (Properties window for desktop Trash should show Trash properties). The last two changes were to remove the "accessed" field for all directories, since it seems useless, and to fill in the "where" field with "on the desktop". * libnautilus-extensions/nautilus-file.c: (nautilus_file_get_where_string): New function, calls virtual function so trash and normal files can report different strings. (nautilus_file_get_string_attribute): Changed "parent_uri" string attribute to "where", since it is not the parent_uri in the Trash case. * libnautilus-extensions/nautilus-file.h: Virtual function pointer for get_where_string. * libnautilus-extensions/nautilus-trash-file.c: (trash_file_get_where_string), (nautilus_trash_file_initialize_class): Supply get_where_string function that returns "on the desktop". * libnautilus-extensions/nautilus-vfs-file.c: (vfs_file_get_where_string), (nautilus_vfs_file_initialize_class): Supply get_where_string function that returns parent_uri string. * src/file-manager/fm-properties-window.c: (should_show_accessed_date): New function, returns FALSE for directories and TRUE for other files. (create_basic_page): Honor should_show_accessed_date, and use "where" instead of "parent_uri" string attribute. * src/file-manager/fm-search-list-view.c: (real_get_column_specification): Use "where" instead of "parent_uri" string attribute.
* more clean-up and fixes for the default theme changeAndy Hertzfeld2001-01-193-11/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | more clean-up and fixes for the default theme change * icons/ardmore/ardmore.xml: * icons/arlo/arlo.xml: * icons/default.xml: * icons/eazel/eazel.xml: * icons/gnome/gnome.xml: * icons/vector/vector.xml: * icons/villanova/villanova.xml: at Arlo's request, capitalized the theme names and also made them localizable, and tweaks to some of the theme files to fix problems caused by the new default * src/nautilus-sidebar-tabs.c: (nautilus_sidebar_tabs_load_theme_data): added a way to specify the non-pixmap tabs, since it uses pixmap ones in the default now * src/nautilus-theme-selector.c: (get_theme_description_and_display_name), (add_theme): made it use a localizable name in the xml file instead of the actual folder name. * src/nautilus-window-toolbars.c: (get_file_name_from_icon_name): added a way to get the stock gnome toolbar icons, now that we have our own in the default theme * nautilus.spec.in: added the throbber component to our package
* reviewed by: Pavel Cisler <pavel@eazel.com>Darin Adler2001-01-192-18/+5
| | | | | | | | | | | | | | | | | | | | | | | | | (only the first 2 changes, others unreviewed) * libnautilus-extensions/nautilus-trash-directory.c: (trash_destroy): Fix problem that might be what's killing the Tinderbox. We need to disconnect the signal handlers we add to the trash monitor. * src/file-manager/fm-directory-view.c: (load_location_callback): Always reload when navigating. This smooths over many anomalies, and hopefully will fix the nasty problems described in bug 4873 (files created in home directory (outside Nautilus) don't show up when I navigate there) and bug 4963 (starting the search service while running nautilus doesn't let you run searches). * configure.in: Fix gnome-http check that was previously just checking whether gnome-config was there or not! * src/nautilus-application.c: (nautilus_application_startup): Replace incorrect references to nautilus.oafinfo to instead mention Nautilus_Shell.oaf. * test/.cvsignore: Add a generated file.
* reviewed by: Darin Adler <darin@eazel.com>John Sullivan2001-01-193-4/+4
| | | | | | | | | | | | | | | | | | Fixed bug 3417 (Put existing preferences at right levels) * libnautilus-extensions/nautilus-global-preferences.c: (global_preferences_install_defaults), (global_preferences_install_visibility): First pass at setting appropriate defaults and user levels for preferences. (global_preferences_create_dialog): Put "show only folders in tree view" before other preferences that appear only in higher user levels, 'cuz it looks better that way. * src/nautilus-shell-ui.xml: * src/nautilus-window-menus.c: (user_level_customize_callback): Renamed "Edit Settings" menu item & dialog to "Preferences"; marked dialog title for localization.
* now that the bonobo problems are resolved, we can go back to theAndy Hertzfeld2001-01-1810-116/+8
| | | | | | | | | | | | | now that the bonobo problems are resolved, we can go back to the componentized throbber. * src/Makefile.am: * src/nautilus-window-toolbars.c: (nautilus_window_initialize_toolbars): * src/nautilus-window.c: (throbber_location_changed_callback), (nautilus_window_constructed), (nautilus_window_destroy), (nautilus_window_allow_stop): * src/nautilus-window.h:
* reviewed by: Pavel Cisler <pavel@eazel.com>John Harper2001-01-181-1/+0
| | | | | | | | | | | | 2001-01-18 John Harper <jsh@eazel.com> reviewed by: Pavel Cisler <pavel@eazel.com> Fixed bug where selecting the first item in a list view, then hitting Shift-TAB would always trigger an assertion * src/file-manager/fm-list-view.c (select_previous_next_common): deleted the bogus assertion
* backed out the Bonobo component throbber temporarily due to BonoboAndy Hertzfeld2001-01-1810-21/+119
| | | | | | | | | | | | | | | | | | | | backed out the Bonobo component throbber temporarily due to Bonobo problems and restored the old one; hopefully, the new one will come back soon. * src/Makefile.am: * src/nautilus-window-toolbars.c: (nautilus_window_initialize_toolbars): * src/nautilus-window.c: (nautilus_window_constructed), (nautilus_window_destroy), (nautilus_window_allow_stop): * src/nautilus-window.h: fixed bug 5393, custom emblems arent scaling properly, by * libnautilus-extensions/nautilus-icon-container.c: (nautilus_icon_container_update_icon): * libnautilus-extensions/nautilus-icon-factory.c: (get_themed_icon_file_path), (load_pixbuf_svg), (load_specific_icon):
* reviewed by: John Sullivan <sullivan@eazel.com>Darin Adler2001-01-186-72/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed bug 2147 (NautilusFile for trash needs non-empty values for more properties), bug 5652 (MIME type field appears but shouldn't in properties window for Trash), and bug 4620 (trash sidebar should show number of items). * libnautilus-extensions/nautilus-file.h: * libnautilus-extensions/nautilus-file-private.h: * libnautilus-extensions/nautilus-file.c: (nautilus_file_new_from_relative_uri): Create trash file subclass when appropriate. (nautilus_file_info_missing): Rename so it can be used in other source files. (nautilus_file_get_date): New method that returns numeric dates. (nautilus_file_get_date_as_string): Change to call nautilus_file_get_date to get the numeric date. (nautilus_file_get_file_type): Turn into a method. * libnautilus-extensions/nautilus-merged-directory.h: * libnautilus-extensions/nautilus-merged-directory.c: (merged_call_when_ready): Rolled in the old merged_callback_connect_directory function. (merged_contains_file): Moved down to a more appropriate part of the source file. (nautilus_merged_directory_get_real_directories): New public function for use by trash. * libnautilus-extensions/nautilus-trash-file.c: (trash_callback_hash), (trash_callback_equal), (trash_callback_destroy), (trash_callback_check_done), (trash_callback_remove_file), (ready_callback), (real_file_changed_callback), (monitor_add_file), (add_real_file), (trash_callback_remove_file_cover), (monitor_remove_file), (remove_real_file), (add_real_file_given_directory), (add_directory_callback), (remove_directory_callback), (trash_file_call_when_ready), (trash_file_cancel_call_when_ready), (trash_file_check_if_ready), (trash_file_monitor_add), (trash_file_monitor_remove), (trash_file_get_file_type), (trash_file_get_item_count), (trash_file_get_deep_counts), (trash_file_get_date), (remove_all_real_files), (nautilus_trash_file_initialize), (trash_destroy), (nautilus_trash_file_initialize_class): New code. First implementation of getting some attributes for the merged trash. Gets list of directories from the NautilusTrashDirectory object. The code in here is similar to the NautilusMergedDirectory class and at some point perhaps we can make the two share more. * libnautilus-extensions/nautilus-vfs-file.c: (vfs_file_get_file_type), (vfs_file_get_date), (nautilus_vfs_file_initialize_class): Implement the two new methods for the standard vfs case. Fixed various things that affect the properties window for the trash that showed up while I was testing the above work: * libnautilus-extensions/nautilus-icon-factory.c: (nautilus_icon_factory_get_icon_name_for_regular_file), (nautilus_icon_factory_get_icon_name_for_file): Move trash special case out so it doesn't matter what type the trash seems to be. The old code relied on trash not being a directory. * src/file-manager/fm-properties-window.c: (create_properties_window), (create_properties_window_callback), (cancel_create_properties_window_callback), (directory_view_destroyed_callback), (remove_pending_file): Rework code to fix problems where the timed wait or the signal handler wasn't properly cleaned up. Fixed remaining bit of bug 5631 (Tear-offs of right-click menus don't work.): * src/file-manager/nautilus-desktop-icon-view-ui.xml: Mark Disks right-click submenu so it won't get a tear-off item. Fixed bug 5650 (nautilus --quit fails to return to prompt sometimes): * src/nautilus-application.c: (nautilus_application_startup): Add special case so "nautilus --quit" doesn't hang waiting for a response from the (now quit) "server" instance of Nautilus. * src/nautilus-shell-interface.idl: Had to make the quit call no longer be "oneway" to get it to work right, otherwise the quit message could be lost when the sending application exited too fast. Fix bug 5675 (Nitpicks in new "could not be moved to new special location" dialog): * libnautilus-extensions/nautilus-file-operations.c: (handle_transfer_overwrite): Updated message wording as Eli (and Vera) suggest. Other changes: * libnautilus-extensions/nautilus-view-identifier.c: (get_lang_list): Fix comment and a small storage leak in the case where lang_with_locale is non-NULL but empty. * po/POTFILES.ignore: Obsolete file, no longer used. * src/file-manager/fm-desktop-icon-view.c: (update_home_link_and_delete_copies): Update comment to help translators understand better. * libnautilus-extensions/nautilus-directory-async.c: (directory_load_callback): Added a new assertion that could help in future gnome-vfs debugging. * libnautilus/nautilus-view-component.idl: Removed long-ago-fixed FIXME comment. * src/nautilus-window-manage-views.c: Tweak spacing.
* reviewed by: Pavel Cisler <pavel@eazel.com>Ramiro Estrugo2001-01-1821-437/+108
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Lots of bug fixes: 2848 - User level agnostic config settings have nowhere to live. 2654 - Need default values even for non user level preferences. 3414 - Show more preferences at higher user levels. 3415 - Make preference the same for all levels at which it is not visible 3416 - Make preference changes affect all levels at which they are visible 4357 - Web search URL setting should be reset upon Nautilus update 5160 - Tree view doesnt exist when starting nautilus as a beginner 5234 - Sidebar panel preferences are not properly separated among user levels * components/mozilla/mozilla-preferences.cpp: Update for gnome vfs proxy changes. Proxy host and port are now stored in separate gconf settings. * libnautilus-extensions/Makefile.am: * libnautilus-extensions/nautilus-enumeration.h: * libnautilus-extensions/nautilus-enumeration.c: (nautilus_enumeration_new), (nautilus_enumeration_free), (nautilus_enumeration_insert), (nautilus_enumeration_get_nth_entry), (nautilus_enumeration_get_nth_description), (nautilus_enumeration_get_nth_value), (nautilus_enumeration_get_num_entries), (nautilus_self_check_enumeration): New files. An enumeration data structure. * components/tree/nautilus-tree-expansion-state.c: No longer need to give the full path to a gconf setting. * components/tree/nautilus-tree-view.c: (filtering_changed_callback), (nautilus_tree_view_initialize): * libnautilus-extensions/nautilus-directory-async.c: (can_use_public_metafile), (get_filter_options_for_directory_count): * libnautilus-extensions/nautilus-file-operations.c: (confirm_empty_trash): * libnautilus-extensions/nautilus-file.c: (nautilus_file_should_get_top_left_text): * libnautilus-extensions/nautilus-font-factory.c: (nautilus_font_factory_get_font_from_preferences): Update for preferences api changes. * libnautilus-extensions/nautilus-gconf-extensions.h: * libnautilus-extensions/nautilus-gconf-extensions.c: (global_client_free), (nautilus_gconf_client_get_global), (nautilus_gconf_handle_error), (nautilus_gconf_set_boolean), (nautilus_gconf_get_boolean), (nautilus_gconf_set_int), (nautilus_gconf_get_int), (nautilus_gconf_set_string), (nautilus_gconf_get_string), (nautilus_gconf_set_string_list), (nautilus_gconf_get_string_list), (nautilus_gconf_is_default), (nautilus_gconf_monitor_directory): New files. Useful gconf extensions; make peeking and poking settings a little easier. * libnautilus-extensions/nautilus-icon-container.c: (button_press_event): * libnautilus-extensions/nautilus-icon-canvas-item.c: (in_single_click_mode): Update for preferences api changes. * libnautilus-extensions/nautilus-icon-factory.c: (icon_theme_changed_callback), (should_display_image_file_as_itself): Update for preferences api changes. Also no longer need to define a default theme. * libnautilus-extensions/nautilus-lib-self-check-functions.h: Add entries for enumeration and preferences. Remove preference entry. Note plural vs not. * libnautilus-extensions/nautilus-preference.c: * libnautilus-extensions/nautilus-preference.h: Retire these 2. No longer use a GtkObject to store each preference. We simply use the string name instead. * libnautilus-extensions/nautilus-preferences-box.h: * libnautilus-extensions/nautilus-preferences-box.c: (nautilus_preferences_box_add_pane), (nautilus_preferences_box_update): New function. Should be called when user level changes so that the box updates its panes. * libnautilus-extensions/nautilus-preferences-dialog.h: * libnautilus-extensions/nautilus-preferences-dialog.c: (nautilus_preferences_dialog_initialize), (nautilus_preferences_dialog_destroy), (nautilus_preferences_dialog_get_prefs_box), (nautilus_preferences_dialog_update), (user_level_changed_callback): Keep track of user level changes. New function to update the dialog when user level changes. * libnautilus-extensions/nautilus-preferences-group.h: * libnautilus-extensions/nautilus-preferences-group.c: (nautilus_preferences_group_initialize), (nautilus_preferences_group_destroy), (nautilus_preferences_group_add_item): Collect the group's items in a list. Update to user a string to represent a preference instead of a GtkObject. (nautilus_preferences_group_update): New function. Updates the group's items to respect preferences visibility based on the user level. (nautilus_preferences_get_num_visible_items): New function. Return the number of currently visible items. Collect the group's items in a list. Update to user a string to represent a preference instead of a GtkObject. * libnautilus-extensions/nautilus-preferences-item.h: * libnautilus-extensions/nautilus-preferences-item.c: (preferences_item_construct), (preferences_item_create_enum), (preferences_item_create_short_enum), (preferences_item_create_boolean), (preferences_item_create_editable_string), (preferences_item_create_integer), (preferences_item_create_font_family), (preferences_item_create_theme), (enum_radio_group_changed_callback), (editable_string_changed_callback), (integer_changed_callback), (nautilus_preferences_item_get_name): New function to fetch the item's preference name. Add a new kind of preference - INTEGER. Update for string vs. GtkObject preferences representation changes. * libnautilus-extensions/nautilus-preferences-pane.h: * libnautilus-extensions/nautilus-preferences-pane.c: (nautilus_preferences_pane_update): New function. Updates the pane's groups to respect preferences visibility based on the user level. * libnautilus-extensions/nautilus-preferences.h: * libnautilus-extensions/nautilus-preferences.c: (preferences_get_path), (preferences_get_defaults_path), (preferences_get_visibility_path), (preferences_get_user_level_key), (preferences_preference_is_internal), (preferences_preference_is_user_level), (preferences_key_make), (preferences_key_make_for_default), (preferences_key_make_for_default_getter), (preferences_key_make_for_visibility), (preferences_global_client_remove_notification), (preferences_global_client_get), (preferences_preference_is_default), (preferences_make_user_level_filtered_key), (nautilus_preferences_get_visible_user_level), (nautilus_preferences_set_visible_user_level), (nautilus_preferences_set_boolean), (preferences_key_make_for_getter), (nautilus_preferences_get_boolean), (nautilus_preferences_set_int), (nautilus_preferences_get_int), (nautilus_preferences_set), (nautilus_preferences_get), (nautilus_preferences_set_string_list), (nautilus_preferences_get_string_list), (nautilus_preferences_get_user_level), (nautilus_preferences_set_user_level), (nautilus_preferences_default_set_int), (nautilus_preferences_default_get_int), (nautilus_preferences_default_set_boolean), (nautilus_preferences_default_get_boolean), (nautilus_preferences_default_set_string), (nautilus_preferences_default_get_string), (nautilus_preferences_default_set_string_list), (nautilus_preferences_default_get_string_list), (preferences_callback_entry_invoke_function), (preferences_something_changed_notice), (preferences_global_table_check_changes_function), (preferences_user_level_changed_notice), (preferences_entry_add_callback), (preferences_entry_remove_callback), (preferences_callback_entry_free), (preferences_callback_entry_free_func), (preferences_entry_free), (preferences_entry_free_func), (preferences_global_table_free), (preferences_global_table_get_global), (preferences_global_table_lookup), (preferences_global_table_insert), (preferences_global_table_lookup_or_insert), (nautilus_preferences_add_callback), (preferences_while_alive_disconnector), (nautilus_preferences_add_callback_while_alive), (nautilus_preferences_remove_callback), (nautilus_preferences_enumeration_insert), (nautilus_preferences_enumeration_get_nth_entry), (nautilus_preferences_enumeration_get_nth_description), (nautilus_preferences_enumeration_get_nth_value), (nautilus_preferences_enumeration_get_num_entries), (nautilus_preferences_set_description), (nautilus_preferences_get_description), (nautilus_preferences_get_user_level_name_for_display), (nautilus_preferences_get_user_level_name_for_storage), (preferences_user_level_check_range), (nautilus_preferences_monitor_directory), (nautilus_preferences_is_visible), (nautilus_self_check_preferences): Many changes. Redid to support the preferences system described in bugs 3414, 3415 and 3416. * libnautilus-extensions/nautilus-smooth-widget.c: (preferences_get_is_smooth): * libnautilus-extensions/nautilus-sound.c: (kill_sound_if_necessary), (nautilus_sound_initialize), (nautilus_sound_kill_sound), (nautilus_sound_register_sound), (nautilus_sound_can_play_sound): * libnautilus-extensions/nautilus-theme.c: (nautilus_theme_get_theme), (nautilus_theme_get_theme_data), (nautilus_theme_get_image_path): Update for preferences api changes. * libnautilus-extensions/nautilus-user-level-manager.c: * libnautilus-extensions/nautilus-user-level-manager.h: Retire. No longer needed. User level things are handled in nautilus-preferences.[ch] now. The current user level design is much simpler and does no require its own GtkObject. * src/file-manager/fm-desktop-icon-view.c: (update_home_link_and_delete_copies), (real_update_menus): * src/file-manager/fm-directory-view.c: (open_location), (confirm_delete_from_trash), (real_update_menus), (fm_directory_view_activate_files), (filtering_changed_callback): * src/file-manager/fm-icon-text-window.c: (changed_attributes_option_menu_callback), (fm_get_text_attribute_names_preference_or_default): * src/file-manager/fm-icon-view.c: (should_preview_sound), (fm_icon_view_update_click_mode), (fm_icon_view_update_smooth_graphics_mode): * src/file-manager/fm-list-view.c: (fm_list_view_update_click_mode): * src/file-manager/fm-properties-window.c: (create_permissions_page): * src/nautilus-application.c: (desktop_changed_callback): * src/nautilus-complex-search-bar.c: (nautilus_complex_search_bar_get_location): * src/nautilus-first-time-druid.c: (user_level_selection_changed), (make_hbox_user_level_radio_button), (set_up_user_level_page): * src/nautilus-main.c: (main): * src/nautilus-property-browser.c: (nautilus_property_browser_update_contents): * src/nautilus-sidebar.c: (nautilus_sidebar_sidebar_panel_enabled), (toggle_sidebar_panel), (nautilus_sidebar_size_allocate): * src/nautilus-switchable-search-bar.c: (nautilus_switchable_search_bar_new), (nautilus_search_uri_to_search_bar_mode): Update for preferences api changes. * src/nautilus-window-manage-views.c: (position_and_show_window_callback), (nautilus_window_end_location_change_callback): Update for preferences api changes. Also, no longer need to pass in a default location to the preferences getter. * src/nautilus-window-menus.c: (user_level_customize_callback), (switch_to_user_level), (refresh_bookmarks_menu), (user_level_changed_callback), (add_user_level_menu_item), (nautilus_window_initialize_menus), (update_user_level_menu_items), (convert_user_level_to_path): A lot of simplification. The "Edit Settings..." menu item no longer changes it wording based on the user level. We know allow it to edit settings on all user levels, since we have the ability to hide preferences at higher user levels. No longer need to update the preferences dialog or its title. * src/nautilus-window.c: (nautilus_window_constructed), (nautilus_window_close), (nautilus_window_go_web_search), (nautilus_window_go_home), (nautilus_window_show): Update for preferences api changes. * libnautilus-extensions/nautilus-global-preferences.h: Update all the preferences defines to not include a full gconf path. We dont need to do this anymore to get non user level coupled prefernces. * libnautilus-extensions/nautilus-global-preferences.c: (compare_view_identifiers), (global_preferences_create_dialog), (nautilus_global_preferences_get_enabled_sidebar_panel_view_identif iers), (global_preferences_install_sidebar_panel_defaults), (global_preferences_is_sidebar_panel_enabled), (global_preferences_install_speed_tradeoff_descriptions), (register_proxy_preferences), (global_preferences_register), (global_preferences_install_defaults), (nautilus_global_preferences_set_dialog_title): Lots of changes to support new preferences design. Set the WM_CLASS here once instead of everytime the dialog title is changed. This was causing criticals. No longer need to create parallel proxy preferences and map them to the gconf ones. We can use the gconf ones directly now. * test/.cvsignore: * test/Makefile.am: * test/test-nautilus-preferences-change.c: (user_level_changed_callback), (fruits_changed_callback), (int_picker_changed_callback), (user_level_picker_changed_callback), (picker_new), (user_level_picker_new), (main): * test/test-nautilus-preferences-display.c: (text_caption_update), (user_level_caption_update), (user_level_changed_callback), (green_changed_callback), (yellow_changed_callback), (red_changed_callback), (apple_changed_callback), (orange_changed_callback), (pear_changed_callback), (entry_new), (user_level_frame_new), (colors_frame_new), (fruits_frame_new), (main): * test/test.c: (test_pixbuf_draw_rectangle_tiled), (test_text_caption_set_text_for_int_preferences), (test_text_caption_set_text_for_string_preferences), (test_text_caption_set_text_for_default_int_preferences), (test_text_caption_set_text_for_default_string_preferences), (test_text_caption_get_text_as_int), (test_window_set_title_with_pid): * test/test.h: New tests for preferences changes. * test/test-nautilus-preferences.c: Retire old prefs test which didnt really work. * test/test-nautilus-smooth-graphics.c: (smooth_graphics_mode_changed_callback), (main): Update for preferences api changes.
* changed the throbber component to use the new translated oaf file scheme.Andy Hertzfeld2001-01-181-1/+1
| | | | | | | | | | | | | | | | | | changed the throbber component to use the new translated oaf file scheme. The throbber still doesn't show up, due to recent bonobo changes, which I'm looking into further. * components/throbber/.cvsignore: cvs should ignore the translated oaf file * components/throbber/Makefile.am: change use of oaf files * components/throbber/Nautilus_Control_throbber.oaf.in: added new style oaf file\ * components/throbber/nautilus-throbber.oafinfo: removed the old file * src/nautilus-window-toolbars.c: (nautilus_window_initialize_toolbars): more descriptive message when we get an exception
* Make changes necessary because of the slight change in theRebecca Schulman2001-01-181-4/+5
| | | | | | | | | | | | | 2001-01-17 Rebecca Schulman <rebecka@eazel.com> * src/file-manager/nautilus-indexing-info.c: (update_file_index_callback), (show_indexing_info_dialog): Make changes necessary because of the slight change in the medusa_indexing_service api, and change "hide when closed" on the index status dialig to TRUE. We still need to free the dialog when we exit nautilus (Added a fixme) but setting this value to false caused us to reference the freed dialog.
* reviewed by: John Sullivan <sullivan@eazel.com>Rebecca Schulman2001-01-172-4/+1
| | | | | | | | | | | | | | | | | | | | 2001-01-17 Rebecca Schulman <rebecka@eazel.com> reviewed by: John Sullivan <sullivan@eazel.com> * src/nautilus-complex-search-bar.c: (nautilus_complex_search_bar_initialize): Remove some spacing settings that caused the "More Options", "Fewer Options" and "Find Them" buttons in the search bar too have way too much space beneath them, fixing bug 4917 * src/nautilus-window-private.h: Up the minimum width of nautilus so that the search controls are always still readable (from 450 to 480). However, this does not guarantee that on all configurations you wil be able to see the controls, but it should for the default case.
* this is actually Darin's change, checked in by Andy, that's a better fixAndy Hertzfeld2001-01-171-10/+27
| | | | | | | | | | | * src/nautilus-window-manage-views.c: (unref_callback), (ref_now_unref_at_idle_time), (location_has_really_changed), (load_underway_callback): this is actually Darin's change, checked in by Andy, that's a better fix for bug 5657, the "destroying components messes up idle routines" crash. Instead of deferring the window state change to idle time, it does an extra ref of the view and unrefs it when idle rolls around.
* Fix 5188: Duplicate in list view -> Nautilus crashes.Pavel Cisler2001-01-171-1/+2
| | | | | | | | | | 2001-01-17 Pavel Cisler <pavel@eazel.com> Fix 5188: Duplicate in list view -> Nautilus crashes. * src/file-manager/fm-directory-view.c: (fm_directory_view_duplicate_selection): It was really only an inaccurate assert.
* Fix 5511: Dropping a file in same folder asks about replacing it. FixPavel Cisler2001-01-171-3/+8
| | | | | | | | | | | | | | | 2001-01-16 Pavel Cisler <pavel@eazel.com> Fix 5511: Dropping a file in same folder asks about replacing it. Fix 5606: Left drag into window where file exists deletes file. * src/file-manager/fm-list-view.c: (fm_list_receive_dropped_icons): During a file move, add a check to see if the dragged items are in the target directory. * libnautilus-extensions/nautilus-list.c: (nautilus_list_get_drop_action): Tiny tweak.
* fixed bug 5572, black rectangle left behind after clicking on an emblem inAndy Hertzfeld2001-01-172-7/+48
| | | | | | | | | | | | | | | | | | | | | | * src/file-manager/fm-properties-window.c: (property_button_focused_out), (create_emblems_page): fixed bug 5572, black rectangle left behind after clicking on an emblem in Properties window, by attaching to the focus_out signal and redrawing * src/nautilus-property-browser.c: (nautilus_property_browser_initialize), (nautilus_property_browser_destroy), (nautilus_property_browser_theme_changed), (nautilus_property_browser_smooth_graphics_changed): fixed some of bug 5614, label text in property browser is corrupted when smooth text option changed, by monitoring the smooth_graphics preference and updating when it changes. The rest of this bug will be fixed when Ramiro fixes the nautilus_label geometry problems as part of bug 5607 * components/text/nautilus-text-view.c: (file_read_callback): corrected the name of the "file too big to load" dialog
* reviewed by: Pavel Cisler <pavel@eazel.com>John Sullivan2001-01-161-194/+146
| | | | | | | | | | | | | | | | | | | | | | | | | | | | More work on bug 2146 (Properties window for desktop Trash icon should show Trash properties). Mostly this was clean-up of the properties window code to make future changes easier. The only substantive change is to remove the "Type" field for the trash. * src/file-manager/fm-properties-window.c: Removed enums for basic page and permissions page row numbers. The rows are now added (and table sized) as needed. (append_row): New helper function, appends one row to a GtkTable and returns the index of the new last row. (append_title_field): New function, like attach_title_field but appends row instead of taking a row parameter. (append_separator), (append_directory_contents_fields), (append_title_value_pair), (append_special_execution_checkbox), (append_special_execution_flags): Renamed from attach_xxx, now append a row instead of taking a row parameter. (create_page_with_table_in_vbox): Now returns GtkTable * instead of GtkWidget *, for callers' convenience. (get_adjusted_permissions_row): Removed this somewhat hacky function. (should_show_file_type): New function, returns FALSE for special trash location but TRUE for everything else. (create_basic_page): Check should_show_file_type; use new append_xxx calls instead of using predefined row numbers. (create_permissions_page): use new append_xxx calls instead of using predefined row numbers.
* Make the new services icon use big_services_icon.png. This is a muchJosh Barrow2001-01-161-1/+1
| | | | | | | | 2001-01-16 Josh Barrow <josh@eazel.com> * src/nautilus-first-time-druid.c: (druid_finished): Make the new services icon use big_services_icon.png. This is a much better choice until we get something official.
* Checked in broken code before. Doh!Gene Z. Ragan2001-01-161-1/+1
| | | | | | | | | 2001-01-16 Gene Z. Ragan <gzr@eazel.com> Checked in broken code before. Doh! * libnautilus-extensions/nautilus-link.c: * src/nautilus-first-time-druid.c: (druid_finished):
* reviewed by: Mike Fleming <mfleming@eazel.com>Gene Z. Ragan2001-01-161-1/+10
| | | | | | | | | | | | | | | 2001-01-16 Gene Z. Ragan <gzr@eazel.com> reviewed by: Mike Fleming <mfleming@eazel.com> Fixed bug 4358, Please put a services icon on the desktop * libnautilus-extensions/nautilus-link.c: (nautilus_link_local_create): Perform NULL checking on arguments * src/nautilus-first-time-druid.c: (druid_finished): Create a link to services on the desktop.
* reviewed by: Gene Z. Ragan <gzr@eazel.com>John Sullivan2001-01-164-15/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removed stuff I added earlier as part of a failed fix for bug 2068, which I ended up fixing a different way. Fixed bug 5661 (Hardwired button sizes for custom icons in properties window) Fixed bug 1682 ("Go There" button taller than others in "Open with Other" dialog) * libnautilus-extensions/nautilus-scrolled-window.h: * libnautilus-extensions/nautilus-scrolled-window.c: Removed these files from cvs. * libnautilus-extensions/Makefile.am: Removed the removed files from the build. * libnautilus-extensions/nautilus-metadata.h: removed NAUTILUS_METADATA_KEY_ICON_VIEW_SCROLL_ORIGIN * src/file-manager/fm-directory-view.h: * src/file-manager/fm-directory-view.c: (fm_directory_view_initialize): Changed back to inheriting from GtkScrolledWindow instead of now non-existent NautilusScrolledWindow. * libnautilus-extensions/nautilus-gtk-extensions.h: * libnautilus-extensions/nautilus-gtk-extensions.c: (nautilus_gtk_button_set_standard_padding): New function, wrapper for nautilus_gtk_button_set_padding that uses a standard amount of padding instead of taking a parameter. This is preferred so we can change a single number if we change our minds about what the standard padding should be. * libnautilus-extensions/nautilus-program-chooser.c: (nautilus_program_chooser_new): Use nautilus_gtk_button_set_standard_padding. Also added a vbox so that "Go There" button doesn't grow taller to match the height of the adjacent text. This fixed bug 1682. * src/nautilus-bookmarks-window.c: (create_bookmarks_window): Use nautilus_gtk_button_set_standard_padding. * src/file-manager/fm-properties-window.c: (create_basic_page): Use nautilus_gtk_button_set_standard_padding instead of hardwiring button sizes. This fixed bug 5661.
* fixed bug 5657, crash during menu update when switching views. This isAndy Hertzfeld2001-01-166-17/+196
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * src/nautilus-window-manage-views.c: (change_state_at_idle), (load_underway_callback): fixed bug 5657, crash during menu update when switching views. This is also behind several other reported bugs. Fixed it as Darin suggested, which is to defer the window state change associated with loading a new component until idle time, so it doesn't wreak havoc by interrupting other idle routines. * components/throbber/nautilus-throbber.c: (nautilus_throbber_initialize_class), (get_bonobo_properties), (set_bonobo_properties), (nautilus_throbber_destroy), (nautilus_throbber_initialize), (nautilus_throbber_button_press_event): added a location property and made it issue a notification when the throbber is clicked on. Also, removed the no longer used "location_changed" signal and better memory management of the property bag. * src/nautilus-window.c: (throbber_location_changed_callback), (nautilus_window_constructed), (nautilus_window_destroy): make clicking on the throbber work by adding a listener for the throbber location property and changing the location accordingly when the event is posted. Also, fixed a leak of the bonobo object. * src/nautilus-window-private.h: added a field to hold the event source listener ID.
* fixed bug 4369, throbber frozen during long refresh, by making theAndy Hertzfeld2001-01-1610-88/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixed bug 4369, throbber frozen during long refresh, by making the throbber a bonobo component so it's driven by its own thread. Note that clicking on the throbber is temporarily broken; I'll fix that soon. Also, made the frame delay be specified by the theme and set the default to spin somewhat slower than before. * configure.in: * components/Makefile.am: * components/throbber/.cvsignore: * components/throbber/Makefile.am: * components/throbber/nautilus-throbber.oafinfo: added throbber component * components/throbber/main.c: (throbber_object_destroyed), (throbber_make_object), (main): factory for the throbber component * components/throbber/nautilus-throbber.c,h: (nautilus_throbber_initialize_class), (is_throbbing), (get_bonobo_properties), (set_bonobo_properties), (nautilus_throbber_destroy), (nautilus_throbber_get_control), (get_throbber_dimensions), (nautilus_throbber_initialize), (nautilus_throbber_new), (nautilus_throbber_theme_changed), (draw_pixbuf), (select_throbber_image), (draw_throbber_image), (nautilus_throbber_draw), (nautilus_throbber_expose), (nautilus_throbber_map), (bump_throbber_frame), (nautilus_throbber_start), (nautilus_throbber_remove_update_callback), (nautilus_throbber_stop), (nautilus_throbber_unload_images), (load_themed_image), (make_throbber_frame_name), (nautilus_throbber_load_images), (nautilus_throbber_button_press_event), (nautilus_throbber_set_small_mode), (nautilus_throbber_size_allocate), (nautilus_throbber_size_request): throbber widget for the bonobo component * src/nautilus-window-toolbars.c: (theme_changed_callback), (nautilus_window_initialize_toolbars): set up throbber component in the toolbar * src/nautilus-window.c,h: (nautilus_window_constructed), (nautilus_window_allow_stop): use property interface to start and stop the throbber * icons/default.xml: added delay specification to throbber in default theme * nautilus-clean.sh: clean throbber component as necessary * src/Makefile.am: * src/nautilus-throbber.c,h removed old throbber widget
* added two FIXMEs to this file I checked in moments ago.John Sullivan2001-01-161-0/+6
|
* reviewed by: Darin Adler <darin@eazel.com>John Sullivan2001-01-162-54/+169
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some work on bug 2146 (Properties window for desktop Trash icon should show Trash properties) * src/file-manager/fm-properties-window.c: (is_merged_trash_directory): New helper function, checks whether window is displaying special trash location. (should_show_custom_icon_buttons): New helper function, returns FALSE for special trash location since custom icons don't work with the trash (see bug 5642) (should_show_mime_type): New helper function, extracted for code clarity (returns FALSE for directories). (create_basic_page): Now takes only one parameter, gets file and notebook from details struct; uses should_show_mime_type and should_show_custom_icon_buttons. (create_emblems_page), (create_permissions_page): Now take only one parameter, get file and notebook from details struct. (should_show_emblems): New helper function, returns FALSE for special trash location since emblems don't work with the trash (see bug 5643) (should_show_permissions): New helper function, returns FALSE for special trash location since it's not really a file system object for which permissions make sense. (create_properties_window): Respect should_show_emblems and should_show_permissions. Eli ran into a case where the "can't set permissions" error message was the vague default case when the disk was locked. I added that case to the set of specifically handled cases. * src/file-manager/fm-error-reporting.c: (fm_report_error_renaming_file), (fm_report_error_setting_group), (fm_report_error_setting_owner), (fm_report_error_setting_permissions): Handle GNOME_VFS_ERROR_READ_ONLY_FILE_SYSTEM cases.
* Fix bug 5557 (Intermittent crash inDarin Adler2001-01-157-11/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nautilus_View_history_changed): * src/nautilus-view-frame.c: (send_history): Added a check for NULL so we don't try to send a NULL history list through the history machinery. Fix bug 5360 ("menthos's Home" string is hard to translate): * src/file-manager/fm-desktop-icon-view.c: (update_home_link_and_delete_copies): Added comment to help translators understand what to do with "%s's Home". Fix bug 5641 ("xfree" does not work with newer versions of RPM 4 headers): * components/services/install/lib/eazel-package-system-rpm3.c: (eazel_package_system_rpm3_packagedata_fill_from_header): Just use "free" instead of "xfree". Fix bug 5631 (Tear-offs of right-click menus don't work): * src/nautilus-shell-ui.xml: * src/file-manager/nautilus-directory-view-ui.xml: * src/file-manager/nautilus-icon-view-ui.xml: Mark popups and submenus of the popups with tearoff="0" so they don't have tear-off menu items. More work on bug 2147 (NautilusFile for trash needs non-empty values for more properties). * libnautilus-extensions/nautilus-file.h: * libnautilus-extensions/nautilus-file.c: (nautilus_file_new_from_relative_uri), (nautilus_file_new_from_info), (nautilus_file_monitor_add), (nautilus_file_monitor_remove), (nautilus_file_get_directory_item_count), (nautilus_file_get_deep_counts), (nautilus_file_check_if_ready), (nautilus_file_call_when_ready), (nautilus_file_cancel_call_when_ready): Put more of the machinery in place to make enough of NautilusFile virtual so that we can implement the trash case. * libnautilus-extensions/nautilus-merged-directory.h: * libnautilus-extensions/nautilus-merged-directory.c: (merged_add_real_directory), (nautilus_merged_directory_add_real_directory), (merged_remove_real_directory), (nautilus_merged_directory_remove_real_directory), (remove_all_real_directories), (nautilus_merged_directory_initialize_class): Make adding and removing directories use signals so we can share this list with the NautilusTrashFile. * libnautilus-extensions/nautilus-trash-file.c: (add_directory_callback), (remove_directory_callback), (nautilus_trash_file_initialize), (trash_destroy): Use a NautilusTrashDirectory object for the list of directories. * libnautilus-extensions/nautilus-vfs-file.c: (vfs_file_monitor_add), (vfs_file_monitor_remove), (vfs_file_call_when_ready), (vfs_file_cancel_call_when_ready), (vfs_file_check_if_ready), (vfs_file_get_item_count), (vfs_file_get_deep_counts), (nautilus_vfs_file_initialize_class): Move the guts of these functions into the "VFS" subclass. Other stuff: * libnautilus-extensions/nautilus-trash-directory.c: (find_directory_start), (find_directory_end), (find_directory_callback), (add_volume), (remove_trash_volume): Fix bug in the recently-added timed-wait, to handle the case where the call is cancelled as well as the case where it succeeds or fails. * src/file-manager/fm-directory-view.c: (zoomable_set_zoom_level_callback): Formatting tweak. * src/nautilus-main.c: (main): Fix the FIXME.
* reviewed by: Michael Engber <engber@eazel.com>J Shane Culpepper2001-01-154-9/+6
| | | | | | | | | | | | | | | | 2001-01-15 J Shane Culpepper <pepper@eazel.com> reviewed by: Michael Engber <engber@eazel.com> * src/nautilus-application.c: (nautilus_application_startup): * src/nautilus-application.h: * src/nautilus-first-time-druid.c: (druid_finished): * src/nautilus-main.c: (main): Fix for bug #1555. There is already an error dialog but there was an infinite loop problem hiding it. If the first time druid failed to create .nautilus, etc it would just run over and over again.
* Fixed bug 5635, RPM view crashed if click "Install" after unmountingGene Z. Ragan2001-01-153-16/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-01-15 Gene Z. Ragan <gzr@eazel.com> Fixed bug 5635, RPM view crashed if click "Install" after unmounting volume containing RPM Fixed bug 5636, Unmounting a volume doesn't close it's associated windows. * src/nautilus-application.c: (nautilus_application_initialize), (volume_mounted_callback), (volume_unmounted_callback): Connect to volume monitor signals. When a volume is unmounted, examine open window list and close any windows that originate from the volume being unmounted. Add code to mount audio cds on desktop. It is all ifdefed out right now. * src/file-manager/fm-desktop-icon-view.c: (create_mount_link), (update_disks_menu): * libnautilus-extensions/nautilus-volume-monitor.c: (nautilus_volume_monitor_volume_is_removable), (nautilus_volume_monitor_get_removable_volumes), (nautilus_volume_monitor_get_target_uri), (mount_volume_get_cdda_name), (mount_volume_activate_cdda), (mount_volume_get_name), (mount_volume_activate), (get_current_mount_list), (mount_volumes_check_status), (mount_volume_cdda_add), (mount_volume_add_filesystem), (open_cdda_device), (locate_audio_cd): * libnautilus-extensions/nautilus-volume-monitor.h:
* Upped the timeout from 10 seconds to 12 seconds to be paranoid on reallyJ Shane Culpepper2001-01-151-1/+4
| | | | | | | | | | | | 2001-01-14 J Shane Culpepper <pepper@eazel.com> * src/nautilus-view-frame.c: (attach_client): Upped the timeout from 10 seconds to 12 seconds to be paranoid on really slow machines. I think this is really generous for bug #4757. In an attempt to reproduce the crash I started a build of mozilla and gcc "emulate" a slow machine since I don't have one. Adding additional comments to bugzilla bug #4757.
* Fixed bug 5414, Don't create a link for launchers dragged onto desktopGene Z. Ragan2001-01-141-6/+16
| | | | | | | | | | | 2001-01-13 Gene Z. Ragan <gzr@eazel.com> Fixed bug 5414, Don't create a link for launchers dragged onto desktop that require a terminal * src/file-manager/fm-desktop-icon-view.c: (create_link_callback), (icon_view_create_nautilus_links): Display a simple dialog telling user that we don't support htis feature yet.