summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* program-choosing: fix double-freeErnestas Kulik2017-08-091-2/+0
| | | | | | | | Fixes for https://bugzilla.gnome.org/show_bug.cgi?id=782109 introduced a regression in that the Wayland window handle export data is now being freed twice. This commit backports the fix for the regression. https://bugzilla.gnome.org/show_bug.cgi?id=786040
* rename-file-popover-controller: consume ctrl-zErnestas Kulik2017-08-081-22/+43
| | | | | | | | | Pressing ctrl-z while renaming a file results in undoing the last completed operation, which breaks expectations. This commit makes the key combination revert the text in the name entry to the display name of the target file. https://bugzilla.gnome.org/show_bug.cgi?id=686023
* list-view: fix regex unrefAlexandru Pandelea2017-08-081-2/+2
| | | | | | | Unref the regex before the free of the details, as after that the regex is no longer accessible. https://bugzilla.gnome.org/show_bug.cgi?id=785959
* list-view: display snippet next to filenameAlexandru Pandelea2017-08-081-1/+4
| | | | | | | Instead of showing the snippet under the filename, show it next to the filename. https://bugzilla.gnome.org/show_bug.cgi?id=785959
* list-view: fix snippet newline removalAlexandru Pandelea2017-08-082-1/+14
| | | | | | | | | Removing only \n from the snippet is not enough, as there are also other newline characters. Use a GRegex to match those new line chars and remove them. https://bugzilla.gnome.org/show_bug.cgi?id=785959
* window: Add tablet pad controller for common actionsCarlos Garnacho2017-08-071-0/+19
| | | | | | | | | | | | | | | | | Since nautilus is an important tool in the workflow of designers and other users of graphics tablets, make tablet pads useful by mapping a sensible set of actions that are not directly accessible with the stylus nor immediately require keyboard input. Tablet pads may vary a lot between devices, from 4 to 10+ buttons, besides rings/strips and multiple modes. It doesn't make a lot of sense for nautilus to handle those in detail, so this patch provides a mile-high support that should work reasonably well across the range of devices. Actions are made to apply on all modes, and the most sensible/less reachable options are assigned to lower button numbers. https://bugzilla.gnome.org/show_bug.cgi?id=785443
* shell-search-provider: Only use location in descriptionFlorian Müllner2017-08-071-2/+4
| | | | | | | | | | | | | The filename is likely to match the display name, which is already prominently used as the result name, so including it in the description doesn't add any information. In fact, as gnome-shell is about to display name and description on a single line[0], duplicating the filename increases the chances of less information being displayed due to ellipsization. [0] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/shell/search/search-list-layout.png https://bugzilla.gnome.org/show_bug.cgi?id=784105
* files-view: fix adding files to the viewAlexandru Pandelea2017-08-071-6/+6
| | | | | | | | | | | | Searching makes Nautilus have no files in the view sometimes, even if there are search results, because the view connects to the files-added signal after it added a monitor to the directory and the signal might be emitted before connecting to it. To fix this, first connect to the files-added and files-changed signals, before adding the monitor to the directory. https://bugzilla.gnome.org/show_bug.cgi?id=785722
* window-slot: check location before constructing tab restore dataErnestas Kulik2017-08-072-1/+9
| | | | | | | | Assuming that the location cannot be null can leads to crashes in cases when the user is trying to open non-existent locations, e.g. broken bookmarks. https://bugzilla.gnome.org/show_bug.cgi?id=785317
* file: clear info before removing from directoryErnestas Kulik2017-08-071-2/+5
| | | | | | | | When marking the file as gone, clearing its file info after removing it from the parent directory will result in a crash in cases where it is the last reference being dropped. https://bugzilla.gnome.org/show_bug.cgi?id=785562
* window: change license to GPLv3+ in the about dialogErnestas Kulik2017-08-071-1/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=785062
* Fixed typoMarek Cernocky2017-08-031-1/+1
|
* directory: Remove unused nautilus_directory_is_remote()Bastien Nocera2017-07-182-16/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=784941
* files-view: Allow decompressing remote archivesBastien Nocera2017-07-181-5/+0
| | | | | | | | There's no reason for archives on, say, SMB remote shares couldn't be decompressed through the "Extract Here" functionality, so remove the remote files check. https://bugzilla.gnome.org/show_bug.cgi?id=784941
* build: Make tracker a hard dependencyBastien Nocera2017-07-186-47/+11
| | | | | | | | A large number of core features require Tracker to work, and many of the new features using Tracker don't have any fallback support, failing to build when Tracker is not available, so make tracker a hard requirement. https://bugzilla.gnome.org/show_bug.cgi?id=784940
* build: Fix tracker detectionBastien Nocera2017-07-181-2/+2
| | | | | | | Make sure that tracker-sparql is optional and auto-detected by default and that tracker-sparql-1.0 is still supported. https://bugzilla.gnome.org/show_bug.cgi?id=784940
* batch-rename: cancel metadata check when closing dialogErnestas Kulik2017-06-293-19/+36
| | | | | | | | Opening the batch rename dialog and immediately closing it results in a crash, due to the async operation not being canceled, thus resulting in invalid memory access on callback. https://bugzilla.gnome.org/show_bug.cgi?id=784336
* file: fix invalid memory accessAlexandru Pandelea2017-06-241-6/+2
| | | | | | | | | | When the operation is freed on the first if, the operation will still be accessed on the second if. To fix this, merge the two if's since they both complete the operation. https://bugzilla.gnome.org/show_bug.cgi?id=783873
* files-view: update vfunc commentErnestas Kulik2017-06-241-1/+1
| | | | | get_zoom_level_percentage() does not return a value in the specified range, as there are zoom levels beyond 100%.
* files-view: disable the reset zoom button by defaultDiana Grecu2017-06-245-1/+52
| | | | | | | | | The reset zoom button is sensitive even though the zoom percentage is already at 100%. Let the button be inactive if the zoom percentage is already at 100%. https://bugzilla.gnome.org/show_bug.cgi?id=771481
* clipboard: remove duplicate function declarationErnestas Kulik2017-06-241-2/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=781095
* files-view: disable create-link when the clipboard is emptyTiberiu Lepadatu2017-06-241-1/+2
| | | | | | | 'Create Link' button does nothing when the clipboard is empty. In order to fix that, disable the button when the clipboard is empty. https://bugzilla.gnome.org/show_bug.cgi?id=781095
* implement ftsAlexandru Pandelea2017-06-2215-13/+311
| | | | | | | | | | | | | | | The search text can now also match the contents of a file, besides the file name. This is done with the help of a Tracker query, using fts:match, which matces both the contents of a file and the filename. The user also has the option to choose whether to use or not the Full Text Search. This can be done with a preference, which represents the default option when opening a new tab/window or from the search popover. https://bugzilla.gnome.org/show_bug.cgi?id=775961
* pathbar: Handle middle click on button-press-eventElias Entrup2017-06-191-11/+16
| | | | | | | | | | | If "/org/gnome/desktop/wm/preferences/action-middle-click-titlebar" is set to "minimize", a click on the pathbar will open a new tab but also minimize the window. By handling the event already on the button press (not release), the window is not minimized anymore. https://bugzilla.gnome.org/show_bug.cgi?id=757439
* canvas-container: Cancel active rubberband if a new one is startedJason Gerecke2017-06-151-3/+19
| | | | | | | | | | | | | | | Wayland allows multiple pointers to be active at the same time, e.g. when a Wacom tablet and mouse are both connected to a system. This means that it is possible to recieve a "rubberband start" event from a second tool while a rubberband is already active. At the moment, this results in stray selection rectangles since the canvas does not properly perform cleanup. To prevent these graphical glitches from occuring, we can simply cancel any existing rubberband operation if a second one attempts to start. The only additional minor complication is ensuring that the new rubberband is not stopped when the first tool sends a button-up event. https://bugzilla.gnome.org/show_bug.cgi?id=783797
* canvas-container: Use rubberband coordinates from original deviceJason Gerecke2017-06-152-6/+6
| | | | | | | | | | | | | | | Nautilus assumes that the pointer returned by gdk_seat_get_pointer will return the same GdkDevice which started a rubberband action. This is not necessarily the case, however. Under Wayland, for example, tablet tools have pointers (and GdkDevice's) which are entirely separate from the seat's primary mouse-driven pointer. Attempting to use a pen to perform rubberband selection will result in the rectangle being drawn with the incorrect coordinates. This patch has the code store the GdkDevice which generated the event and provides it in place of the call to gdk_seat_get_pointer. https://bugzilla.gnome.org/show_bug.cgi?id=783797
* Revert "files-view: Add alternative shortcut for renaming files"Ernestas Kulik2017-06-132-8/+2
| | | | This reverts commit 3c00fa343ec5b642846bc4c280cec7bb18a299a3.
* fix misuse of nautilus_file_is_desktop_directoryAlexandru Pandelea2017-05-312-2/+6
| | | | | | | | | | | | | | | The issue is that when navigating into the Desktop directory, the slot is replaced with a desktop window slot. This happens because when checking if the current location is handled by the current slot, the check was made for the actual Desktop directory instead for the virtual Desktop. To fix this, instead of checking if the location matches the actual dir, check if it matches the right uri. A similar issue was in files-view when creating a new folder, so also change that accordingly. https://bugzilla.gnome.org/show_bug.cgi?id=771710
* nautilus-window: add wrapper for creating slotAlexandru Pandelea2017-05-311-8/+17
| | | | | | Always when creating a slot in NautilusWindow, it is also initialized, so create a wrapper which does both the creating and initializing. https://bugzilla.gnome.org/show_bug.cgi?id=561136
* add "restore tab" actionAlexandru Pandelea2017-05-314-1/+135
| | | | | | | | | | | Adds option to reopen closed tabs with Ctrl+Shift+T. In order to do so, keep a list with data needed to restore closed tabs. So, this list keeps the location bookmark, the view id before search, which is needed in case the closed tab was a search and the back/forward history. https://bugzilla.gnome.org/show_bug.cgi?id=561136
* file-operations: deduplicate codeErnestas Kulik2017-05-301-73/+35
| | | | | | | Some duplicate code can be removed by refactoring mark_desktop_file_executable(). https://bugzilla.gnome.org/show_bug.cgi?id=782658
* search-engine-tracker: don't use fts:match on empty search entryAlexandru Pandelea2017-05-161-2/+5
| | | | | | | | | | | If the search entry is empty and filtering for date or mime type is added, then the sparql query always returns nothing because of fts:match '""*' To get the expected search results don't use fts:match when the search text is empty. https://bugzilla.gnome.org/show_bug.cgi?id=782596
* file-operations: duplicate: use automatic cleanupErnestas Kulik2017-05-151-5/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=782650
* file-operations: set_permissions_recursive: use automatic cleanupErnestas Kulik2017-05-151-2/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=782650
* file-operations: empty_trash: use automatic cleanupErnestas Kulik2017-05-151-2/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=782650
* file-operations: mark_desktop_file_executable: use automatic cleanupErnestas Kulik2017-05-151-2/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=782650
* file-operations: delete: use automatic cleanupErnestas Kulik2017-05-151-8/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=782650
* file-operations: copy: use automatic cleanupErnestas Kulik2017-05-151-9/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=782650
* file-operations: move: use automatic cleanupErnestas Kulik2017-05-151-8/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=782650
* file-operations: link: use automatic cleanupErnestas Kulik2017-05-151-16/+7
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=782650
* file-operations: create: use automatic cleanupErnestas Kulik2017-05-151-39/+22
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=782650
* views: handle keyboard activation in files-viewErnestas Kulik2017-05-145-44/+9
| | | | | | | | | | Each view handles keyboard activation on its own by listening to key-press-event, yet there are actions in files-view that could handle it. This commit makes it so, additionally swapping the accelerators for opening in new tab and window to make things more consistent throughout the application (and others, too, e.g. Firefox). https://bugzilla.gnome.org/show_bug.cgi?id=782600
* mime-actions: check for valid error before dereferencingErnestas Kulik2017-05-131-1/+1
| | | | | | | After launching a URI, the code checks if the operation has been canceled, but does not check if the error pointer is valid. https://bugzilla.gnome.org/show_bug.cgi?id=781132
* batch-rename-dialog: fix grammar in translatable stringsPiotr Drąg2017-05-131-4/+4
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=782601
* batch-rename-dialog: mark strings as translatablePiotr Drąg2017-05-131-3/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=782601
* batch-rename: show error on empty nameDiana Grecu2017-05-131-1/+16
| | | | | | | | | | When the destination name is empty, the "Rename" button goes insensitive without explaining the user why it happened. To explain what happened show a descriptive message to inform the user. https://bugzilla.gnome.org/show_bug.cgi?id=772435
* mime-actions: launch default uri handlers when activating filesErnestas Kulik2017-05-133-221/+368
| | | | | | | | | Currently, Nautilus tries to find the default applications for files itself, which does not work well in a sandbox. This commit makes Nautilus blindly launch the default applications, which makes use of the documents portal indirectly. https://bugzilla.gnome.org/show_bug.cgi?id=781132
* program-choosing: reindent headerErnestas Kulik2017-05-131-25/+25
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=781132
* view-icon-controller: Fix double-freeCarlos Soriano2017-05-131-1/+1
| | | | We weren't taking a ref, but we were unrefing afterwards.
* preferences-window.ui: Use header barCarlos Soriano2017-05-111-853/+857
| | | | | So it's consistent with all the other dialogs. Also use a GtkDialog instead of a window.