From d11fc07a0b440be9c590152939b1edcb273d710b Mon Sep 17 00:00:00 2001 From: Ondrej Holy Date: Wed, 4 Nov 2020 09:24:08 +0100 Subject: batch-rename-utilities: Fix dialog crashes The batch rename dialog crashes when it is opened for a second time. This is because the TrackerSparqlConnection object is unreffed after the first use. However, nautilus_tracker_get_miner_fs_connection documentation clearly says that the returned should not be unreffed because it is globally shared singleton. Let's remove the problematic g_object_unref statement to fix the crashes. https://gitlab.gnome.org/GNOME/nautilus/-/issues/1651 --- src/nautilus-batch-rename-utilities.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/nautilus-batch-rename-utilities.c b/src/nautilus-batch-rename-utilities.c index 0412a172e..49b9813ed 100644 --- a/src/nautilus-batch-rename-utilities.c +++ b/src/nautilus-batch-rename-utilities.c @@ -1150,7 +1150,6 @@ check_metadata_for_selection (NautilusBatchRenameDialog *dialog, batch_rename_dialog_query_callback, query_data); - g_object_unref (connection); g_string_free (query, TRUE); } -- cgit v1.2.1