summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormvglasow <michael -at- vonglasow.com>2018-08-12 16:14:28 +0200
committermvglasow <michael -at- vonglasow.com>2018-08-12 16:14:28 +0200
commit14867ef76fe6be51872d8aa424bc47659a4e5089 (patch)
tree538d419778485d95e32223fee9156546471343e7
parenteab228569770c7ddb900f2f895fc44019ee662ed (diff)
downloadnavit-14867ef76fe6be51872d8aa424bc47659a4e5089.tar.gz
Refactor:traffic:Clean up FIXME/TODO comments
Signed-off-by: mvglasow <michael -at- vonglasow.com>
-rw-r--r--navit/traffic.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/navit/traffic.c b/navit/traffic.c
index 760faea52..0a42ca5bf 100644
--- a/navit/traffic.c
+++ b/navit/traffic.c
@@ -2239,7 +2239,6 @@ static int traffic_location_is_valid(struct traffic_location * this_) {
*
* @return `true` if the locations were matched successfully, `false` if there was a failure.
*/
-/* TODO process data->flags and data->dir */
static int traffic_message_add_segments(struct traffic_message * this_, struct mapset * ms, struct seg_data * data,
struct map *map, struct route * route) {
int i;
@@ -3053,7 +3052,6 @@ static struct seg_data * traffic_message_parse_events(struct traffic_message * t
}
for (j = 0; j < this_->events[i]->si_count; j++) {
- /* TODO derive flags (modes of transportation) from message */
switch (this_->events[i]->si[j]->type) {
case si_vehicle_all:
/* For all vehicles */
@@ -3540,9 +3538,7 @@ static int traffic_process_messages_int(struct traffic * this_, int flags) {
traffic_dump_messages_to_xml(this_);
}
- /* FIXME this is probably not thread-safe: if route calculation and traffic message processing
- * happen concurrently, changes introduced by the messages may not be considered.
- * Idle loops are not an issue as route_recalculate_partial() will abort if the route graph is busy. */
+ /* TODO see comment on route_recalculate_partial about thread-safety */
route_recalculate_partial(this_->rt);
/* trigger redraw if segments have changed */