diff options
| author | Niels Möller <nisse@lysator.liu.se> | 2018-12-26 11:04:31 +0100 |
|---|---|---|
| committer | Niels Möller <nisse@lysator.liu.se> | 2018-12-26 11:04:31 +0100 |
| commit | f5a3a224bf00bef5669366d2ae23c2b2b13b8016 (patch) | |
| tree | a10dca62cb3601b7605acd645fcdc76c374f698a | |
| parent | 4fc52f4de99b2d471ead06e4a5086b9b15b6dee3 (diff) | |
| download | nettle-f5a3a224bf00bef5669366d2ae23c2b2b13b8016.tar.gz | |
Fix accidental use of C99 for loop.
* rsa-sign-tr.c (sec_equal): Fix accidental use of C99 for loop.
Reported by Andreas Gustafsson.
* testsuite/rsa-sec-decrypt-test.c (test_main): Likewise.
| -rw-r--r-- | ChangeLog | 6 | ||||
| -rw-r--r-- | rsa-sign-tr.c | 3 | ||||
| -rw-r--r-- | testsuite/rsa-sec-decrypt-test.c | 3 |
3 files changed, 10 insertions, 2 deletions
@@ -1,3 +1,9 @@ +2018-12-26 Niels Möller <nisse@lysator.liu.se> + + * rsa-sign-tr.c (sec_equal): Fix accidental use of C99 for loop. + Reported by Andreas Gustafsson. + * testsuite/rsa-sec-decrypt-test.c (test_main): Likewise. + 2018-12-04 Niels Möller <nisse@lysator.liu.se> * Released nettle-3.4.1. diff --git a/rsa-sign-tr.c b/rsa-sign-tr.c index 59c9bd07..f824c4ca 100644 --- a/rsa-sign-tr.c +++ b/rsa-sign-tr.c @@ -239,8 +239,9 @@ static int sec_equal(const mp_limb_t *a, const mp_limb_t *b, size_t limbs) { volatile mp_limb_t z = 0; + size_t i; - for (size_t i = 0; i < limbs; i++) + for (i = 0; i < limbs; i++) { z |= (a[i] ^ b[i]); } diff --git a/testsuite/rsa-sec-decrypt-test.c b/testsuite/rsa-sec-decrypt-test.c index 64f0b13c..fb0ed3a1 100644 --- a/testsuite/rsa-sec-decrypt-test.c +++ b/testsuite/rsa-sec-decrypt-test.c @@ -68,6 +68,7 @@ test_main(void) unsigned n_size = 1024; mpz_t gibberish; mpz_t garbage; + size_t size; rsa_private_key_init(&key); rsa_public_key_init(&pub); @@ -78,7 +79,7 @@ test_main(void) memset(verifybad, 'A', PAYLOAD_SIZE); - for (size_t size = 1; size < 51; size++) + for (size = 1; size < 51; size++) { ASSERT (rsa_generate_keypair(&pub, &key, &random_ctx, (nettle_random_func *) knuth_lfib_random, |