diff options
author | Niels Möller <nisse@lysator.liu.se> | 2008-09-15 22:23:24 +0200 |
---|---|---|
committer | Niels Möller <nisse@lysator.liu.se> | 2008-09-15 22:23:24 +0200 |
commit | 7dcba661d62d9248ed7b892024a2442b0520016f (patch) | |
tree | 9834a084ec1a4595fd3dd3771162f0faf26f8c24 /bignum-random.c | |
parent | d4757ff06292c71af5ac56724b03af4126279a01 (diff) | |
download | nettle-7dcba661d62d9248ed7b892024a2442b0520016f.tar.gz |
Reviewed FIXME-comments.
Rev: nettle/aes-decrypt-internal.c:1.2
Rev: nettle/aes-encrypt-internal.c:1.2
Rev: nettle/aes-internal.h:1.2
Rev: nettle/arctwo.h:1.2
Rev: nettle/base16-decode.c:1.2
Rev: nettle/base16-encode.c:1.2
Rev: nettle/base16.h:1.2
Rev: nettle/base64.h:1.2
Rev: nettle/bignum-random.c:1.2
Rev: nettle/bignum.c:1.2
Rev: nettle/bignum.h:1.3
Rev: nettle/rsa-sign.c:1.3
Rev: nettle/rsa-verify.c:1.3
Rev: nettle/rsa.c:1.3
Rev: nettle/rsa.h:1.2
Rev: nettle/sexp-transport-format.c:1.2
Rev: nettle/sexp.c:1.2
Rev: nettle/sexp.h:1.2
Diffstat (limited to 'bignum-random.c')
-rw-r--r-- | bignum-random.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/bignum-random.c b/bignum-random.c index 16029216..6653dea3 100644 --- a/bignum-random.c +++ b/bignum-random.c @@ -57,8 +57,8 @@ nettle_mpz_random(mpz_t x, void *ctx, nettle_random_func random, const mpz_t n) { - /* FIXME: This leaves some bias, which may be bad for DSA. A better - * way might to generate a random number of mpz_sizeinbase(n, 2) + /* NOTE: This leaves some bias, which may be bad for DSA. A better + * way might be to generate a random number of mpz_sizeinbase(n, 2) * bits, and loop until one smaller than n is found. */ /* From Daniel Bleichenbacher (via coderpunks): |