delta/nfs-utils.git, branch libnfsdmap

nfs-utils: cleanup warnings from merged libnfsidmap code

2017-09-28T18:29:01+00:00

Clean up a bunch of warnings about unused parameters,
signedness differences, etc that we inherited from
the merged libnfsidmap code.

Signed-off-by: Justin Mitchell 
Signed-off-by: Steve Dickson

nfs-utils: integrate libnfsidmap code with rest of nfs-utils

2017-09-28T18:27:05+00:00

Modify libnfsidmap to use the now shared conffile code,
adjust the build structure to generate everything correctly,
and modify the other utils to use the merged version of libnfsidmap
instead of testing for an external dependancy.

Signed-off-by: Justin Mitchell 
Signed-off-by: Steve Dickson

nfs-utils: Import libnfsidmap codebase

2017-09-28T18:22:17+00:00

Merge the libnfsidmap code tree into nfs-utils.
These are the original unmodified files, cherry picked only the
necessary files that dont duplicate code, so will not build
correctly at this stage.

Signed-off-by: Justin Mitchell 
Signed-off-by: Steve Dickson

nfs-utils: split conffile to a separate convenience lib

2017-09-28T18:18:35+00:00

To allow better reuse of the code we split conffile and xlog
into their own separate convenience library, then merge it
back so as to not create extra dependancies for everything

Signed-off-by: Justin Mitchell 
Signed-off-by: Steve Dickson

conffile: Add get_str with default value

2017-09-28T18:09:10+00:00

The similar config code in libnfsidmap had one additional feature of
a get_str function with a default value option, include an equivalent
function here to maintain compatibility.

Signed-off-by: Justin Mitchell 
Signed-off-by: Steve Dickson

conffile: Merge conf_get_str and conf_get_section

2017-09-28T18:06:29+00:00

conf_get_section() started as conf_get_str() with one extra search
parameter, subsequent patches have not maintained feature parity,
combine the code to make a single more generic function and just call
that differently where required.

Signed-off-by: Justin Mitchell 
Signed-off-by: Steve Dickson

conffile: const-ify the config handling functions

2017-09-28T18:04:07+00:00

Tighten up the conffile interface by switching to const
arguments where appropriate.

Signed-off-by: Justin Mitchell 
Signed-off-by: Steve Dickson

mount: handle EACCES during version negotiation

2017-09-14T16:58:04+00:00

mount() can return EACCES for servers which permit 4.0
but are configured not to allow 4.1  This is currently
only handled by the default case, so these mounts fail
without retrying a lower minor.

Add handling for EACCES to be retried with a lower
minor version.

Signed-off-by: Frank Sorenson 
Signed-off-by: Steve Dickson

nfsman: document minorversion

2017-09-14T16:57:50+00:00

Signed-off-by: Steve Dickson

idmapd: daemonize earlier

2017-08-23T18:58:24+00:00

daemon_init() calls closeall() to close any "unneeded" file descriptors.
This causes the following issue with idmapd on systems that are
configured to have SSSD handle local users and groups:

1. During startup, rpc.idmapd calls getpwnam("nobody") and
   getgrnam("nobody")
2. sss_nss_mc_get{pw,gr}nam from libnss_sss open the cache files for
   users and groups and store the fd's in a struct sss_cli_mc_ctx.  The
   passwd cache is fd 3 and the group cache is fd 4.
3. idmapd calls daemon_init() which sets fd's 0, 1, and 2 to /dev/null
   and fd 3 to the write end of the pipe that the child uses to report
   it's startup status.  It then closes all fd's >= 4.
4. idmapd then calls event_init() which leads to epoll_create1() which
   returns 4 as the epoll fd.
6. An NFSv4 mount request comes in from a client, triggering an nfsdcb
   callback.
7. idmapd calls getgrgid_r() which leads to a call to
   sss_nss_check_header() which determines that the cache needs to be
   reinitialized.  sss_nss_mc_destroy_ctx() is called, which closes the
   ctx->fd which now corresponds to the epoll file rather than the group
   cache file.
8. event_dispatch() calls epoll_wait() with epfd=4, and -EBADF is
   returned.  idmapd logs the following error and exits with  a nonzero
   status:

rpc.idmapd[650]: main: event_dispatch returns errno 9 (Bad file descriptor)

Moving the deamon_init() call so that it happens before get{pw,gr}nam()
fixes this.

Signed-off-by: Scott Mayhew 
Signed-off-by: Steve Dickson