diff options
| author | Maxim Dounin <mdounin@mdounin.ru> | 2021-08-29 22:20:38 +0300 |
|---|---|---|
| committer | Maxim Dounin <mdounin@mdounin.ru> | 2021-08-29 22:20:38 +0300 |
| commit | 9f90d11cf52ccb0a8d086525aa7e4218d31d529a (patch) | |
| tree | c075464cb5f18187ae2fc3619ab98254ffc2be1c | |
| parent | 78d9a3af91a31bb77ad74aca7286f1ef2dad89d6 (diff) | |
| download | nginx-9f90d11cf52ccb0a8d086525aa7e4218d31d529a.tar.gz | |
HTTP/2: improved handling of END_STREAM in a separate DATA frame.
The save body filter saves the request body to disk once the buffer is full.
Yet in HTTP/2 this might happen even if there is no need to save anything
to disk, notably when content length is known and the END_STREAM flag is
sent in a separate empty DATA frame. Workaround is to provide additional
byte in the buffer, so saving the request body won't be triggered.
This fixes unexpected request body disk buffering in HTTP/2 observed after
the previous change when content length is known and the END_STREAM flag
is sent in a separate empty DATA frame.
| -rw-r--r-- | src/http/v2/ngx_http_v2.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/http/v2/ngx_http_v2.c b/src/http/v2/ngx_http_v2.c index 461bbff84..a037e7a52 100644 --- a/src/http/v2/ngx_http_v2.c +++ b/src/http/v2/ngx_http_v2.c @@ -4034,6 +4034,9 @@ ngx_http_v2_read_request_body(ngx_http_request_t *r) if (len < 0 || len > (off_t) clcf->client_body_buffer_size) { len = clcf->client_body_buffer_size; + + } else { + len++; } if (r->request_body_no_buffering && !stream->in_closed) { |