diff options
| author | Maxim Dounin <mdounin@mdounin.ru> | 2022-11-30 18:01:53 +0300 |
|---|---|---|
| committer | Maxim Dounin <mdounin@mdounin.ru> | 2022-11-30 18:01:53 +0300 |
| commit | a77cef0995fb29af6602dcdeb560755443cb2cca (patch) | |
| tree | 7bb1cfe2b2dd48c8747630154895ae2c109cda80 | |
| parent | e8da064e0d16527a994ec7e3b2937363804b8e30 (diff) | |
| download | nginx-a77cef0995fb29af6602dcdeb560755443cb2cca.tar.gz | |
Removed casts from ngx_memcmp() macro.
Casts are believed to be not needed, since memcmp() has "const void *"
arguments since introduction of the "void" type in C89. And on pre-C89
platforms nginx is unlikely to compile without warnings anyway, as there
are no casts in memcpy() and memmove() calls.
These casts were added in 1648:89a47f19b9ec without any details on why they
were added, and Igor does not remember details either. The most plausible
explanation is that they were copied from ngx_strcmp() and were not really
needed even at that time.
Prodded by Alejandro Colomar.
| -rw-r--r-- | src/core/ngx_string.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/core/ngx_string.h b/src/core/ngx_string.h index 4378b649c..713eb42a7 100644 --- a/src/core/ngx_string.h +++ b/src/core/ngx_string.h @@ -145,7 +145,7 @@ ngx_copy(u_char *dst, u_char *src, size_t len) /* msvc and icc7 compile memcmp() to the inline loop */ -#define ngx_memcmp(s1, s2, n) memcmp((const char *) s1, (const char *) s2, n) +#define ngx_memcmp(s1, s2, n) memcmp(s1, s2, n) u_char *ngx_cpystrn(u_char *dst, u_char *src, size_t n); |