diff options
| author | Maxim Dounin <mdounin@mdounin.ru> | 2020-02-20 16:51:07 +0300 |
|---|---|---|
| committer | Maxim Dounin <mdounin@mdounin.ru> | 2020-02-20 16:51:07 +0300 |
| commit | 37984f0be1a5d608015517a64927d498888fb7ca (patch) | |
| tree | 74d390c09049f0233b5bbdbfd4de5391af617579 | |
| parent | b4d6b70d7f2e8207df02ab354da907475dcab8a5 (diff) | |
| download | nginx-37984f0be1a5d608015517a64927d498888fb7ca.tar.gz | |
Disabled duplicate "Host" headers (ticket #1724).
Duplicate "Host" headers were allowed in nginx 0.7.0 (revision b9de93d804ea)
as a workaround for some broken Motorola phones which used to generate
requests with two "Host" headers[1]. It is believed that this workaround
is no longer relevant.
[1] http://mailman.nginx.org/pipermail/nginx-ru/2008-May/017845.html
| -rw-r--r-- | src/http/ngx_http_request.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c index 9e64fd293..99fa6967d 100644 --- a/src/http/ngx_http_request.c +++ b/src/http/ngx_http_request.c @@ -1755,10 +1755,18 @@ ngx_http_process_host(ngx_http_request_t *r, ngx_table_elt_t *h, ngx_int_t rc; ngx_str_t host; - if (r->headers_in.host == NULL) { - r->headers_in.host = h; + if (r->headers_in.host) { + ngx_log_error(NGX_LOG_INFO, r->connection->log, 0, + "client sent duplicate host header: \"%V: %V\", " + "previous value: \"%V: %V\"", + &h->key, &h->value, &r->headers_in.host->key, + &r->headers_in.host->value); + ngx_http_finalize_request(r, NGX_HTTP_BAD_REQUEST); + return NGX_ERROR; } + r->headers_in.host = h; + host = h->value; rc = ngx_http_validate_host(&host, r->pool, 0); |