summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaxim Dounin <mdounin@mdounin.ru>2021-10-29 20:21:43 +0300
committerMaxim Dounin <mdounin@mdounin.ru>2021-10-29 20:21:43 +0300
commitf3fdc4c96f3cd1c338ecf11a67acfae6d0a08dc7 (patch)
treeaa669395d898888cbd06c93ebf1a8aa57a6952e2
parent7927071ee26ff6313301b744a90240dccbc836db (diff)
downloadnginx-f3fdc4c96f3cd1c338ecf11a67acfae6d0a08dc7.tar.gz
Switched to using posted next events after sendfile_max_chunk.
Previously, 1 millisecond delay was used instead. In certain edge cases this might result in noticeable performance degradation though, notably on Linux with typical CONFIG_HZ=250 (so 1ms delay becomes 4ms), sendfile_max_chunk 2m, and link speed above 2.5 Gbps. Using posted next events removes the artificial delay and makes processing fast in all cases.
-rw-r--r--src/http/ngx_http_write_filter_module.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/http/ngx_http_write_filter_module.c b/src/http/ngx_http_write_filter_module.c
index 6a5d957b1..bd3770457 100644
--- a/src/http/ngx_http_write_filter_module.c
+++ b/src/http/ngx_http_write_filter_module.c
@@ -331,8 +331,7 @@ ngx_http_write_filter(ngx_http_request_t *r, ngx_chain_t *in)
&& c->write->ready
&& c->sent - sent >= limit - (off_t) (2 * ngx_pagesize))
{
- c->write->delayed = 1;
- ngx_add_timer(c->write, 1);
+ ngx_post_event(c->write, &ngx_posted_next_events);
}
for (cl = r->out; cl && cl != chain; /* void */) {