delta/node-new.git/src/node_contextify.cc, branch main

vm: fix crash when setting proto on context's globalThis

2023-05-15T09:24:15+00:00

PR-URL: https://github.com/nodejs/node/pull/47939
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: James M Snell 
Reviewed-By: Darshan Sen 
Reviewed-By: Anna Henningsen

bootstrap: initialize per-isolate properties of bindings separately

2023-05-03T13:15:10+00:00

This patch moves the initialization of per-isolate properties of
the bindings that are in the embedded snapshot separate from the
initialization of their per-context properties. This is necessary
for workers to share the isolate snapshot with the main thread
and deserialize these properties instead of creating them from
scratch.

PR-URL: https://github.com/nodejs/node/pull/47768
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Minwoo Jung

vm: properly handle defining props on any value

2023-03-18T09:19:19+00:00

While it was supposed to fix most of the remaining issues,
https://github.com/nodejs/node/pull/46458 missed some in strict mode.

This PR adds some additional checks. It also clarifies what we are
really checking to execute or not the `GetReturnValue`.

PR-URL: https://github.com/nodejs/node/pull/46615
Reviewed-By: Vladimir de Turckheim 
Reviewed-By: Anna Henningsen

Revert "vm: fix leak in vm.compileFunction when importModuleDynamically is used"

2023-03-15T14:35:06+00:00

This reverts commit 986498b7b329f454507b3a47e9f20cbcdb029dc2.

Fixes: https://github.com/nodejs/node/issues/47096
PR-URL: https://github.com/nodejs/node/pull/47101
Reviewed-By: Anna Henningsen 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Joyee Cheung 
Reviewed-By: Danielle Adams 
Reviewed-By: Richard Lau 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Colin Ihrig 
Reviewed-By: Darshan Sen 
Reviewed-By: Tobias Nießen

vm: fix leak in vm.compileFunction when importModuleDynamically is used

2023-03-01T08:18:53+00:00

Previously in the implementation there was a cycle that V8 could not
detect:

Strong global reference to CompiledFnEntry (JS wrapper)
    -> strong reference to callback setting (through the
       callbackMap key-value pair)
    -> importModuleDynamically (wrapper in internalCompileFunction())
    -> Strong reference to the compiled function (through closure in
       internalCompileFunction())

The CompiledFnEntry only gets GC'ed when the compiled function is GC'ed.
Since the compiled function is always reachable as described above,
there is a leak.

We only needed the first strong global reference because we didn't want
the function to outlive the CompiledFnEntry. In this case it can be
solved by using a private symbol instead of going with the global
reference + destruction in the weak callback, which V8's GC is not
going to understand.

PR-URL: https://github.com/nodejs/node/pull/46785
Fixes: https://github.com/nodejs/node/issues/42080
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Benjamin Gruenbaum

lib,src: fix a few typos in comments

2023-02-25T20:29:59+00:00

PR-URL: https://github.com/nodejs/node/pull/46835
Reviewed-By: Rich Trott 
Reviewed-By: Moshe Atlow 
Reviewed-By: Marco Ippolito 
Reviewed-By: Richard Lau 
Reviewed-By: Mohammed Keyvanzadeh

vm: properly support symbols on globals

2023-02-04T10:32:31+00:00

A regression has been introduced in node 18.2.0,
it makes the following snippet fails while it used to work in the past:

```
const assert = require('assert');
const vm = require('vm');
const global = vm.runInContext('this', vm.createContext());
const totoSymbol = Symbol.for('toto');
Object.defineProperty(global, totoSymbol, {
  enumerable: true,
  writable: true,
  value: 4,
  configurable: true,
});
assert(Object.getOwnPropertySymbols(global).includes(totoSymbol));
```

Regression introduced by: https://github.com/nodejs/node/pull/42963.
So I basically attempted to start understanding what it changed to make
it fix the initial issue while not breaking the symbol related one.

Fixes: https://github.com/nodejs/node/issues/45983
PR-URL: https://github.com/nodejs/node/pull/46458
Reviewed-By: Antoine du Hamel 
Reviewed-By: Michaël Zasso

src: add snapshot support for embedder API

2023-02-03T20:48:22+00:00

Add experimental support for loading snapshots in the embedder API
by adding a public opaque wrapper for our `SnapshotData` struct and
allowing embedders to pass it to the relevant setup functions.
Where applicable, use these helpers to deduplicate existing code
in Node.js’s startup path.

This has shown a 40 % startup performance increase for a real-world
application, even with the somewhat limited current support for
built-in modules.

The documentation includes a note about no guarantees for API or
ABI stability for this feature while it is experimental.

PR-URL: https://github.com/nodejs/node/pull/45888
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

vm: expose cachedDataRejected for vm.compileFunction

2023-01-25T20:06:55+00:00

Having this information available is useful for functions just as
it is for scripts. Therefore, expose it in the same way that other
information related to code caching is reported.

As part of this, de-duplify the code for setting the properties on
the C++ side and add proper exception handling to it.

PR-URL: https://github.com/nodejs/node/pull/46320
Reviewed-By: Gus Caplan 
Reviewed-By: Chengzhong Wu

src: rename internal module declaration as internal bindings

2022-11-28T16:23:08+00:00

This is a continuation of the name reification on the internal bindings.

Renames NODE_MODULE_CONTEXT_AWARE_INTERNAL and
NODE_MODULE_EXTERNAL_REFERENCE to NODE_BINDING_CONTEXT_AWARE_INTERNAL
and NODE_BINDING_EXTERNAL_REFERENCE respectively.

PR-URL: https://github.com/nodejs/node/pull/45551
Refs: https://github.com/nodejs/node/issues/44036
Reviewed-By: Joyee Cheung 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Daeyeon Jeong 
Reviewed-By: Jacob Smith 
Reviewed-By: Yagiz Nizipli