delta/node-new.git/src/node_worker.h, branch devsnek-patch-1

worker: add eventLoopUtilization()

2020-10-27T08:43:20+00:00

Allow calling eventLoopUtilization() directly on a worker thread:

    const worker = new Worker('./foo.js');
    const elu = worker.performance.eventLoopUtilization();
    setTimeout(() => {
      worker.performance.eventLoopUtilization(elu);
    }, 10);

Add a new performance object on the Worker instance that will hopefully
one day hold all the other performance metrics, such as nodeTiming.

Include benchmarks and tests.

PR-URL: https://github.com/nodejs/node/pull/35664
Reviewed-By: Juan José Arboleda 
Reviewed-By: Anna Henningsen 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: James M Snell

src: add check against non-weak BaseObjects at process exit

2020-10-07T08:54:34+00:00

When a process exits cleanly, i.e. because the event loop ends up
without things to wait for, the Node.js objects that are left on
the heap should be:

 1. weak, i.e. ready for garbage collection once no longer
    referenced, or
 2. detached, i.e. scheduled for destruction once no longer
    referenced, or
 3. an unrefed libuv handle, i.e. does not keep the event loop
    alive, or
 4. an inactive libuv handle (essentially the same here)

There are a few exceptions to this rule, but generally,
if there are C++-backed Node.js objects on the heap
that do not fall into the above categories, we may be looking
at a potential memory leak. Most likely, the cause is a missing
`MakeWeak()` call on the corresponding object.

In order to avoid this kind of problem, we check the list
of BaseObjects for these criteria. In this commit, we only do so
when explicitly instructed to or when in debug mode
(where --verify-base-objects is always-on).

In particular, this avoids the kinds of memory leak issues
that were fixed in the PRs referenced below.

Refs: https://github.com/nodejs/node/pull/35488
Refs: https://github.com/nodejs/node/pull/35487
Refs: https://github.com/nodejs/node/pull/35481

PR-URL: https://github.com/nodejs/node/pull/35490
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott 
Reviewed-By: Joyee Cheung 
Reviewed-By: Benjamin Gruenbaum

worker: add option to track unmanaged file descriptors

2020-07-14T13:07:20+00:00

Add a public option for Workers which adds tracking for raw
file descriptors, as currently, those resources are not cleaned
up, unlike e.g. `FileHandle`s.

PR-URL: https://github.com/nodejs/node/pull/34303
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Benjamin Gruenbaum

worker: add stack size resource limit option

2020-04-29T03:13:42+00:00

Add `stackSizeMb` to the `resourceLimit` option group.

Refs: https://github.com/nodejs/node/pull/31593#issuecomment-619633820

PR-URL: https://github.com/nodejs/node/pull/33085
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

worker: unify custom error creation

2020-04-29T03:12:48+00:00

Mostly, this introduces a pattern that makes sure that if a custom
error is reported, `stopped_` will be set to `true` correctly in
every cast, which was previously missing for the
`NewContext().IsEmpty()` case (which led to a hard crash from the
`Worker` destructor).

This also leaves TODO comments for a few cases in which
`ERR_WORKER_OUT_OF_MEMORY` was not used in accordance with the
documentation for that error code (or according to its intention).
Fixing that is semver-major.

PR-URL: https://github.com/nodejs/node/pull/33084
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

src: remove loop_init_failed_ from Worker class

2020-04-02T16:13:09+00:00

There’s no reason for this to not be stored alongside the loop
data structure itself.

PR-URL: https://github.com/nodejs/node/pull/32562
Refs: https://github.com/nodejs/node/pull/32344
Reviewed-By: Colin Ihrig 
Reviewed-By: Denys Otrishko 
Reviewed-By: James M Snell

src: align worker and main thread code with embedder API

2020-03-21T09:57:20+00:00

This addresses some long-standing TODOs by Joyee and me about
making the embedder API more powerful and us less reliant on
internal APIs for creating the main thread and Workers.

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

worker: emit runtime error on loop creation failure

2020-02-19T18:54:59+00:00

Instead of hard asserting throw a runtime error,
that is more consumable.

Fixes: https://github.com/nodejs/node/issues/31614

PR-URL: https://github.com/nodejs/node/pull/31621
Reviewed-By: Anna Henningsen

worker: properly handle env and NODE_OPTIONS in workers

2020-02-13T15:05:27+00:00

PR-URL: https://github.com/nodejs/node/pull/31711
Fixes: https://github.com/nodejs/node/issues/30627
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum

src: remove unused `Worker::child_port_` member

2020-02-04T06:02:34+00:00

This fixes a compiler warning introduced in 9225939528590f652e6.

PR-URL: https://github.com/nodejs/node/pull/31599
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig