diff options
| author | João Reis <reis@janeasystems.com> | 2019-12-11 05:51:23 +0000 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-12-13 12:29:56 -0500 |
| commit | 654d22ccf40ab3b803baa7c43dafa46875c20812 (patch) | |
| tree | 6ef45bb5e017d9ef77c3f40e7dce3b45d6d898e5 /.gitignore | |
| parent | 6143e0079a9df0bd646ef0b67e445d9aa700bb19 (diff) | |
| download | node-new-654d22ccf40ab3b803baa7c43dafa46875c20812.tar.gz | |
build,win: support building MSI with VS2019
Explicitly pass the WiX SDK directory when building the MSI. WiX
doesn't (yet?) have a directory for VS2019, so use the one for VS2017
which should be compatible.
PR-URL: https://github.com/nodejs/node/pull/30895
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to '.gitignore')
| -rw-r--r-- | .gitignore | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/.gitignore b/.gitignore index e50393f003..db2597b042 100644 --- a/.gitignore +++ b/.gitignore @@ -37,6 +37,8 @@ /*.swp /out /*.txt +/*.msi +/*.wixpdb # === Rules for artifacts of `./configure` === /icu_config.gypi @@ -58,6 +60,9 @@ _UpgradeReport_Files/ *.wixobj /tools/msvs/genfiles/ /npm.wxs +/tools/msvs/msi/Release/ +/tools/msvs/msi/obj/ +/tools/msvs/msi/x64/ # Exclude MSVS files used for .msi file generation !tools/msvs/msi/custom_actions.vcxproj !tools/msvs/msi/nodemsi.sln |