diff options
| author | Richard Lau <riclau@uk.ibm.com> | 2018-11-08 13:27:39 -0500 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-11-10 23:00:34 -0800 |
| commit | 19e5e78e9c65605eba43b8c506a8069f6f6d5ff9 (patch) | |
| tree | ec4b718a6404d9f6501a00b2bf0e0b15b48e8fdd /.travis.yml | |
| parent | b5420c9577be1f07da8c6ca8b46bb38195ba2529 (diff) | |
| download | node-new-19e5e78e9c65605eba43b8c506a8069f6f6d5ff9.tar.gz | |
build: lint commit message in separate Travis job
Move the first commit message linting to a separate Travis job. Run the
script in bash debug mode to capture any issues communicating with the
GitHub API (e.g. network issues, rate limits).
PR-URL: https://github.com/nodejs/node/pull/24254
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Diffstat (limited to '.travis.yml')
| -rw-r--r-- | .travis.yml | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/.travis.yml b/.travis.yml index 80c729a772..e496919579 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,6 +4,14 @@ cache: ccache os: linux matrix: include: + - name: "First commit message adheres to guidelines at <a href=\"https://goo.gl/p2fr5Q\">https://goo.gl/p2fr5Q</a>" + if: type = pull_request + language: node_js + node_js: "node" + script: + - if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then + bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST}; + fi - name: "Linter" language: node_js node_js: "node" @@ -11,10 +19,6 @@ matrix: - NODE=$(which node) script: - make lint - # Lint the first commit in the PR. - - if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then - bash tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST} || true; - fi - name: "Test Suite" addons: apt: |