diff options
author | Daniel Chatfield <chatfielddaniel@gmail.com> | 2013-07-30 14:43:31 +0100 |
---|---|---|
committer | Bert Belder <bertbelder@gmail.com> | 2013-08-17 15:41:03 +0200 |
commit | 98a9089f5f311e346725f016591d92eb8d532070 (patch) | |
tree | 7313647c3d327a4bfdda0305e64fab8059dcd041 /.travis.yml | |
parent | 42f926ece7ebfdb3ff896b93d362cdeb0cd00d83 (diff) | |
download | node-new-98a9089f5f311e346725f016591d92eb8d532070.tar.gz |
readline: pause stdin before turning off terminal raw mode
On windows, libuv will immediately make a `ReadConsole` call (in the
thread pool) when a 'flowing' `uv_tty_t` handle is switched to
line-buffered mode. That causes an immediate issue for some users,
since libuv can't cancel the `ReadConsole` operation on Windows 8 /
Server 2012 and up if the program switches back to raw mode later.
But even if this will be fixed in libuv at some point, it's better to
avoid the overhead of starting work in the thread pool and immediately
cancelling it afther that.
See also f34f1e3, where the same change is made for the opposite
flow, e.g. move `resume()` after `_setRawMode(true)`.
Fixes #5927
This is a backport of dfb0461 (see #5930) to the v0.8 branch.
Diffstat (limited to '.travis.yml')
0 files changed, 0 insertions, 0 deletions