diff options
author | Nancy Truong <truongh.nancy@gmail.com> | 2018-10-12 10:23:36 -0700 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2018-10-21 12:25:02 -0700 |
commit | add4f019e452a2dd3270a0b3b83936b6c49704ce (patch) | |
tree | 9d70653da8cbcd4fa897dff0cff8e7588a26a566 | |
parent | 52428c81cdda14daf2261f76aad4b39acbca7b93 (diff) | |
download | node-new-add4f019e452a2dd3270a0b3b83936b6c49704ce.tar.gz |
test: check codes of thrown errors
PR-URL: https://github.com/nodejs/node/pull/23519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
-rw-r--r-- | test/parallel/test-buffer-alloc.js | 16 | ||||
-rw-r--r-- | test/parallel/test-buffer-arraybuffer.js | 7 |
2 files changed, 16 insertions, 7 deletions
diff --git a/test/parallel/test-buffer-alloc.js b/test/parallel/test-buffer-alloc.js index ca790c933d..313a13cb1e 100644 --- a/test/parallel/test-buffer-alloc.js +++ b/test/parallel/test-buffer-alloc.js @@ -967,12 +967,16 @@ common.expectsError( message: 'argument must be a buffer' }); -const regErrorMsg = - new RegExp('The first argument must be one of type string, Buffer, ' + - 'ArrayBuffer, Array, or Array-like Object\\.'); - -assert.throws(() => Buffer.from(), regErrorMsg); -assert.throws(() => Buffer.from(null), regErrorMsg); +assert.throws(() => Buffer.from(), { + name: 'TypeError [ERR_INVALID_ARG_TYPE]', + message: 'The first argument must be one of type string, Buffer, ' + + 'ArrayBuffer, Array, or Array-like Object. Received type undefined' +}); +assert.throws(() => Buffer.from(null), { + name: 'TypeError [ERR_INVALID_ARG_TYPE]', + message: 'The first argument must be one of type string, Buffer, ' + + 'ArrayBuffer, Array, or Array-like Object. Received type object' +}); // Test prototype getters don't throw assert.strictEqual(Buffer.prototype.parent, undefined); diff --git a/test/parallel/test-buffer-arraybuffer.js b/test/parallel/test-buffer-arraybuffer.js index 8d26f983f2..2a1ce14107 100644 --- a/test/parallel/test-buffer-arraybuffer.js +++ b/test/parallel/test-buffer-arraybuffer.js @@ -40,7 +40,12 @@ assert.throws(function() { Object.setPrototypeOf(AB, ArrayBuffer); Object.setPrototypeOf(AB.prototype, ArrayBuffer.prototype); Buffer.from(new AB()); -}, TypeError); +}, { + code: 'ERR_INVALID_ARG_TYPE', + name: 'TypeError [ERR_INVALID_ARG_TYPE]', + message: 'The first argument must be one of type string, Buffer,' + + ' ArrayBuffer, Array, or Array-like Object. Received type object' +}); // Test the byteOffset and length arguments { |