diff options
author | Masashi Hirano <cherrydog07@gmail.com> | 2018-10-01 02:03:47 +0900 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2018-10-17 11:33:17 -0700 |
commit | b5c75a331d9eacecf11da7f38fb4fa7a0263d5fe (patch) | |
tree | 89f49d4f25c2843ac2e5964d99bc27f3d5c2669f | |
parent | a29631b23717370f7786b563049b0be387fc0a41 (diff) | |
download | node-new-b5c75a331d9eacecf11da7f38fb4fa7a0263d5fe.tar.gz |
test: error when empty buffer is passed to filehandle.read()
Added tests to occur error when empty buffer is passed to
filehandle.read() to increase coverage.
PR-URL: https://github.com/nodejs/node/pull/23250
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
-rw-r--r-- | test/parallel/test-fs-read-empty-buffer.js | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/test/parallel/test-fs-read-empty-buffer.js b/test/parallel/test-fs-read-empty-buffer.js index 34e418eac6..2f44b9a184 100644 --- a/test/parallel/test-fs-read-empty-buffer.js +++ b/test/parallel/test-fs-read-empty-buffer.js @@ -6,6 +6,7 @@ const assert = require('assert'); const fs = require('fs'); const filepath = fixtures.path('x.txt'); const fd = fs.openSync(filepath, 'r'); +const fsPromises = fs.promises; const buffer = new Uint8Array(); @@ -26,3 +27,15 @@ assert.throws( 'Received Uint8Array []' } ); + +(async () => { + const filehandle = await fsPromises.open(filepath, 'r'); + assert.rejects( + () => filehandle.read(buffer, 0, 1, 0), + { + code: 'ERR_INVALID_ARG_VALUE', + message: 'The argument \'buffer\' is empty and cannot be written. ' + + 'Received Uint8Array []' + } + ); +})(); |