diff options
| author | James M Snell <jasnell@gmail.com> | 2018-10-18 17:45:47 -0700 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2018-10-21 12:25:10 -0700 |
| commit | bb26d4f2f88f30ae17e04dca44e7c004f62d0a43 (patch) | |
| tree | 7fba13d6066464ad94a70e6f954ec669ec6c6115 | |
| parent | c4e74ec1cd51ef6eeaeed867b7ef8df3c5c6779c (diff) | |
| download | node-new-bb26d4f2f88f30ae17e04dca44e7c004f62d0a43.tar.gz | |
meta: clarify fast-track approval
Refs: https://github.com/nodejs/node/pull/23725#issuecomment-431202936
PR-URL: https://github.com/nodejs/node/pull/23744
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 7dba23dc74..7cfc6388c5 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -187,7 +187,9 @@ Collaborators that previously approved the pull request. If someone disagrees with the fast-tracking request, remove the label and leave a comment indicating why the pull request should not be fast-tracked. The pull request can be landed once two or more Collaborators approve both the pull request and the -fast-tracking request, and the necessary CI testing is done. +fast-tracking request, and the necessary CI testing is done. A request to +fast-track a PR made by a different Collaborator than the pull-request author +counts as a fast-track approval. ### Testing and CI |