diff options
author | Ujjwal Sharma <usharma1998@gmail.com> | 2018-03-11 01:35:40 +0530 |
---|---|---|
committer | Luigi Pinca <luigipinca@gmail.com> | 2018-03-13 20:02:47 +0100 |
commit | 90b05382734aca10b51b187eb955a964cbcaed74 (patch) | |
tree | 36caa4bb8f9aaf7802ca47b32faccd21498987b9 | |
parent | 52e869bee8f639fb2b256efa814446d0c325a4ac (diff) | |
download | node-new-90b05382734aca10b51b187eb955a964cbcaed74.tar.gz |
test: use descriptive names for regression tests
Rename the tests appropriately alongside mentioning the subsystem.
Also, make a few basic changes to make sure the tests conform to the
standard test structure.
- Rename test-regress-GH-9819 to test-crypto-tostring-segfault
- Rename test-regress-GH-5051 to test-http-addrequest-localaddress
- Rename test-regress-GH-5727 to test-net-listen-invalid-port
- Rename test-regress-GH-5927 to test-tty-stdin-pipe
- Rename test-regress-GH-6235 to test-v8-global-setter
PR-URL: https://github.com/nodejs/node/pull/19275
Refs: https://github.com/nodejs/node/issues/19105
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
-rw-r--r-- | test/parallel/test-crypto-tostring-segfault.js (renamed from test/parallel/test-regress-GH-9819.js) | 5 | ||||
-rw-r--r-- | test/parallel/test-http-addrequest-localaddress.js (renamed from test/parallel/test-regress-GH-5051.js) | 5 | ||||
-rw-r--r-- | test/parallel/test-net-listen-invalid-port.js (renamed from test/parallel/test-regress-GH-5727.js) | 5 | ||||
-rw-r--r-- | test/parallel/test-tty-stdin-pipe.js (renamed from test/parallel/test-regress-GH-5927.js) | 4 | ||||
-rw-r--r-- | test/parallel/test-v8-global-setter.js (renamed from test/parallel/test-regress-GH-6235.js) | 4 |
5 files changed, 23 insertions, 0 deletions
diff --git a/test/parallel/test-regress-GH-9819.js b/test/parallel/test-crypto-tostring-segfault.js index 7eed1c512f..b2c95117d3 100644 --- a/test/parallel/test-regress-GH-9819.js +++ b/test/parallel/test-crypto-tostring-segfault.js @@ -3,6 +3,11 @@ const common = require('../common'); if (!common.hasCrypto) common.skip('missing crypto'); +// This test ensures that node doesn't SEGFAULT when either of +// `crypto.createHash` or `crypto.createHmac` are given an object that defines +// a throwing `toString`. +// https://github.com/nodejs/node/issues/9819 + const assert = require('assert'); const execFile = require('child_process').execFile; diff --git a/test/parallel/test-regress-GH-5051.js b/test/parallel/test-http-addrequest-localaddress.js index 0fef879c6f..fce53c88af 100644 --- a/test/parallel/test-regress-GH-5051.js +++ b/test/parallel/test-http-addrequest-localaddress.js @@ -1,5 +1,10 @@ 'use strict'; require('../common'); + +// This test ensures that `addRequest`'s Legacy API accepts `localAddress` +// correctly instead of accepting `path`. +// https://github.com/nodejs/node/issues/5051 + const assert = require('assert'); const agent = require('http').globalAgent; diff --git a/test/parallel/test-regress-GH-5727.js b/test/parallel/test-net-listen-invalid-port.js index fab139ca7c..d07bc9fafa 100644 --- a/test/parallel/test-regress-GH-5727.js +++ b/test/parallel/test-net-listen-invalid-port.js @@ -1,5 +1,10 @@ 'use strict'; const common = require('../common'); + +// This test ensures that port numbers are validated in *all* kinds of `listen` +// calls. If an invalid port is supplied, ensures a `RangeError` is thrown. +// https://github.com/nodejs/node/issues/5727 + const assert = require('assert'); const net = require('net'); diff --git a/test/parallel/test-regress-GH-5927.js b/test/parallel/test-tty-stdin-pipe.js index f32dd61c97..9e94153206 100644 --- a/test/parallel/test-regress-GH-5927.js +++ b/test/parallel/test-tty-stdin-pipe.js @@ -21,6 +21,10 @@ 'use strict'; require('../common'); + +// This test ensures piping from `stdin` isn't broken. +// https://github.com/nodejs/node/issues/5927 + const assert = require('assert'); const readline = require('readline'); diff --git a/test/parallel/test-regress-GH-6235.js b/test/parallel/test-v8-global-setter.js index 484138ba2d..1cb0898e61 100644 --- a/test/parallel/test-regress-GH-6235.js +++ b/test/parallel/test-v8-global-setter.js @@ -22,4 +22,8 @@ 'use strict'; require('../common'); +// This test ensures v8 correctly sets a property on the global object if it +// has a setter interceptor in strict mode. +// https://github.com/nodejs/node-v0.x-archive/issues/6235 + require('vm').runInNewContext('"use strict"; var v = 1; v = 2'); |