diff options
| author | Jiawen Geng <technicalcute@gmail.com> | 2022-03-17 11:33:07 +0100 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2022-04-21 11:55:07 +0200 |
| commit | 5820d145ad9366677b6bb111727c543811c53c8f (patch) | |
| tree | eee3a50240be5aec48ca6eb2907b7d158048ef15 | |
| parent | c237c377ac97f56bae0b0341b25c7808dc777c4b (diff) | |
| download | node-new-5820d145ad9366677b6bb111727c543811c53c8f.tar.gz | |
deps: V8: fix v8-cppgc.h for MSVC
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: https://github.com/nodejs/node/issues/42375
PR-URL: https://github.com/nodejs/node/pull/42657
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
| -rw-r--r-- | common.gypi | 2 | ||||
| -rw-r--r-- | deps/v8/include/v8-cppgc.h | 3 |
2 files changed, 4 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index f1e73072f9..2d510e2410 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.5', + 'v8_embedder_string': '-node.6', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/include/v8-cppgc.h b/deps/v8/include/v8-cppgc.h index 412154930f..401e492210 100644 --- a/deps/v8/include/v8-cppgc.h +++ b/deps/v8/include/v8-cppgc.h @@ -77,6 +77,9 @@ struct WrapperDescriptor final { }; struct V8_EXPORT CppHeapCreateParams { + CppHeapCreateParams(const CppHeapCreateParams&) = delete; + CppHeapCreateParams& operator=(const CppHeapCreateParams&) = delete; + std::vector<std::unique_ptr<cppgc::CustomSpaceBase>> custom_spaces; WrapperDescriptor wrapper_descriptor; }; |