diff options
| author | Darshan Sen <raisinten@gmail.com> | 2022-04-20 04:56:50 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-04-20 00:26:50 +0100 |
| commit | fc326d674d4f366a78b882d3a32b0796448296bc (patch) | |
| tree | 82da2e6ad10e6b05370fbe03e485b109506e303c | |
| parent | 1e761654d3d93e4568d1228b92d1f3a09e92d078 (diff) | |
| download | node-new-fc326d674d4f366a78b882d3a32b0796448296bc.tar.gz | |
build: improve the format-cpp error message
This change specifies the target branch name instead of leaving that to
the committer to fill in.
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/42765
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
| -rw-r--r-- | .github/workflows/linters.yml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml index 312ba0b3c9..fa761f4f9d 100644 --- a/.github/workflows/linters.yml +++ b/.github/workflows/linters.yml @@ -78,7 +78,7 @@ jobs: echo echo 'ERROR: Please run:' echo - echo ' CLANG_FORMAT_START="$(git merge-base HEAD <target-branch-name>)" make format-cpp' + echo " CLANG_FORMAT_START="$\(git merge-base HEAD ${GITHUB_BASE_REF}\)" make format-cpp" echo echo 'to format the commits in your branch.' exit "$EXIT_CODE" |