diff options
| author | Christian Clauss <cclauss@me.com> | 2019-10-27 11:10:58 +0100 |
|---|---|---|
| committer | cclauss <cclauss@me.com> | 2019-10-31 17:31:27 +0100 |
| commit | 8444de800deebf2199f51f93237acdf087e35454 (patch) | |
| tree | cbaee19a1435888efef54e4b6348cbffa7b35770 | |
| parent | 99c1238f54a34acae7a4bde1c1e031fbf5d4d214 (diff) | |
| download | node-new-8444de800deebf2199f51f93237acdf087e35454.tar.gz | |
build: find Python syntax errors in dependencies
As discussed in https://github.com/nodejs/node/issues/30129#issuecomment-546662351, when we vendor in code, we own the Syntax Errors in that code. This PR adds The `.flake8` config file at the root of this repo puts blinders on the linting of our dependencies so this test disables that file before linting.
| -rw-r--r-- | .travis.yml | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/.travis.yml b/.travis.yml index 8aa321ec16..04b78d9e34 100644 --- a/.travis.yml +++ b/.travis.yml @@ -88,3 +88,13 @@ jobs: - if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then bash -x tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST}; fi + + - name: "Find syntax errors in our Python dependencies" + language: python + python: 3.8 + install: + - mv .flake8 disabled.flake8 # take the blinders off of flake8 + - python3.8 -m pip install --upgrade pip + - python3.8 -m pip install flake8 + script: + - flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics |