diff options
author | Anna Henningsen <anna@addaleax.net> | 2020-04-15 20:40:02 +0200 |
---|---|---|
committer | Gireesh Punathil <gpunathi@in.ibm.com> | 2020-04-18 07:59:45 +0530 |
commit | 1ce906c16ba09885fb372962a3a56ce64ef06a20 (patch) | |
tree | dabe25d4e6e24a346e11b3076897a94595ad4904 | |
parent | 392bba4ec586a3b5adfbd243aada711114afcc2d (diff) | |
download | node-new-1ce906c16ba09885fb372962a3a56ce64ef06a20.tar.gz |
tools: decrease timeout in test.py
This fixes the following crash on Windows for me. I don't know
why this I only started to see this now, but anyway, the new timeout
value is still longer than a week and a half.
File "tools/test.py", line 1725, in <module>
sys.exit(Main())
File "tools/test.py", line 1701, in Main
if RunTestCases(cases_to_run, options.progress, \
options.j, options.flaky_tests):
File "tools/test.py", line 923, in RunTestCases
return progress.Run(tasks)
File "tools/test.py", line 145, in Run
thread.join(timeout=10000000)
File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \
lib\threading.py", line 1015, in join
self._wait_for_tstate_lock(timeout=max(timeout, 0))
File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \
lib\threading.py", line 1027, in _wait_for_tstate_lock
elif lock.acquire(block, timeout):
OverflowError: timeout value is too large
PR-URL: https://github.com/nodejs/node/pull/32868
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
-rwxr-xr-x | tools/test.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/test.py b/tools/test.py index 5eb1fa7672..dde7c7b2f8 100755 --- a/tools/test.py +++ b/tools/test.py @@ -142,7 +142,7 @@ class ProgressIndicator(object): # Wait for the remaining threads for thread in threads: # Use a timeout so that signals (ctrl-c) will be processed. - thread.join(timeout=10000000) + thread.join(timeout=1000000) except (KeyboardInterrupt, SystemExit): self.shutdown_event.set() except Exception: |