summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorcjihrig <cjihrig@gmail.com>2019-05-18 10:09:48 -0400
committercjihrig <cjihrig@gmail.com>2019-05-20 10:26:23 -0400
commit873c372e6772d7378531d6afc8cad8bd513bdc58 (patch)
tree7536a8840b6b0785a78336e70d3aad6b473f6b8e
parent1b381d630a3a595405c00892c58335369a368915 (diff)
downloadnode-new-873c372e6772d7378531d6afc8cad8bd513bdc58.tar.gz
esm: use correct error arguments
ERR_UNKNOWN_FILE_EXTENSION expects a single argument. This commit fixes the argument count. PR-URL: https://github.com/nodejs/node/pull/27763 Fixes: https://github.com/nodejs/node/issues/27761 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
-rw-r--r--lib/internal/modules/esm/default_resolve.js3
-rw-r--r--test/es-module/test-esm-invalid-extension.js13
-rw-r--r--test/fixtures/es-modules/import-invalid-ext.mjs1
3 files changed, 15 insertions, 2 deletions
diff --git a/lib/internal/modules/esm/default_resolve.js b/lib/internal/modules/esm/default_resolve.js
index 67b8db716c..88377689ce 100644
--- a/lib/internal/modules/esm/default_resolve.js
+++ b/lib/internal/modules/esm/default_resolve.js
@@ -91,8 +91,7 @@ function resolve(specifier, parentURL) {
if (isMain)
format = type === TYPE_MODULE ? 'module' : 'commonjs';
else
- throw new ERR_UNKNOWN_FILE_EXTENSION(fileURLToPath(url),
- fileURLToPath(parentURL));
+ throw new ERR_UNKNOWN_FILE_EXTENSION(fileURLToPath(url));
}
return { url: `${url}`, format };
}
diff --git a/test/es-module/test-esm-invalid-extension.js b/test/es-module/test-esm-invalid-extension.js
new file mode 100644
index 0000000000..9e676e57d1
--- /dev/null
+++ b/test/es-module/test-esm-invalid-extension.js
@@ -0,0 +1,13 @@
+'use strict';
+require('../common');
+const fixtures = require('../common/fixtures');
+const assert = require('assert');
+const { spawnSync } = require('child_process');
+const fixture = fixtures.path('/es-modules/import-invalid-ext.mjs');
+const child = spawnSync(process.execPath, ['--experimental-modules', fixture]);
+const errMsg = 'TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension';
+
+assert.strictEqual(child.status, 1);
+assert.strictEqual(child.signal, null);
+assert.strictEqual(child.stdout.toString().trim(), '');
+assert(child.stderr.toString().includes(errMsg));
diff --git a/test/fixtures/es-modules/import-invalid-ext.mjs b/test/fixtures/es-modules/import-invalid-ext.mjs
new file mode 100644
index 0000000000..2de3425219
--- /dev/null
+++ b/test/fixtures/es-modules/import-invalid-ext.mjs
@@ -0,0 +1 @@
+import './simple.wat';