diff options
author | Anna Henningsen <anna@addaleax.net> | 2020-04-13 15:08:54 +0200 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2020-04-15 16:36:27 +0200 |
commit | d699fdd2c69c0ab3a1cac1c0c9f6331bb5b35bcc (patch) | |
tree | d7d4130fb16b3df9023f3c5d49776e8a93518214 | |
parent | 953445873a58513e673f6f05885406394ba66c79 (diff) | |
download | node-new-d699fdd2c69c0ab3a1cac1c0c9f6331bb5b35bcc.tar.gz |
worker: mention argument name in type check message
Refs: https://github.com/nodejs/node/pull/32745#discussion_r406564208
PR-URL: https://github.com/nodejs/node/pull/32815
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
-rw-r--r-- | src/node_messaging.cc | 4 | ||||
-rw-r--r-- | test/parallel/test-worker-message-port-receive-message.js | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/node_messaging.cc b/src/node_messaging.cc index e430ff70f8..d02a10c974 100644 --- a/src/node_messaging.cc +++ b/src/node_messaging.cc @@ -869,7 +869,7 @@ void MessagePort::ReceiveMessage(const FunctionCallbackInfo<Value>& args) { if (!args[0]->IsObject() || !env->message_port_constructor_template()->HasInstance(args[0])) { return THROW_ERR_INVALID_ARG_TYPE(env, - "First argument needs to be a MessagePort instance"); + "The \"port\" argument must be a MessagePort instance"); } MessagePort* port = Unwrap<MessagePort>(args[0].As<Object>()); if (port == nullptr) { @@ -890,7 +890,7 @@ void MessagePort::MoveToContext(const FunctionCallbackInfo<Value>& args) { if (!args[0]->IsObject() || !env->message_port_constructor_template()->HasInstance(args[0])) { return THROW_ERR_INVALID_ARG_TYPE(env, - "First argument needs to be a MessagePort instance"); + "The \"port\" argument must be a MessagePort instance"); } MessagePort* port = Unwrap<MessagePort>(args[0].As<Object>()); CHECK_NOT_NULL(port); diff --git a/test/parallel/test-worker-message-port-receive-message.js b/test/parallel/test-worker-message-port-receive-message.js index e7078ea1e6..8e5dc91a07 100644 --- a/test/parallel/test-worker-message-port-receive-message.js +++ b/test/parallel/test-worker-message-port-receive-message.js @@ -28,6 +28,6 @@ for (const value of [null, 0, -1, {}, []]) { assert.throws(() => receiveMessageOnPort(value), { name: 'TypeError', code: 'ERR_INVALID_ARG_TYPE', - message: 'First argument needs to be a MessagePort instance' + message: 'The "port" argument must be a MessagePort instance' }); } |