diff options
| author | Nimit <nimitagg95@gmail.com> | 2020-04-16 01:51:51 +0530 |
|---|---|---|
| committer | Gireesh Punathil <gpunathi@in.ibm.com> | 2020-04-18 08:04:45 +0530 |
| commit | e231e1a0d8857c70d6569f39d8d2e5b1955562b5 (patch) | |
| tree | 4df7d521a339f49704f797cf94b74308a7a74956 | |
| parent | 1ce906c16ba09885fb372962a3a56ce64ef06a20 (diff) | |
| download | node-new-e231e1a0d8857c70d6569f39d8d2e5b1955562b5.tar.gz | |
src: elevate v8 namespaces
elevate v8 namespaces. Leverage `using` semantics
for repeated usage of v8 artifacts.
PR-URL: https://github.com/nodejs/node/pull/32872
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
| -rw-r--r-- | src/cares_wrap.cc | 3 | ||||
| -rw-r--r-- | src/env.cc | 4 |
2 files changed, 4 insertions, 3 deletions
diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc index ff050cc2dc..8d1e3bc879 100644 --- a/src/cares_wrap.cc +++ b/src/cares_wrap.cc @@ -66,6 +66,7 @@ using v8::Int32; using v8::Integer; using v8::Isolate; using v8::Local; +using v8::NewStringType; using v8::Null; using v8::Object; using v8::String; @@ -1929,7 +1930,7 @@ void CanonicalizeIP(const FunctionCallbackInfo<Value>& args) { const int af = (rc == 4 ? AF_INET : AF_INET6); CHECK_EQ(0, uv_inet_ntop(af, &result, canonical_ip, sizeof(canonical_ip))); Local<String> val = String::NewFromUtf8(isolate, canonical_ip, - v8::NewStringType::kNormal).ToLocalChecked(); + NewStringType::kNormal).ToLocalChecked(); args.GetReturnValue().Set(val); } diff --git a/src/env.cc b/src/env.cc index 444d9c0368..f966bfba1e 100644 --- a/src/env.cc +++ b/src/env.cc @@ -174,10 +174,10 @@ void IsolateData::CreateProperties() { #define V(Provider) \ async_wrap_providers_[AsyncWrap::PROVIDER_ ## Provider].Set( \ isolate_, \ - v8::String::NewFromOneByte( \ + String::NewFromOneByte( \ isolate_, \ reinterpret_cast<const uint8_t*>(#Provider), \ - v8::NewStringType::kInternalized, \ + NewStringType::kInternalized, \ sizeof(#Provider) - 1).ToLocalChecked()); NODE_ASYNC_PROVIDER_TYPES(V) #undef V |