diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-11-21 11:00:52 -0800 |
|---|---|---|
| committer | Shelley Vohr <shelley.vohr@gmail.com> | 2019-01-28 23:11:39 -0800 |
| commit | 98ef097f76c6c129105b52fe1ba67602f4d5da94 (patch) | |
| tree | 1a4d8e0cd7237ff8d8fac84532e44592bea2c581 | |
| parent | 6ba6ce6634973ec9099319a0d595acd970e1de88 (diff) | |
| download | node-new-98ef097f76c6c129105b52fe1ba67602f4d5da94.tar.gz | |
doc: revise `author ready` explanation
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.
PR-URL: https://github.com/nodejs/node/pull/24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 4d0be355d5..9e4b72ea2e 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -69,12 +69,15 @@ issues and pull requests can always be re-opened if necessary. ### Author ready pull requests -A pull request that is still awaiting the minimum review time is considered -_author ready_ as soon as the CI has been started, it has at least two approvals -(one Collaborator approval is enough if the pull request has been open for more -than 7 days), and it has no outstanding review comments. Please always make sure -to add the `author ready` label to the PR in that case and remove it again as -soon as that condition is not met anymore. +A pull request is _author ready_ when: + +* There is a CI run in progress or completed. +* There are at least two Collaborator approvals, or at least one approval if the + pull request is older than 7 days. +* There are no outstanding review comments. + +Please always add the `author ready` label to the PR in that case. Please always +remove it again as soon as the conditions are not met anymore. ### Handling own pull requests |