diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-11-19 00:01:51 -0800 |
|---|---|---|
| committer | Shelley Vohr <shelley.vohr@gmail.com> | 2019-01-28 21:54:52 -0800 |
| commit | b1bbedd701631d5fd3305737c15b16110fc619a9 (patch) | |
| tree | dae42dcecd9182fbc13d2f6ff7a3ba2babbffe7d | |
| parent | b7876ba6e1e499177daff873fa4f9b2575ce98ca (diff) | |
| download | node-new-b1bbedd701631d5fd3305737c15b16110fc619a9.tar.gz | |
doc: edit COLLABORATOR_GUIDE.md on closing issues
Make the COLLABORATOR_GUIDE.md text on closing issues clearer. (Make it
clear that all the text refers to issues *and* pull requests, etc.)
PR-URL: https://github.com/nodejs/node/pull/24477
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 1eb75fc1f8..4d0be355d5 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -61,13 +61,11 @@ as a _Contributor_. Ask if they have configured their git ### Closing Issues and Pull Requests -Collaborators may close any issue or pull request they believe is -not relevant for the future of the Node.js project. Where this is -unclear, the issue should be left open for several days to allow for -additional discussion. Where this does not yield input from Node.js -Collaborators or additional evidence that the issue has relevance, the -issue may be closed. Remember that issues can always be re-opened if -necessary. +Collaborators may close any issue or pull request that is not relevant to the +future of the Node.js project. Where this is unclear, leave the issue or pull +request open for several days to allow for discussion. Where this does not yield +evidence that the issue or pull request has relevance, close it. Remember that +issues and pull requests can always be re-opened if necessary. ### Author ready pull requests |