diff options
| author | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2020-09-24 20:28:35 -0700 |
|---|---|---|
| committer | Richard Lau <rlau@redhat.com> | 2020-10-07 07:25:00 -0400 |
| commit | 54c2bc2e621fd9cde22ea65bda7f652a63b40340 (patch) | |
| tree | 0c86097e38156b00a61f3105c4e3e9484ef73731 | |
| parent | b83f9a56fc3e3b507dee17c00958c001b6f427f1 (diff) | |
| download | node-new-54c2bc2e621fd9cde22ea65bda7f652a63b40340.tar.gz | |
n-api: create N-API version 7
Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as
stable.
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: https://github.com/nodejs/node/pull/35199
Backport-PR-URL: https://github.com/nodejs/node/pull/35336
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <mdawson@devrus.com>
| -rw-r--r-- | doc/api/n-api.md | 6 | ||||
| -rw-r--r-- | src/node_api.h | 6 | ||||
| -rw-r--r-- | src/node_version.h | 2 | ||||
| -rw-r--r-- | test/addons-napi/test_general/test.js | 2 | ||||
| -rw-r--r-- | test/addons-napi/test_typedarray/test_typedarray.c | 1 |
5 files changed, 7 insertions, 10 deletions
diff --git a/doc/api/n-api.md b/doc/api/n-api.md index 512c0f93ce..d9ddf045b3 100644 --- a/doc/api/n-api.md +++ b/doc/api/n-api.md @@ -2951,10 +2951,9 @@ of the ECMAScript Language Specification. ### napi_detach_arraybuffer <!-- YAML added: v10.22.0 +napiVersion: 7 --> -> Stability: 1 - Experimental - ```C napi_status napi_detach_arraybuffer(napi_env env, napi_value arraybuffer) @@ -2977,10 +2976,9 @@ defined in [Section 24.1.1.3][] of the ECMAScript Language Specification. ### napi_is_detached_arraybuffer <!-- YAML added: v10.22.0 +napiVersion: 7 --> -> Stability: 1 - Experimental - ```C napi_status napi_is_detached_arraybuffer(napi_env env, napi_value arraybuffer, diff --git a/src/node_api.h b/src/node_api.h index c3bd4da123..66daed696f 100644 --- a/src/node_api.h +++ b/src/node_api.h @@ -15,7 +15,7 @@ // functions available in a new version of N-API that is not yet ported in all // LTS versions, they can set NAPI_VERSION knowing that they have specifically // depended on that version. -#define NAPI_VERSION 6 +#define NAPI_VERSION 7 #endif #endif @@ -752,7 +752,7 @@ napi_get_all_property_names(napi_env env, #endif // NAPI_VERSION >= 6 -#ifdef NAPI_EXPERIMENTAL +#if NAPI_VERSION >= 7 // ArrayBuffer detaching NAPI_EXTERN napi_status napi_detach_arraybuffer(napi_env env, @@ -762,7 +762,7 @@ NAPI_EXTERN napi_status napi_is_detached_arraybuffer(napi_env env, napi_value value, bool* result); -#endif // NAPI_EXPERIMENTAL +#endif // NAPI_VERSION >= 7 EXTERN_C_END diff --git a/src/node_version.h b/src/node_version.h index d5302112c8..ae768a1a76 100644 --- a/src/node_version.h +++ b/src/node_version.h @@ -115,6 +115,6 @@ // The NAPI_VERSION provided by this version of the runtime. This is the version // which the Node binary being built supports. -#define NAPI_VERSION 6 +#define NAPI_VERSION 7 #endif // SRC_NODE_VERSION_H_ diff --git a/test/addons-napi/test_general/test.js b/test/addons-napi/test_general/test.js index 1e0a98f48d..d841e289ea 100644 --- a/test/addons-napi/test_general/test.js +++ b/test/addons-napi/test_general/test.js @@ -34,7 +34,7 @@ assert.notStrictEqual(test_general.testGetPrototype(baseObject), // test version management functions // expected version is currently 4 -assert.strictEqual(test_general.testGetVersion(), 6); +assert.strictEqual(test_general.testGetVersion(), 7); const [ major, minor, patch, release ] = test_general.testGetNodeVersion(); assert.strictEqual(process.version.split('-')[0], diff --git a/test/addons-napi/test_typedarray/test_typedarray.c b/test/addons-napi/test_typedarray/test_typedarray.c index 00ceabdb96..14c5eb7f49 100644 --- a/test/addons-napi/test_typedarray/test_typedarray.c +++ b/test/addons-napi/test_typedarray/test_typedarray.c @@ -1,4 +1,3 @@ -#define NAPI_EXPERIMENTAL #include <node_api.h> #include <string.h> #include "../common.h" |