summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMasashi Hirano <cherrydog07@gmail.com>2018-05-04 13:44:16 +0900
committercjihrig <cjihrig@gmail.com>2018-05-05 10:38:44 -0400
commit6ec43fc28b66587eb176019f488d682d256bd189 (patch)
treef89adc5f49fa1544cf3ce2037cada395db0494f6
parent64348f5ea557d414b08d1b2602d794e48ac06bb2 (diff)
downloadnode-new-6ec43fc28b66587eb176019f488d682d256bd189.tar.gz
test: fix common.canCreateSymLink() on non-Windows
test/common/README.md indicates that canCreateSymlink() always returns true on non-Windows platforms. However, prior to this commit, undefined was being returned. This commit aligns the implementation with the docs by returning true. PR-URL: https://github.com/nodejs/node/pull/20511 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
-rw-r--r--test/common/index.js2
1 files changed, 2 insertions, 0 deletions
diff --git a/test/common/index.js b/test/common/index.js
index bbd2b62d7d..ea77c963aa 100644
--- a/test/common/index.js
+++ b/test/common/index.js
@@ -518,6 +518,8 @@ exports.canCreateSymLink = function() {
return false;
}
}
+ // On non-Windows platforms, this always returns `true`
+ return true;
};
exports.getCallSite = function getCallSite(top) {