summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRefael Ackermann <refack@gmail.com>2017-10-22 10:43:05 -0400
committerRefael Ackermann <refack@gmail.com>2017-10-26 18:38:36 -0400
commit9ab648120c7b226976ba2dfc6a89fda06e09addb (patch)
treed1ed484a93a9f6e797f00f635136ee2271d320bf
parent2be9198097a19169026fb73e263165e6cbee7243 (diff)
downloadnode-new-9ab648120c7b226976ba2dfc6a89fda06e09addb.tar.gz
build: improve `make clean`
also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: https://github.com/nodejs/node/pull/16372 Refs: https://github.com/nodejs/node/pull/16010 Refs: https://github.com/nodejs/node/issues/16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-rw-r--r--Makefile6
-rw-r--r--vcbuild.bat2
2 files changed, 6 insertions, 2 deletions
diff --git a/Makefile b/Makefile
index fccf6451cc..4e974903a9 100644
--- a/Makefile
+++ b/Makefile
@@ -102,11 +102,15 @@ uninstall:
clean:
$(RM) -r out/Makefile $(NODE_EXE) $(NODE_G_EXE) out/$(BUILDTYPE)/$(NODE_EXE) \
- out/$(BUILDTYPE)/node.exp
+ out/$(BUILDTYPE)/node.exp
@if [ -d out ]; then find out/ -name '*.o' -o -name '*.a' -o -name '*.d' | xargs $(RM) -r; fi
$(RM) -r node_modules
@if [ -d deps/icu ]; then echo deleting deps/icu; $(RM) -r deps/icu; fi
$(RM) test.tap
+ # Next one is legacy remove this at some point
+ $(RM) -r test/tmp*
+ $(RM) -r test/.tmp*
+ $(MAKE) test-addons-clean
distclean:
$(RM) -r out
diff --git a/vcbuild.bat b/vcbuild.bat
index 4d315ad3ff..7db343d874 100644
--- a/vcbuild.bat
+++ b/vcbuild.bat
@@ -541,7 +541,7 @@ echo Failed to create vc project files.
goto exit
:help
-echo vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/test-internet/test-pummel/test-simple/test-message/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module]
+echo vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/test-internet/test-pummel/test-simple/test-message/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module]
echo Examples:
echo vcbuild.bat : builds release build
echo vcbuild.bat debug : builds debug build