summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChetan Karande <kchetan.tech@gmail.com>2019-09-21 15:20:56 -0400
committerRuben Bridgewater <ruben@bridgewater.de>2019-09-25 18:21:06 +0200
commitf01682392910b0e9dabfa5016f9ed2771a9e0e50 (patch)
treecad7795811307cccea2ea912900f219eafe5a38d
parentb1008973e9a30ece4a2016fce1b58bec49e4127b (diff)
downloadnode-new-f01682392910b0e9dabfa5016f9ed2771a9e0e50.tar.gz
stream: add test for multiple .push(null)
PR-URL: https://github.com/nodejs/node/pull/29645 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
-rw-r--r--test/parallel/test-stream-readable-ended.js13
1 files changed, 13 insertions, 0 deletions
diff --git a/test/parallel/test-stream-readable-ended.js b/test/parallel/test-stream-readable-ended.js
index a224c68f04..f504330cb1 100644
--- a/test/parallel/test-stream-readable-ended.js
+++ b/test/parallel/test-stream-readable-ended.js
@@ -31,3 +31,16 @@ const assert = require('assert');
assert.strictEqual(readable.readableEnded, false);
}));
}
+
+// Verifies no `error` triggered on multiple .push(null) invocations
+{
+ const readable = new Readable();
+
+ readable.on('readable', () => { readable.read(); });
+ readable.on('error', common.mustNotCall());
+ readable.on('end', common.mustCall());
+
+ readable.push('a');
+ readable.push(null);
+ readable.push(null);
+}