diff options
| author | cjihrig <cjihrig@gmail.com> | 2019-11-19 15:05:09 -0500 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2020-02-13 08:42:46 +0100 |
| commit | 7a5954ef26c49f53d40a516df60800a119fb9da7 (patch) | |
| tree | 2f8c24bdbb154845741d8ed7931c0bdeea5c8712 | |
| parent | 888f8ffbac0fdb199cfa2f3d35878f119131358c (diff) | |
| download | node-new-7a5954ef26c49f53d40a516df60800a119fb9da7.tar.gz | |
src: fix -Winconsistent-missing-override warning
This commit addresses the following warning:
../src/node_api.cc:28:19: warning: 'mark_arraybuffer_as_untransferable'
overrides a member function but is not marked 'override'
[-Winconsistent-missing-override]
v8::Maybe<bool> mark_arraybuffer_as_untransferable(
^
../src/js_native_api_v8.h:42:27: note: overridden virtual function is here
virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable(
PR-URL: https://github.com/nodejs/node/pull/30549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
| -rw-r--r-- | src/node_api.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_api.cc b/src/node_api.cc index 0f7981cd56..5e467dded5 100644 --- a/src/node_api.cc +++ b/src/node_api.cc @@ -26,7 +26,7 @@ struct node_napi_env__ : public napi_env__ { } v8::Maybe<bool> mark_arraybuffer_as_untransferable( - v8::Local<v8::ArrayBuffer> ab) const { + v8::Local<v8::ArrayBuffer> ab) const override { return ab->SetPrivate( context(), node_env()->arraybuffer_untransferable_private_symbol(), |