summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorimhype <543717080@qq.com>2019-04-29 11:08:53 +0800
committerMichaƫl Zasso <targos@protonmail.com>2019-05-01 14:45:51 +0200
commit86c27c6005bfd803a4c518d56d55df4c52b84e61 (patch)
tree2da228f0378771903f94482762c868e541b41513
parent7be1e0af440364d7e10f377f0041f9ddd021b147 (diff)
downloadnode-new-86c27c6005bfd803a4c518d56d55df4c52b84e61.tar.gz
test: add mustcall in test-net-bytes-read.js
* add mustcall() on createServerListener * add mustcall() on listenPortListener * add mustCall() on onConnectListener * add mustCallAtLeast() on onDataListener PR-URL: https://github.com/nodejs/node/pull/27471 Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
-rw-r--r--test/parallel/test-net-bytes-read.js39
1 files changed, 24 insertions, 15 deletions
diff --git a/test/parallel/test-net-bytes-read.js b/test/parallel/test-net-bytes-read.js
index fa6b2383b4..d569d78403 100644
--- a/test/parallel/test-net-bytes-read.js
+++ b/test/parallel/test-net-bytes-read.js
@@ -6,10 +6,12 @@ const net = require('net');
const big = Buffer.alloc(1024 * 1024);
-const server = net.createServer((socket) => {
+const handler = common.mustCall((socket) => {
socket.end(big);
server.close();
-}).listen(0, () => {
+});
+
+const onListen = common.mustCall(() => {
let prev = 0;
function checkRaise(value) {
@@ -17,22 +19,29 @@ const server = net.createServer((socket) => {
prev = value;
}
- const socket = net.connect(server.address().port, () => {
- socket.on('data', (chunk) => {
- checkRaise(socket.bytesRead);
- });
+ const onData = common.mustCallAtLeast((chunk) => {
+ checkRaise(socket.bytesRead);
+ });
- socket.on('end', common.mustCall(() => {
- assert.strictEqual(socket.bytesRead, prev);
- assert.strictEqual(big.length, prev);
- }));
+ const onEnd = common.mustCall(() => {
+ assert.strictEqual(socket.bytesRead, prev);
+ assert.strictEqual(big.length, prev);
+ });
- socket.on('close', common.mustCall(() => {
- assert(!socket._handle);
- assert.strictEqual(socket.bytesRead, prev);
- assert.strictEqual(big.length, prev);
- }));
+ const onClose = common.mustCall(() => {
+ assert(!socket._handle);
+ assert.strictEqual(socket.bytesRead, prev);
+ assert.strictEqual(big.length, prev);
+ });
+ const onConnect = common.mustCall(() => {
+ socket.on('data', onData);
+ socket.on('end', onEnd);
+ socket.on('close', onClose);
socket.end();
});
+
+ const socket = net.connect(server.address().port, onConnect);
});
+
+const server = net.createServer(handler).listen(0, onListen);