diff options
| author | Rich Trott <rtrott@gmail.com> | 2017-11-12 16:29:27 -0800 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2017-11-13 11:32:11 -0800 |
| commit | d96852027c6ba6da2dab6d672b590e83ff3996ab (patch) | |
| tree | 8a634bd88e7dca1ad7496891448b0241cc31c909 | |
| parent | 29de91b64f2ec18e9d91fb89f58f371452f7b76e (diff) | |
| download | node-new-d96852027c6ba6da2dab6d672b590e83ff3996ab.tar.gz | |
doc: recommend node-core-utils for metadata
PR-URL: https://github.com/nodejs/node/pull/16978
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 5 | ||||
| -rw-r--r-- | doc/onboarding.md | 4 |
2 files changed, 4 insertions, 5 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 5346f81945..c61aad6e7d 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -501,8 +501,7 @@ commit logs, ensure that they are properly formatted, and add <a name="metadata"></a> * Modify the original commit message to include additional metadata regarding - the change process. (If you use Chrome or Edge, [`node-review`][] fetches - the metadata for you.) + the change process. ([`node-core-utils`][] fetches the metadata for you.) * Required: A `PR-URL:` line that references the *full* GitHub URL of the original pull request being merged so it's easy to trace a commit back to @@ -681,4 +680,4 @@ LTS working group and the Release team. [Stability Index]: doc/api/documentation.md#stability-index [Enhancement Proposal]: https://github.com/nodejs/node-eps [git-username]: https://help.github.com/articles/setting-your-username-in-git/ -[`node-review`]: https://github.com/evanlucas/node-review +[`node-core-utils`]: https://github.com/nodejs/node-core-utils diff --git a/doc/onboarding.md b/doc/onboarding.md index 41df0d00bd..09cbb432a2 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -158,7 +158,7 @@ onboarding session. * After one or two approvals, land the PR. * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` metadata! * [`core-validate-commit`][] helps a lot with this – install and use it if you can! - * If you use Chrome or Edge, [`node-review`][] fetches the metadata for you. + * [`node-core-utils`][] fetches the metadata for you. ## Final notes @@ -180,4 +180,4 @@ onboarding session. [Code of Conduct]: https://github.com/nodejs/TSC/blob/master/CODE_OF_CONDUCT.md [`core-validate-commit`]: https://github.com/evanlucas/core-validate-commit -[`node-review`]: https://github.com/evanlucas/node-review +[`node-core-utils`]: https://github.com/nodejs/node-core-utils |